From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ACC2C2D0CE for ; Tue, 21 Jan 2020 13:50:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65A2F24125 for ; Tue, 21 Jan 2020 13:50:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65A2F24125 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EEE916ED03; Tue, 21 Jan 2020 13:50:44 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 934D56ED03 for ; Tue, 21 Jan 2020 13:50:43 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19958746-1500050 for multiple; Tue, 21 Jan 2020 13:50:40 +0000 MIME-Version: 1.0 From: Chris Wilson User-Agent: alot/0.6 To: Mika Kuoppala , intel-gfx@lists.freedesktop.org References: <20200118105217.3484773-1-chris@chris-wilson.co.uk> <87lfq0q5zd.fsf@gaia.fi.intel.com> In-Reply-To: <87lfq0q5zd.fsf@gaia.fi.intel.com> Message-ID: <157961463891.4434.14485421708219131239@skylake-alporthouse-com> Date: Tue, 21 Jan 2020 13:50:38 +0000 Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Mika Kuoppala (2020-01-21 13:44:22) > Chris Wilson writes: > > > Try clearing the whole first page of the LRC on gen9, just in case HW > > First page of LRC is a bit misleading as this is first page of > LRC registers and techincally first page of LRC would be hwsp? I refer to the "Logical Ring" :) > So, > > s/LRC/LRC register state > > > tries peeking at the poisoned data. > > > > Signed-off-by: Chris Wilson > > Cc: Mika Kuoppala > > --- > > drivers/gpu/drm/i915/gt/intel_lrc.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > > index 2d6b41e66b16..bf0c5a998428 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > > @@ -549,7 +549,7 @@ static void set_offsets(u32 *regs, > > } > > > > if (clear) { > > - u8 count = *++data; > > + unsigned int count = *++data * 16u; > > Nitpick: const > > > > > /* Clear past the tail for HW access */ > > GEM_BUG_ON(dword_in_page(regs) > count); > > You might want to add also check that you dont write past page. > As this seems to be always confined inside a page. > > No other complaints, and above are minor so > > Reviewed-by: Mika Kuoppala It didn't stop gen9 from eating the poison, so something else is afoot. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx