* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Add Wa_1606054188:tgl (rev2)
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
@ 2020-02-01 1:36 ` Patchwork
2020-02-01 2:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (7 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-02-01 1:36 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Add Wa_1606054188:tgl (rev2)
URL : https://patchwork.freedesktop.org/series/72839/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e0d47ccc6c89 drm/i915/tgl: Add Wa_1606054188:tgl
-:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#56: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:2164:
+ if (IS_GEN(dev_priv, 12) &&
+ plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
total: 0 errors, 0 warnings, 1 checks, 34 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev2)
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
2020-02-01 1:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Add Wa_1606054188:tgl (rev2) Patchwork
@ 2020-02-01 2:31 ` Patchwork
2020-02-03 5:53 ` [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl kbuild test robot
` (6 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-02-01 2:31 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Add Wa_1606054188:tgl (rev2)
URL : https://patchwork.freedesktop.org/series/72839/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7853 -> Patchwork_16369
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/index.html
Known issues
------------
Here are the changes found in Patchwork_16369 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-hsw-peppy: [PASS][1] -> [TIMEOUT][2] ([fdo#112271] / [i915#1084])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-hsw-peppy/igt@gem_close_race@basic-threads.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-hsw-peppy/igt@gem_close_race@basic-threads.html
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [PASS][3] -> [DMESG-FAIL][4] ([i915#725])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-ivb-3770/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-ivb-3770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gtt:
- fi-kbl-7500u: [PASS][5] -> [TIMEOUT][6] ([fdo#112271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-kbl-7500u/igt@i915_selftest@live_gtt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-kbl-7500u/igt@i915_selftest@live_gtt.html
- fi-icl-u2: [PASS][7] -> [TIMEOUT][8] ([fdo#112271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-icl-u2/igt@i915_selftest@live_gtt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-icl-u2/igt@i915_selftest@live_gtt.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-icl-u2: [FAIL][9] ([fdo#103375]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u2: [FAIL][11] ([fdo#111550]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_execlists:
- fi-icl-y: [DMESG-FAIL][13] ([fdo#108569]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-icl-y/igt@i915_selftest@live_execlists.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-icl-y/igt@i915_selftest@live_execlists.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][15] ([fdo#111096] / [i915#323]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [FAIL][17] ([i915#579]) -> [SKIP][18] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][19] ([i915#563]) -> [DMESG-FAIL][20] ([i915#553] / [i915#725])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-hsw-4770/igt@i915_selftest@live_blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [FAIL][21] ([fdo#103375]) -> [DMESG-WARN][22] ([IGT#4] / [i915#263])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
Participating hosts (47 -> 41)
------------------------------
Additional (3): fi-skl-6700k2 fi-cfl-8109u fi-skl-6600u
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-snb-2520m fi-byt-n2820 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7853 -> Patchwork_16369
CI-20190529: 20190529
CI_DRM_7853: 1df04205c16923e525efe9c26d6e98612d38c9b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5409: 93aefe6baa3fabf8c0cabe83e185f7b8f8d8753d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16369: e0d47ccc6c8986a7f290b182bcb0f2b7dcbcaca3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e0d47ccc6c89 drm/i915/tgl: Add Wa_1606054188:tgl
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl
@ 2020-02-01 8:28 Matt Atwood
2020-02-01 1:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Add Wa_1606054188:tgl (rev2) Patchwork
` (8 more replies)
0 siblings, 9 replies; 12+ messages in thread
From: Matt Atwood @ 2020-02-01 8:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Ville Syrjälä
On Tiger Lake we do not support source keying in the pixel formats P010,
P012, P016.
v2: Move WA to end of function. Create helper function for format
check. Less verbose debugging messaging.
v3: whitespace
Bspec: 52890
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
CC: Ville Syrjälä <ville.syrjala@intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
drivers/gpu/drm/i915/display/intel_sprite.c | 22 +++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index 2f277d1fc6f1..71ff9849b5c0 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -2070,6 +2070,18 @@ vlv_sprite_check(struct intel_crtc_state *crtc_state,
return 0;
}
+static bool intel_format_is_p01x(int format)
+{
+ switch (format) {
+ case DRM_FORMAT_P010:
+ case DRM_FORMAT_P012:
+ case DRM_FORMAT_P016:
+ return true;
+ default:
+ return false;
+ }
+}
+
static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
const struct intel_plane_state *plane_state)
{
@@ -2143,6 +2155,16 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
return -EINVAL;
}
+ /* Wa_1606054188:tgl
+ *
+ * TODO: Add format RGB64i when implemented.
+ *
+ */
+ if (IS_GEN(dev_priv, 12) &&
+ plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
+ intel_format_is_p01x(fb->format->format))
+ DRM_DEBUG_KMS("Source color keying not supported with P01x formats\n");
+
return 0;
}
--
2.21.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
2020-02-01 1:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Add Wa_1606054188:tgl (rev2) Patchwork
2020-02-01 2:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-02-03 5:53 ` kbuild test robot
2020-02-03 9:24 ` kbuild test robot
` (5 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: kbuild test robot @ 2020-02-03 5:53 UTC (permalink / raw)
To: Matt Atwood; +Cc: Ville Syrjälä, intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3429 bytes --]
Hi Matt,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.5 next-20200131]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Matt-Atwood/drm-i915-tgl-Add-Wa_1606054188-tgl/20200203-082706
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-s2-20200203 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/display/intel_sprite.c:42:0:
drivers/gpu/drm/i915/display/intel_sprite.c: In function 'skl_plane_check_nv12_rotation':
>> drivers/gpu/drm/i915/display/intel_sprite.c:2181:13: error: 'dev_priv' undeclared (first use in this function); did you mean 'dev_crit'?
if (IS_GEN(dev_priv, 12) &&
^
drivers/gpu/drm/i915/i915_drv.h:1372:33: note: in definition of macro 'INTEL_INFO'
#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
^~~~~~~~
>> drivers/gpu/drm/i915/display/intel_sprite.c:2181:6: note: in expansion of macro 'IS_GEN'
if (IS_GEN(dev_priv, 12) &&
^~~~~~
drivers/gpu/drm/i915/display/intel_sprite.c:2181:13: note: each undeclared identifier is reported only once for each function it appears in
if (IS_GEN(dev_priv, 12) &&
^
drivers/gpu/drm/i915/i915_drv.h:1372:33: note: in definition of macro 'INTEL_INFO'
#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
^~~~~~~~
>> drivers/gpu/drm/i915/display/intel_sprite.c:2181:6: note: in expansion of macro 'IS_GEN'
if (IS_GEN(dev_priv, 12) &&
^~~~~~
vim +2181 drivers/gpu/drm/i915/display/intel_sprite.c
2160
2161 static int skl_plane_check_nv12_rotation(const struct intel_plane_state *plane_state)
2162 {
2163 const struct drm_framebuffer *fb = plane_state->hw.fb;
2164 unsigned int rotation = plane_state->hw.rotation;
2165 int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
2166
2167 /* Display WA #1106 */
2168 if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier) &&
2169 src_w & 3 &&
2170 (rotation == DRM_MODE_ROTATE_270 ||
2171 rotation == (DRM_MODE_REFLECT_X | DRM_MODE_ROTATE_90))) {
2172 DRM_DEBUG_KMS("src width must be multiple of 4 for rotated planar YUV\n");
2173 return -EINVAL;
2174 }
2175
2176 /* Wa_1606054188:tgl
2177 *
2178 * TODO: Add format RGB64i when implemented.
2179 *
2180 */
> 2181 if (IS_GEN(dev_priv, 12) &&
2182 plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
2183 intel_format_is_p01x(fb->format->format))
2184 DRM_DEBUG_KMS("Source color keying not supported with P01x formats\n");
2185
2186 return 0;
2187 }
2188
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39484 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
` (2 preceding siblings ...)
2020-02-03 5:53 ` [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl kbuild test robot
@ 2020-02-03 9:24 ` kbuild test robot
2020-02-04 21:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev2) Patchwork
` (4 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: kbuild test robot @ 2020-02-03 9:24 UTC (permalink / raw)
To: Matt Atwood; +Cc: Ville Syrjälä, intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3423 bytes --]
Hi Matt,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.5 next-20200131]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Matt-Atwood/drm-i915-tgl-Add-Wa_1606054188-tgl/20200203-082706
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-s2-20200203 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/display/intel_sprite.c:42:0:
drivers/gpu/drm/i915/display/intel_sprite.c: In function 'skl_plane_check_nv12_rotation':
>> drivers/gpu/drm/i915/display/intel_sprite.c:2181:13: error: 'dev_priv' undeclared (first use in this function)
if (IS_GEN(dev_priv, 12) &&
^
drivers/gpu/drm/i915/i915_drv.h:1372:33: note: in definition of macro 'INTEL_INFO'
#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
^~~~~~~~
drivers/gpu/drm/i915/display/intel_sprite.c:2181:6: note: in expansion of macro 'IS_GEN'
if (IS_GEN(dev_priv, 12) &&
^~~~~~
drivers/gpu/drm/i915/display/intel_sprite.c:2181:13: note: each undeclared identifier is reported only once for each function it appears in
if (IS_GEN(dev_priv, 12) &&
^
drivers/gpu/drm/i915/i915_drv.h:1372:33: note: in definition of macro 'INTEL_INFO'
#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
^~~~~~~~
drivers/gpu/drm/i915/display/intel_sprite.c:2181:6: note: in expansion of macro 'IS_GEN'
if (IS_GEN(dev_priv, 12) &&
^~~~~~
vim +/dev_priv +2181 drivers/gpu/drm/i915/display/intel_sprite.c
2160
2161 static int skl_plane_check_nv12_rotation(const struct intel_plane_state *plane_state)
2162 {
2163 const struct drm_framebuffer *fb = plane_state->hw.fb;
2164 unsigned int rotation = plane_state->hw.rotation;
2165 int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
2166
2167 /* Display WA #1106 */
2168 if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier) &&
2169 src_w & 3 &&
2170 (rotation == DRM_MODE_ROTATE_270 ||
2171 rotation == (DRM_MODE_REFLECT_X | DRM_MODE_ROTATE_90))) {
2172 DRM_DEBUG_KMS("src width must be multiple of 4 for rotated planar YUV\n");
2173 return -EINVAL;
2174 }
2175
2176 /* Wa_1606054188:tgl
2177 *
2178 * TODO: Add format RGB64i when implemented.
2179 *
2180 */
> 2181 if (IS_GEN(dev_priv, 12) &&
2182 plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
2183 intel_format_is_p01x(fb->format->format))
2184 DRM_DEBUG_KMS("Source color keying not supported with P01x formats\n");
2185
2186 return 0;
2187 }
2188
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39496 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev2)
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
` (3 preceding siblings ...)
2020-02-03 9:24 ` kbuild test robot
@ 2020-02-04 21:10 ` Patchwork
2020-02-15 6:49 ` [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
` (3 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-02-04 21:10 UTC (permalink / raw)
To: Matt Atwood; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Add Wa_1606054188:tgl (rev2)
URL : https://patchwork.freedesktop.org/series/72839/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7853_full -> Patchwork_16369_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_16369_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_caching@read-writes:
- shard-hsw: [PASS][1] -> [FAIL][2] ([i915#694])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-hsw5/igt@gem_caching@read-writes.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-hsw6/igt@gem_caching@read-writes.html
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-kbl7/igt@gem_eio@in-flight-suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-kbl4/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_schedule@fifo-bsd1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +16 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb4/igt@gem_exec_schedule@fifo-bsd1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb5/igt@gem_exec_schedule@fifo-bsd1.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +9 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb7/igt@gem_exec_schedule@in-order-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb2/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([i915#677])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb7/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb2/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#644])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-glk4/igt@gem_ppgtt@flink-and-close-vma-leak.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#644])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-tglb6/igt@gem_ppgtt@flink-and-close-vma-leak.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-tglb2/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@i915_pm_rps@waitboost:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#413])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb1/igt@i915_pm_rps@waitboost.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb8/igt@i915_pm_rps@waitboost.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][17] -> [DMESG-WARN][18] ([i915#109]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-skl4/igt@kms_color@pipe-b-ctm-0-75.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-skl2/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#52] / [i915#54])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-skl3/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#34])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-skl2/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-apl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [i915#265])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: [PASS][29] -> [DMESG-FAIL][30] ([i915#1041] / [i915#95])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-kbl1/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-kbl1/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
* igt@kms_setmode@basic:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#31])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-skl1/igt@kms_setmode@basic.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-skl3/igt@kms_setmode@basic.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#112080]) +16 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb2/igt@perf_pmu@busy-no-semaphores-vcs1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb3/igt@perf_pmu@busy-no-semaphores-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +9 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-kbl3/igt@gem_ctx_isolation@rcs0-s3.html
- shard-apl: [DMESG-WARN][37] ([i915#180]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-apl6/igt@gem_ctx_isolation@rcs0-s3.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-apl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][39] ([fdo#110841]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][41] ([fdo#110854]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb7/igt@gem_exec_balancer@smoke.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][43] ([i915#677]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb4/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][45] ([fdo#112146]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-hsw: [FAIL][47] ([i915#694]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-hsw1/igt@gem_partial_pwrite_pread@writes-after-reads.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-hsw5/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][49] ([i915#69]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-skl10/igt@gem_softpin@noreloc-s3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-skl8/igt@gem_softpin@noreloc-s3.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [INCOMPLETE][51] ([fdo#103665]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled:
- shard-skl: [FAIL][53] ([i915#52] / [i915#54]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
* igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled:
- shard-glk: [FAIL][55] ([i915#52] / [i915#54]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-glk4/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-glk7/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-tglb: [SKIP][57] ([i915#668]) -> [PASS][58] +9 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-skl: [DMESG-WARN][59] ([i915#109]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-skl4/igt@kms_plane@pixel-format-pipe-a-planes.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-skl10/igt@kms_plane@pixel-format-pipe-a-planes.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][61] ([fdo#109642] / [fdo#111068]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb5/igt@kms_psr2_su@page_flip.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][63] ([fdo#109441]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [SKIP][65] ([fdo#112080]) -> [PASS][66] +20 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb3/igt@perf_pmu@init-busy-vcs1.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb4/igt@perf_pmu@init-busy-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][67] ([fdo#109276]) -> [PASS][68] +34 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb5/igt@prime_busy@hang-bsd2.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb2/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][69] ([fdo#112080]) -> [FAIL][70] ([IGT#28])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][71] ([IGT#28]) -> [SKIP][72] ([fdo#112080])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_eio@in-flight-contexts-immediate:
- shard-apl: [TIMEOUT][73] ([fdo#112271]) -> [INCOMPLETE][74] ([CI#80] / [fdo#103927] / [i915#1098])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7853/shard-apl8/igt@gem_eio@in-flight-contexts-immediate.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/shard-apl7/igt@gem_eio@in-flight-contexts-immediate.html
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1041]: https://gitlab.freedesktop.org/drm/intel/issues/1041
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#1098]: https://gitlab.freedesktop.org/drm/intel/issues/1098
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7853 -> Patchwork_16369
CI-20190529: 20190529
CI_DRM_7853: 1df04205c16923e525efe9c26d6e98612d38c9b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5409: 93aefe6baa3fabf8c0cabe83e185f7b8f8d8753d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16369: e0d47ccc6c8986a7f290b182bcb0f2b7dcbcaca3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16369/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
` (4 preceding siblings ...)
2020-02-04 21:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev2) Patchwork
@ 2020-02-15 6:49 ` Matt Atwood
2020-02-24 22:36 ` [Intel-gfx] [PATCH v4] " Matt Roper
` (2 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Matt Atwood @ 2020-02-15 6:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Ville Syrjälä
On Tiger Lake we do not support source keying in the pixel formats P010,
P012, P016.
v2: Move WA to end of function. Create helper function for format
check. Less verbose debugging messaging.
v3: whitespace
Bspec: 52890
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
CC: Ville Syrjälä <ville.syrjala@intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
drivers/gpu/drm/i915/display/intel_sprite.c | 22 +++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index 2f277d1fc6f1..71ff9849b5c0 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -2070,6 +2070,18 @@ vlv_sprite_check(struct intel_crtc_state *crtc_state,
return 0;
}
+static bool intel_format_is_p01x(int format)
+{
+ switch (format) {
+ case DRM_FORMAT_P010:
+ case DRM_FORMAT_P012:
+ case DRM_FORMAT_P016:
+ return true;
+ default:
+ return false;
+ }
+}
+
static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
const struct intel_plane_state *plane_state)
{
@@ -2143,6 +2155,16 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
return -EINVAL;
}
+ /* Wa_1606054188:tgl
+ *
+ * TODO: Add format RGB64i when implemented.
+ *
+ */
+ if (IS_GEN(dev_priv, 12) &&
+ plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
+ intel_format_is_p01x(fb->format->format))
+ DRM_DEBUG_KMS("Source color keying not supported with P01x formats\n");
+
return 0;
}
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v4] drm/i915/tgl: Add Wa_1606054188:tgl
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
` (5 preceding siblings ...)
2020-02-15 6:49 ` [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
@ 2020-02-24 22:36 ` Matt Roper
2020-02-26 22:47 ` Souza, Jose
2020-02-25 0:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev3) Patchwork
2020-02-26 10:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
8 siblings, 1 reply; 12+ messages in thread
From: Matt Roper @ 2020-02-24 22:36 UTC (permalink / raw)
To: intel-gfx
From: Matt Atwood <matthew.s.atwood@intel.com>
On Tiger Lake we do not support source keying in the pixel formats P010,
P012, P016.
v2: Move WA to end of function. Create helper function for format
check. Less verbose debugging messaging.
v3: whitespace
v4(MattR):
- Actually return EINVAL to reject this combination.
- Pass format parameter as u32.
- Make test TGL-specific for now.
- Switch to per-device logging.
- Shorten/simplify comment.
Bspec: 52890
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_sprite.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index 7abeefe8dce5..dc7d3f3f4eb3 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -2077,6 +2077,18 @@ vlv_sprite_check(struct intel_crtc_state *crtc_state,
return 0;
}
+static bool intel_format_is_p01x(u32 format)
+{
+ switch (format) {
+ case DRM_FORMAT_P010:
+ case DRM_FORMAT_P012:
+ case DRM_FORMAT_P016:
+ return true;
+ default:
+ return false;
+ }
+}
+
static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
const struct intel_plane_state *plane_state)
{
@@ -2155,6 +2167,15 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
return -EINVAL;
}
+ /* Wa_1606054188:tgl */
+ if (IS_TIGERLAKE(dev_priv) &&
+ plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
+ intel_format_is_p01x(fb->format->format)) {
+ drm_dbg_kms(&dev_priv->drm,
+ "Source color keying not supported with P01x formats\n");
+ return -EINVAL;
+ }
+
return 0;
}
--
2.24.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev3)
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
` (6 preceding siblings ...)
2020-02-24 22:36 ` [Intel-gfx] [PATCH v4] " Matt Roper
@ 2020-02-25 0:14 ` Patchwork
2020-02-26 10:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-02-25 0:14 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Add Wa_1606054188:tgl (rev3)
URL : https://patchwork.freedesktop.org/series/72839/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8000 -> Patchwork_16695
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/index.html
Known issues
------------
Here are the changes found in Patchwork_16695 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@prime_self_import@basic-llseek-size:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([CI#94] / [i915#402]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/fi-tgl-y/igt@prime_self_import@basic-llseek-size.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/fi-tgl-y/igt@prime_self_import@basic-llseek-size.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][3] ([CI#94]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
* igt@gem_render_linear_blits@basic:
- fi-tgl-y: [DMESG-WARN][5] ([CI#94] / [i915#402]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/fi-tgl-y/igt@gem_render_linear_blits@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/fi-tgl-y/igt@gem_render_linear_blits@basic.html
* igt@i915_selftest@live_execlists:
- fi-bsw-kefka: [DMESG-FAIL][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/fi-bsw-kefka/igt@i915_selftest@live_execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/fi-bsw-kefka/igt@i915_selftest@live_execlists.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][9] ([i915#44]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111407]) -> [FAIL][12] ([fdo#111096] / [i915#323])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
Participating hosts (48 -> 43)
------------------------------
Additional (3): fi-kbl-7560u fi-byt-n2820 fi-cfl-8109u
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-byt-squawks fi-bsw-cyan fi-ilk-650 fi-blb-e6850 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8000 -> Patchwork_16695
CI-20190529: 20190529
CI_DRM_8000: e231691d89abd1b3fff01e75f142e435b44b522f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5463: d519c80219ebe558cd2fa378f26f9d73f9e35310 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16695: e991932d7a0ddafc06838a359da645e28d3b0091 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e991932d7a0d drm/i915/tgl: Add Wa_1606054188:tgl
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev3)
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
` (7 preceding siblings ...)
2020-02-25 0:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev3) Patchwork
@ 2020-02-26 10:26 ` Patchwork
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-02-26 10:26 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Add Wa_1606054188:tgl (rev3)
URL : https://patchwork.freedesktop.org/series/72839/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8000_full -> Patchwork_16695_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_16695_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112146]) +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb6/igt@gem_exec_schedule@in-order-bsd.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +16 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb3/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb8/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb1/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][7] -> [FAIL][8] ([i915#96])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_flip@flip-vs-suspend:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-apl8/igt@kms_flip@flip-vs-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-apl4/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#221])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-skl3/igt@kms_flip@flip-vs-suspend-interruptible.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-snb: [PASS][13] -> [SKIP][14] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#49])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#112080]) +10 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb2/igt@perf_pmu@init-busy-vcs1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb6/igt@perf_pmu@init-busy-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [DMESG-WARN][25] ([i915#180]) -> [PASS][26] +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-apl1/igt@gem_ctx_isolation@bcs0-s3.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-apl7/igt@gem_ctx_isolation@bcs0-s3.html
* {igt@gem_ctx_persistence@legacy-engines-mixed-process@blt}:
- shard-skl: [FAIL][27] ([i915#679]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-skl1/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-skl3/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html
* {igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox}:
- shard-skl: [INCOMPLETE][29] ([i915#1239]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-skl1/igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-skl3/igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][31] ([fdo#110841]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* {igt@gem_exec_schedule@implicit-write-read-bsd2}:
- shard-iclb: [SKIP][33] ([fdo#109276] / [i915#677]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb8/igt@gem_exec_schedule@implicit-write-read-bsd2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb1/igt@gem_exec_schedule@implicit-write-read-bsd2.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][35] ([i915#677]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb2/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb7/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][37] ([fdo#112146]) -> [PASS][38] +6 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][39] ([i915#180]) -> [PASS][40] +5 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@dpms-vs-vblank-race:
- shard-apl: [INCOMPLETE][41] ([fdo#103927]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-apl3/igt@kms_flip@dpms-vs-vblank-race.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-apl8/igt@kms_flip@dpms-vs-vblank-race.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][43] ([i915#79]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][45] ([i915#61]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-hsw5/igt@kms_flip@flip-vs-suspend-interruptible.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip_tiling@flip-y-tiled:
- shard-skl: [FAIL][47] ([i915#699]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-skl2/igt@kms_flip_tiling@flip-y-tiled.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-skl2/igt@kms_flip_tiling@flip-y-tiled.html
* {igt@kms_hdr@bpc-switch-suspend}:
- shard-skl: [FAIL][49] ([i915#1188]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf_pmu@busy-check-all-vcs1:
- shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +16 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb6/igt@perf_pmu@busy-check-all-vcs1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][55] ([fdo#109276]) -> [PASS][56] +18 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb8/igt@prime_busy@hang-bsd2.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb1/igt@prime_busy@hang-bsd2.html
* igt@sw_sync@sync_multi_producer_single_consumer:
- shard-iclb: [TIMEOUT][57] ([fdo#112271]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb6/igt@sw_sync@sync_multi_producer_single_consumer.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb5/igt@sw_sync@sync_multi_producer_single_consumer.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][59] ([fdo#112080]) -> [FAIL][60] ([IGT#28])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_fence_thrash@bo-write-verify-threaded-x:
- shard-iclb: [TIMEOUT][61] ([fdo#112271]) -> [TIMEOUT][62] ([fdo#112271] / [i915#1321]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-iclb4/igt@gem_fence_thrash@bo-write-verify-threaded-x.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-iclb3/igt@gem_fence_thrash@bo-write-verify-threaded-x.html
* igt@gem_fence_thrash@bo-write-verify-threaded-y:
- shard-skl: [TIMEOUT][63] ([fdo#112271]) -> [TIMEOUT][64] ([fdo#112271] / [i915#1321]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-skl7/igt@gem_fence_thrash@bo-write-verify-threaded-y.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-skl7/igt@gem_fence_thrash@bo-write-verify-threaded-y.html
* igt@gem_linear_blits@interruptible:
- shard-apl: [TIMEOUT][65] ([fdo#112271]) -> [TIMEOUT][66] ([fdo#112271] / [i915#1322])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-apl4/igt@gem_linear_blits@interruptible.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-apl1/igt@gem_linear_blits@interruptible.html
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [INCOMPLETE][67] ([i915#58] / [k.org#198133]) -> [DMESG-WARN][68] ([i915#716])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-glk4/igt@gen9_exec_parse@allowed-all.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-glk6/igt@gen9_exec_parse@allowed-all.html
* igt@kms_content_protection@atomic:
- shard-kbl: [TIMEOUT][69] ([fdo#112271] / [i915#1319] / [i915#727]) -> [TIMEOUT][70] ([fdo#112271] / [i915#1319])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-kbl2/igt@kms_content_protection@atomic.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-kbl6/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@legacy:
- shard-apl: [TIMEOUT][71] ([fdo#112271] / [i915#1319]) -> [FAIL][72] ([fdo#110321] / [fdo#110336])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8000/shard-apl3/igt@kms_content_protection@legacy.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/shard-apl8/igt@kms_content_protection@legacy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1239]: https://gitlab.freedesktop.org/drm/intel/issues/1239
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1321]: https://gitlab.freedesktop.org/drm/intel/issues/1321
[i915#1322]: https://gitlab.freedesktop.org/drm/intel/issues/1322
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#727]: https://gitlab.freedesktop.org/drm/intel/issues/727
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8000 -> Patchwork_16695
CI-20190529: 20190529
CI_DRM_8000: e231691d89abd1b3fff01e75f142e435b44b522f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5463: d519c80219ebe558cd2fa378f26f9d73f9e35310 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16695: e991932d7a0ddafc06838a359da645e28d3b0091 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16695/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v4] drm/i915/tgl: Add Wa_1606054188:tgl
2020-02-24 22:36 ` [Intel-gfx] [PATCH v4] " Matt Roper
@ 2020-02-26 22:47 ` Souza, Jose
2020-02-26 23:10 ` Matt Roper
0 siblings, 1 reply; 12+ messages in thread
From: Souza, Jose @ 2020-02-26 22:47 UTC (permalink / raw)
To: Roper, Matthew D, intel-gfx
On Mon, 2020-02-24 at 14:36 -0800, Matt Roper wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
>
> On Tiger Lake we do not support source keying in the pixel formats
> P010,
> P012, P016.
>
> v2: Move WA to end of function. Create helper function for format
> check. Less verbose debugging messaging.
>
> v3: whitespace
>
> v4(MattR):
> - Actually return EINVAL to reject this combination.
> - Pass format parameter as u32.
> - Make test TGL-specific for now.
> - Switch to per-device logging.
> - Shorten/simplify comment.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Bspec: 52890
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_sprite.c | 21
> +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c
> b/drivers/gpu/drm/i915/display/intel_sprite.c
> index 7abeefe8dce5..dc7d3f3f4eb3 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -2077,6 +2077,18 @@ vlv_sprite_check(struct intel_crtc_state
> *crtc_state,
> return 0;
> }
>
> +static bool intel_format_is_p01x(u32 format)
> +{
> + switch (format) {
> + case DRM_FORMAT_P010:
> + case DRM_FORMAT_P012:
> + case DRM_FORMAT_P016:
> + return true;
> + default:
> + return false;
> + }
> +}
> +
> static int skl_plane_check_fb(const struct intel_crtc_state
> *crtc_state,
> const struct intel_plane_state
> *plane_state)
> {
> @@ -2155,6 +2167,15 @@ static int skl_plane_check_fb(const struct
> intel_crtc_state *crtc_state,
> return -EINVAL;
> }
>
> + /* Wa_1606054188:tgl */
> + if (IS_TIGERLAKE(dev_priv) &&
> + plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
> + intel_format_is_p01x(fb->format->format)) {
> + drm_dbg_kms(&dev_priv->drm,
> + "Source color keying not supported with
> P01x formats\n");
> + return -EINVAL;
> + }
> +
> return 0;
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v4] drm/i915/tgl: Add Wa_1606054188:tgl
2020-02-26 22:47 ` Souza, Jose
@ 2020-02-26 23:10 ` Matt Roper
0 siblings, 0 replies; 12+ messages in thread
From: Matt Roper @ 2020-02-26 23:10 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
On Wed, Feb 26, 2020 at 02:47:24PM -0800, Souza, Jose wrote:
> On Mon, 2020-02-24 at 14:36 -0800, Matt Roper wrote:
> > From: Matt Atwood <matthew.s.atwood@intel.com>
> >
> > On Tiger Lake we do not support source keying in the pixel formats
> > P010,
> > P012, P016.
> >
> > v2: Move WA to end of function. Create helper function for format
> > check. Less verbose debugging messaging.
> >
> > v3: whitespace
> >
> > v4(MattR):
> > - Actually return EINVAL to reject this combination.
> > - Pass format parameter as u32.
> > - Make test TGL-specific for now.
> > - Switch to per-device logging.
> > - Shorten/simplify comment.
>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Applied to dinq. Thanks for the review.
Matt
>
> >
> > Bspec: 52890
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_sprite.c | 21
> > +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c
> > b/drivers/gpu/drm/i915/display/intel_sprite.c
> > index 7abeefe8dce5..dc7d3f3f4eb3 100644
> > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > @@ -2077,6 +2077,18 @@ vlv_sprite_check(struct intel_crtc_state
> > *crtc_state,
> > return 0;
> > }
> >
> > +static bool intel_format_is_p01x(u32 format)
> > +{
> > + switch (format) {
> > + case DRM_FORMAT_P010:
> > + case DRM_FORMAT_P012:
> > + case DRM_FORMAT_P016:
> > + return true;
> > + default:
> > + return false;
> > + }
> > +}
> > +
> > static int skl_plane_check_fb(const struct intel_crtc_state
> > *crtc_state,
> > const struct intel_plane_state
> > *plane_state)
> > {
> > @@ -2155,6 +2167,15 @@ static int skl_plane_check_fb(const struct
> > intel_crtc_state *crtc_state,
> > return -EINVAL;
> > }
> >
> > + /* Wa_1606054188:tgl */
> > + if (IS_TIGERLAKE(dev_priv) &&
> > + plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
> > + intel_format_is_p01x(fb->format->format)) {
> > + drm_dbg_kms(&dev_priv->drm,
> > + "Source color keying not supported with
> > P01x formats\n");
> > + return -EINVAL;
> > + }
> > +
> > return 0;
> > }
> >
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-02-26 23:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-01 8:28 [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
2020-02-01 1:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Add Wa_1606054188:tgl (rev2) Patchwork
2020-02-01 2:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-03 5:53 ` [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl kbuild test robot
2020-02-03 9:24 ` kbuild test robot
2020-02-04 21:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev2) Patchwork
2020-02-15 6:49 ` [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl Matt Atwood
2020-02-24 22:36 ` [Intel-gfx] [PATCH v4] " Matt Roper
2020-02-26 22:47 ` Souza, Jose
2020-02-26 23:10 ` Matt Roper
2020-02-25 0:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add Wa_1606054188:tgl (rev3) Patchwork
2020-02-26 10:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).