From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886AAC3B187 for ; Tue, 11 Feb 2020 16:45:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A6E920714 for ; Tue, 11 Feb 2020 16:45:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A6E920714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E934B89DA4; Tue, 11 Feb 2020 16:45:16 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A61D89D86; Tue, 11 Feb 2020 16:45:15 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20189866-1500050 for multiple; Tue, 11 Feb 2020 16:45:01 +0000 MIME-Version: 1.0 To: Janusz Krzysztofik , igt-dev@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20200211143048.12260-1-janusz.krzysztofik@linux.intel.com> References: <20200211143048.12260-1-janusz.krzysztofik@linux.intel.com> Message-ID: <158143949995.3635.18328569070749519341@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Tue, 11 Feb 2020 16:44:59 +0000 Subject: Re: [Intel-gfx] [RFC PATCH i-g-t v2] tests/gem_userptr_blits: Enhance invalid mapping exercise X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Janusz Krzysztofik (2020-02-11 14:30:48) > @@ -2009,8 +2016,31 @@ igt_main_args("c:", NULL, help_str, opt_handler, NULL) > igt_subtest("invalid-null-pointer") > test_invalid_null_pointer(fd); > > - igt_subtest("invalid-gtt-mapping") > - test_invalid_gtt_mapping(fd); > + igt_describe("Verify userptr on top of GTT mapping to GEM object will fail"); > + igt_subtest("invalid-gtt-mapping") { > + gem_require_mappable_ggtt(fd); > + test_invalid_mapping(fd, I915_MMAP_OFFSET_GTT); > + } #include "i915/gem_mman.h" igt_subtest_with_dynamic("invalid-mmap-offset") { for_each_mmap_offset_type(t) { igt_dynamic_f("%s", t->name) test_invalid_mapping(fd, t); In test_invalid_mapping, instead of do_ioctl(MMAP_OFFSET) use igt_require(igt_ioctl(MMAP_OFFSET, &arg) == 0); (Or igt_require_f if you like to keep the spiel.) } } } _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx