From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED049C352A4 for ; Wed, 12 Feb 2020 21:29:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC9A9206DB for ; Wed, 12 Feb 2020 21:29:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC9A9206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 656A46E111; Wed, 12 Feb 2020 21:29:15 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AE6B6E111; Wed, 12 Feb 2020 21:29:14 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 22F33A0009; Wed, 12 Feb 2020 21:29:14 +0000 (UTC) MIME-Version: 1.0 From: Patchwork To: "Daniele Ceraolo Spurio" Date: Wed, 12 Feb 2020 21:29:14 -0000 Message-ID: <158154295411.24264.8206733112420342850@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20200212003124.33844-1-daniele.ceraolospurio@intel.com> In-Reply-To: <20200212003124.33844-1-daniele.ceraolospurio@intel.com> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_Commit_early_to_GuC_=28rev3=29?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: Commit early to GuC (rev3) URL : https://patchwork.freedesktop.org/series/72031/ State : warning == Summary == $ dim checkpatch origin/drm-tip 86c2261830f8 drm/i915/debugfs: Pass guc_log struct to i915_guc_log_info 434763d74348 drm/i915/guc: Kill USES_GUC macro 9c3bd7cffa07 drm/i915/guc: Kill USES_GUC_SUBMISSION macro 53a7bb512097 drm/i915/uc: Update the FW status on injected fetch error ac5ee731ad09 drm/i915/uc: autogenerate uC checker functions -:32: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #32: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:43: +#define __uc_state_checker(x, state, required) \ +static inline bool intel_uc_##state##_##x(struct intel_uc *uc) \ +{ \ + return intel_##x##_is_##required(&uc->x); \ } -:42: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #42: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:49: +#define uc_state_checkers(x) \ +__uc_state_checker(x, supports, supported) \ +__uc_state_checker(x, uses, enabled) -:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:49: +#define uc_state_checkers(x) \ +__uc_state_checker(x, supports, supported) \ +__uc_state_checker(x, uses, enabled) total: 1 errors, 0 warnings, 2 checks, 44 lines checked 300e9108bf45 drm/i915/uc: Improve tracking of uC init status c7b983206d15 drm/i915/guc: Apply new uC status tracking to GuC submission as well -:246: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #246: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:65: +#define __uc_state_checker(x, func, state, required) \ +static inline bool intel_uc_##state##_##func(struct intel_uc *uc) \ { \ + return intel_##func##_is_##required(&uc->x); \ } -:257: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #257: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:71: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) -:257: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #257: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:71: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) -:257: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #257: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:71: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) total: 1 errors, 0 warnings, 3 checks, 250 lines checked 6df67d7fcd06 drm/i915/uc: Abort early on uc_init failure e5b2f4d6ca34 drm/i915/uc: consolidate firmware cleanup 70b2b644b94a HAX: drm/i915: default to enable_guc=2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx