From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dale B Stimson <dale.b.stimson@intel.com>,
igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result
Date: Thu, 13 Feb 2020 20:44:37 +0000 [thread overview]
Message-ID: <158162667762.4660.5467892000864292172@skylake-alporthouse-com> (raw)
In-Reply-To: <20200213192606.63025-1-dale.b.stimson@intel.com>
Quoting Dale B Stimson (2020-02-13 19:26:06)
> Function intel_get_current_engine() should return NULL (instead of
> engine 0) if there are no engines.
There should be some igt to put basic use of for_each_engine() though
its paces. Nothing fancy, just complete a loop....
Andi, am I imagining this? I swear saw patches from you to do the
basics.
Anyway, there should be some, and this is worth adding to them,
for_each_context_engine() on an empty engines[] and assert we do not
enter the loop.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-13 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 19:26 [Intel-gfx] [PATCH i-g-t] lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result Dale B Stimson
2020-02-13 20:44 ` Chris Wilson [this message]
2020-02-14 18:43 ` Antonio Argenziano
2020-02-14 18:44 ` Chris Wilson
2020-02-14 18:54 ` Chris Wilson
2020-02-14 19:14 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158162667762.4660.5467892000864292172@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=dale.b.stimson@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).