From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91236C3F2D2 for ; Fri, 28 Feb 2020 23:37:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EAF72469C for ; Fri, 28 Feb 2020 23:37:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EAF72469C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09D426F532; Fri, 28 Feb 2020 23:37:29 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2747C6F537; Fri, 28 Feb 2020 23:37:27 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20391406-1500050 for multiple; Fri, 28 Feb 2020 23:37:24 +0000 MIME-Version: 1.0 To: Andi Shyti From: Chris Wilson In-Reply-To: <20200228233448.GE11891@jack.zhora.eu> References: <20200228104340.2895082-1-chris@chris-wilson.co.uk> <20200228104340.2895082-4-chris@chris-wilson.co.uk> <20200228233448.GE11891@jack.zhora.eu> Message-ID: <158293304248.29794.5765520201928001036@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Fri, 28 Feb 2020 23:37:22 +0000 Subject: Re: [Intel-gfx] [PATCH i-g-t 4/5] i915: Exercise sysfs heartbeat controls X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Andi Shyti (2020-02-28 23:34:48) > On Fri, Feb 28, 2020 at 10:43:39AM +0000, Chris Wilson wrote: > > We [will] expose various per-engine scheduling controls. One of which, > > 'heartbeat_duration_ms', defines how often we send a heartbeat down the > > engine to check upon the health of the engine. If a heartbeat does not > > complete within the interval (or two), the engine is declared hung. > > > > Signed-off-by: Chris Wilson > > Someone with not a good eye might swear to have read this patch > once, and at patch 5/5 he will ask again the same question. > > Why don't we put together in a library the things that patch > 3/4/5 have in common? They are. It's basically a repeating pattern of testing with local assumptions. For the sole reason that I'm not very inventive. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx