From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Fix dbuf slice mask when turning off all the pipes
Date: Mon, 18 May 2020 14:14:15 +0100 [thread overview]
Message-ID: <158980765594.17769.1625000273900850456@build.alporthouse.com> (raw)
In-Reply-To: <20200518121354.20401-1-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2020-05-18 13:13:54)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The current dbuf slice computation only happens when there are
> active pipes. If we are turning off all the pipes we just leave
> the dbuf slice mask at it's previous value, which may be something
> other that BIT(S1). If runtime PM will kick in it will however
> turn off everything but S1. Then on the next atomic commit (if
> the new dbuf slice mask matches the stale value we left behind)
> the code will not turn on the other slices we now need. This will
> lead to underruns as the planes are trying to use a dbuf slice
> that's not powered up.
>
> To work around let's just just explicitly set the dbuf slice mask
> to BIT(S1) when we are turning off all the pipes. Really the code
> should just calculate this stuff the same way regardless whether
> the pipes are on or off, but we're not quite there yet (need a
> bit more work on the dbuf state for that).
>
> v2: Let's not put the fix into dead code
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk> #v1
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> Fixes: 3cf43cdc63fb ("drm/i915: Introduce proper dbuf state")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-18 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 16:15 [Intel-gfx] [PATCH] drm/i915: Fix dbuf slice mask when turning off all the pipes Ville Syrjala
2020-05-16 19:49 ` Chris Wilson
2020-05-17 12:12 ` Lisovskiy, Stanislav
2020-05-18 6:33 ` Ville Syrjälä
2020-05-18 13:31 ` Lisovskiy, Stanislav
2020-05-18 9:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-18 10:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-05-18 12:13 ` [Intel-gfx] [PATCH v2] " Ville Syrjala
2020-05-18 13:14 ` Chris Wilson [this message]
2020-05-18 18:01 ` Ville Syrjälä
2020-05-18 14:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix dbuf slice mask when turning off all the pipes (rev2) Patchwork
2020-05-18 17:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158980765594.17769.1625000273900850456@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).