From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E26E4C433DF for ; Tue, 19 May 2020 12:56:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 949C82081A for ; Tue, 19 May 2020 12:56:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 949C82081A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B87F89F92; Tue, 19 May 2020 12:56:08 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50D8D89F92 for ; Tue, 19 May 2020 12:56:06 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21228354-1500050 for multiple; Tue, 19 May 2020 13:56:02 +0100 MIME-Version: 1.0 In-Reply-To: <87sgfw5bx8.fsf@gaia.fi.intel.com> References: <20200518143947.30606-1-chris@chris-wilson.co.uk> <20200519114155.8166-1-chris@chris-wilson.co.uk> <87sgfw5bx8.fsf@gaia.fi.intel.com> To: Mika Kuoppala , intel-gfx@lists.freedesktop.org From: Chris Wilson Message-ID: <158989296114.8153.10630728602688441106@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Tue, 19 May 2020 13:56:01 +0100 Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Measure dispatch latency X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Mika Kuoppala (2020-05-19 13:47:31) > Chris Wilson writes: > > > A useful metric of the system's health is how fast we can tell the GPU > > to do various actions, so measure our latency. > > > > v2: Refactor all the instruction building into emitters. > > > > Signed-off-by: Chris Wilson > > Cc: Mika Kuoppala > > Cc: Joonas Lahtinen > > Not much nitpicking left. Could have used one goto in the fence > using tests on error paths but meh. Error handling is not great here, I agree. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx