From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE128C433DF for ; Fri, 24 Jul 2020 12:06:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB5B52073E for ; Fri, 24 Jul 2020 12:06:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB5B52073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CC1E6E959; Fri, 24 Jul 2020 12:06:21 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 552EC6E959 for ; Fri, 24 Jul 2020 12:06:19 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21918512-1500050 for multiple; Fri, 24 Jul 2020 13:06:16 +0100 MIME-Version: 1.0 In-Reply-To: <87tuxx1610.fsf@gaia.fi.intel.com> References: <20200723183348.4037-1-chris@chris-wilson.co.uk> <159552931718.21069.13813749151778428706@build.alporthouse.com> <87tuxx1610.fsf@gaia.fi.intel.com> From: Chris Wilson To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Date: Fri, 24 Jul 2020 13:06:15 +0100 Message-ID: <159559237550.21069.11909922893997723896@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Delay tracking the GEM context until it is registered X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Mika Kuoppala (2020-07-24 12:55:39) > Chris Wilson writes: > > > Quoting Chris Wilson (2020-07-23 19:33:48) > >> Avoid exposing a partially constructed context by deferring the > >> list_add() from the initial construction to the end of registration. > >> Otherwise, if we peek into the list of contexts from inside debugfs, we > >> may see the partially constructed context and change down some dangling > > > > s/change/chase/ > > that. > > Are you sure about the fixes as it is not the commit that > actually introduces the registration into context.list? > > For me it looks like it is a4e7ccdac38e. The one I picked was where we started adding more context setup after the final step of list_add in __create_context(). More apropos would be 3aa9945a528e ("drm/i915: Separate GEM context construction and registration to userspace") in the same kernel. In the other direction, we have f6e8aa387171 ("drm/i915: Report the number of closed vma held by each context in debugfs") where we start using the contexts.list in debugfs. In a4e7ccdac38e we are only moving the list_add(&ctx->link) around in __create_context(). -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx