From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF89C433DB for ; Tue, 19 Jan 2021 10:34:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 048D420867 for ; Tue, 19 Jan 2021 10:34:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 048D420867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D9166E082; Tue, 19 Jan 2021 10:34:39 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE6C26E082 for ; Tue, 19 Jan 2021 10:34:37 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23637188-1500050 for multiple; Tue, 19 Jan 2021 10:34:34 +0000 MIME-Version: 1.0 In-Reply-To: <87pn21gr5h.fsf@gaia.fi.intel.com> References: <20210119094053.6919-1-chris@chris-wilson.co.uk> <87pn21gr5h.fsf@gaia.fi.intel.com> From: Chris Wilson To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Date: Tue, 19 Jan 2021 10:34:33 +0000 Message-ID: <161105247378.19402.6684577298292307177@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915/gt: One more flush for Baytrail clear residuals X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Mika Kuoppala (2021-01-19 10:25:14) > Chris Wilson writes: > > > CI reports that Baytail requires one more invalidate after CACHE_MODE > > for it to be happy. > > > > Fixes: ace44e13e577 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals") > > Signed-off-by: Chris Wilson > > Cc: Mika Kuoppala > > Cc: Akeem G Abodunrin > > --- > > drivers/gpu/drm/i915/gt/gen7_renderclear.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c > > index 39478712769f..8551e6de50e8 100644 > > --- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c > > +++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c > > @@ -353,19 +353,21 @@ static void gen7_emit_pipeline_flush(struct batch_chunk *batch) > > > > static void gen7_emit_pipeline_invalidate(struct batch_chunk *batch) > > { > > - u32 *cs = batch_alloc_items(batch, 0, 8); > > + u32 *cs = batch_alloc_items(batch, 0, 10); > > > > /* ivb: Stall before STATE_CACHE_INVALIDATE */ > > - *cs++ = GFX_OP_PIPE_CONTROL(4); > > + *cs++ = GFX_OP_PIPE_CONTROL(5); > > *cs++ = PIPE_CONTROL_STALL_AT_SCOREBOARD | > > PIPE_CONTROL_CS_STALL; > > *cs++ = 0; > > *cs++ = 0; > > + *cs++ = 0; > > dw[5] seems to be only for gen8+. Does it make a difference? Pipe-control has always supported a qword-write, so a packet-length of 4 or 5 on gen4-7. As I recall the debate for gen8+ was whether pipe-control still supported only a dword-write, and so we went with always using the qword-length. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx