intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Lyude Paul" <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev4)
Date: Tue, 26 Jan 2021 02:18:13 -0000	[thread overview]
Message-ID: <161162749375.9813.4218131673816333505@emeril.freedesktop.org> (raw)
In-Reply-To: <20210126001031.881048-1-lyude@redhat.com>

== Series Details ==

Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev4)
URL   : https://patchwork.freedesktop.org/series/84754/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
fe77c1e29c45 drm/nouveau/kms/nv40-/backlight: Assign prop type once
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 22 lines checked
13a7a2e26126 drm/nouveau/kms: Don't probe eDP connectors more then once
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6: 
eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a

-:23: CHECK:CAMELCASE: Avoid CamelCase: <DCB_CONNECTOR_eDP>
#23: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:560:
+	if (nv_connector->type == DCB_CONNECTOR_eDP &&

total: 0 errors, 1 warnings, 1 checks, 12 lines checked
ff5e1e98cbc2 drm/i915/dp: Remove redundant AUX backlight frequency calculations
72f9fc4aadbe drm/dp: Extract i915's eDP backlight code into DRM helpers
c574a4addb61 drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau
-:247: CHECK:CAMELCASE: Avoid CamelCase: <DCB_CONNECTOR_eDP>
#247: FILE: drivers/gpu/drm/nouveau/nouveau_backlight.c:299:
+	if (nv_conn->type == DCB_CONNECTOR_eDP) {

total: 0 errors, 0 warnings, 1 checks, 311 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-01-26  2:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26  0:10 [Intel-gfx] [RFC v2 0/5] drm: Extract DPCD backlight helpers from i915, add support in nouveau Lyude Paul
2021-01-26  0:10 ` [Intel-gfx] [RFC v2 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once Lyude Paul
2021-01-26  0:10 ` [Intel-gfx] [RFC v2 2/5] drm/nouveau/kms: Don't probe eDP connectors more then once Lyude Paul
2021-01-26  0:10 ` [Intel-gfx] [RFC v2 3/5] drm/i915/dp: Remove redundant AUX backlight frequency calculations Lyude Paul
2021-01-26  0:10 ` [Intel-gfx] [RFC v2 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers Lyude Paul
2021-02-03 20:58   ` Rodrigo Vivi
2021-02-03 21:29     ` Lyude Paul
2021-01-26  0:10 ` [Intel-gfx] [RFC v2 5/5] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau Lyude Paul
2021-01-26  2:18 ` Patchwork [this message]
2021-01-26  2:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev4) Patchwork
2021-01-26  2:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-26  8:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161162749375.9813.4218131673816333505@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).