From: Chris Wilson <chris@chris-wilson.co.uk>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 4/8] drm/i915: introduce mem->reserved
Date: Tue, 26 Jan 2021 15:35:51 +0000 [thread overview]
Message-ID: <161167535110.2943.16119545695449363866@build.alporthouse.com> (raw)
In-Reply-To: <20210126151259.253885-4-matthew.auld@intel.com>
Quoting Matthew Auld (2021-01-26 15:12:55)
> From: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
>
> In the following patch we need to reserve regions unaccessible to the
> driver during initialization, so add mem->reserved for collecting such
> regions.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/i915/intel_memory_region.c | 2 +
> drivers/gpu/drm/i915/intel_memory_region.h | 2 +
> .../drm/i915/selftests/intel_memory_region.c | 89 +++++++++++++++++++
> 3 files changed, 93 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
> index b1b610bfff09..803a414c9523 100644
> --- a/drivers/gpu/drm/i915/intel_memory_region.c
> +++ b/drivers/gpu/drm/i915/intel_memory_region.c
> @@ -156,6 +156,7 @@ int intel_memory_region_init_buddy(struct intel_memory_region *mem)
>
> void intel_memory_region_release_buddy(struct intel_memory_region *mem)
> {
> + i915_buddy_free_list(&mem->mm, &mem->reserved);
> i915_buddy_fini(&mem->mm);
> }
>
> @@ -185,6 +186,7 @@ intel_memory_region_create(struct drm_i915_private *i915,
> mutex_init(&mem->objects.lock);
> INIT_LIST_HEAD(&mem->objects.list);
> INIT_LIST_HEAD(&mem->objects.purgeable);
> + INIT_LIST_HEAD(&mem->reserved);
>
> mutex_init(&mem->mm_lock);
>
> diff --git a/drivers/gpu/drm/i915/intel_memory_region.h b/drivers/gpu/drm/i915/intel_memory_region.h
> index 6ffc0673f005..8c9947bba3e8 100644
> --- a/drivers/gpu/drm/i915/intel_memory_region.h
> +++ b/drivers/gpu/drm/i915/intel_memory_region.h
> @@ -89,6 +89,8 @@ struct intel_memory_region {
> unsigned int id;
> char name[8];
>
> + struct list_head reserved;
So you added this, but this is not exercised by the selftest either.
I think you want to complete the API with
intel_memory_region_reserve(mem, start, size/end)
And then inspect the mem->reserved rather than the local list.
Presumably check the mem->reserved is empty on entry, and then it's
safe to call i915_buddy_free_list(&mem->mm, &mem->reserved) directly.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-26 15:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 15:12 [Intel-gfx] [PATCH v2 1/8] drm/i915: make local-memory probing a GT operation Matthew Auld
2021-01-26 15:12 ` [Intel-gfx] [PATCH v2 2/8] drm/i915: setup the LMEM region Matthew Auld
2021-01-26 15:26 ` Chris Wilson
2021-01-26 15:12 ` [Intel-gfx] [PATCH v2 3/8] drm/i915: reserve stolen for " Matthew Auld
2021-01-26 15:31 ` Chris Wilson
2021-01-26 15:12 ` [Intel-gfx] [PATCH v2 4/8] drm/i915: introduce mem->reserved Matthew Auld
2021-01-26 15:35 ` Chris Wilson [this message]
2021-01-26 15:12 ` [Intel-gfx] [PATCH v2 5/8] drm/i915/dg1: Reserve first 1MB of local memory Matthew Auld
2021-01-26 15:39 ` Chris Wilson
2021-01-26 15:12 ` [Intel-gfx] [PATCH v2 6/8] drm/i915: allocate context from LMEM Matthew Auld
2021-01-26 15:40 ` Chris Wilson
2021-01-26 15:12 ` [Intel-gfx] [PATCH v2 7/8] drm/i915: move engine scratch to LMEM Matthew Auld
2021-01-26 15:12 ` [Intel-gfx] [PATCH v2 8/8] drm/i915: allocate cmd ring in lmem Matthew Auld
2021-01-26 15:41 ` Chris Wilson
2021-01-26 15:16 ` [Intel-gfx] [PATCH v2 1/8] drm/i915: make local-memory probing a GT operation Chris Wilson
2021-01-26 15:22 ` Chris Wilson
2021-01-26 15:28 ` Chris Wilson
2021-01-26 19:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/8] " Patchwork
2021-01-26 20:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-26 20:16 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161167535110.2943.16119545695449363866@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=abdiel.janulgue@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).