From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACCF1C433E0 for ; Tue, 26 Jan 2021 18:59:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06BB02228A for ; Tue, 26 Jan 2021 18:59:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06BB02228A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 775576E086; Tue, 26 Jan 2021 18:59:58 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41A366E086 for ; Tue, 26 Jan 2021 18:59:56 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23707257-1500050 for multiple; Tue, 26 Jan 2021 18:59:50 +0000 MIME-Version: 1.0 In-Reply-To: References: <20200106234703.645168-1-matthew.auld@intel.com> From: Chris Wilson To: Matthew Auld , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Date: Tue, 26 Jan 2021 18:59:52 +0000 Message-ID: <161168759268.2943.16198172842245466140@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH] drm/i915/gtt: split up i915_gem_gtt X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Tvrtko Ursulin (2021-01-26 17:13:24) > > > On 06/01/2020 23:47, Matthew Auld wrote: > > Attempt to split i915_gem_gtt.[ch] into more manageable chunks. > > > +void clear_pages(struct i915_vma *vma) > > +{ > > + GEM_BUG_ON(!vma->pages); > > + > > + if (vma->pages != vma->obj->mm.pages) { > > + sg_free_table(vma->pages); > > + kfree(vma->pages); > > + } > > + vma->pages = NULL; > > + > > + memset(&vma->page_sizes, 0, sizeof(vma->page_sizes)); > > +} > > We probably want to add a prefix now that the function is exported. Or follow through on eliminating the callback. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx