intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-gfx] 5.14-rc2 warnings with kvmgvt
@ 2021-07-21 11:10 Christoph Hellwig
  2021-07-21 11:24 ` Rodrigo Vivi
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Christoph Hellwig @ 2021-07-21 11:10 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi; +Cc: intel-gfx, intel-gvt-dev

Hi all,

I'm trying to test some changes for the gvt code, but even with a baseline
5.14-rc2 host and guest the 915 driver does not seem overly happy:

[    5.693099] i915 0000:00:04.0: [drm] Virtual GPU for Intel GVT-g detected.
[    5.694841] i915 0000:00:04.0: [drm] VT-d active for gfx access
[    5.696411] i915 0000:00:04.0: [drm] iGVT-g active, disabling use of stolen memory
[    5.711317] i915 0000:00:04.0: BAR 6: can't assign [??? 0x00000000 flags 0x20000000] (bogus alignm)
[    5.712847] i915 0000:00:04.0: [drm] Failed to find VBIOS tables (VBT)
[    5.714343] i915 0000:00:04.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=none:owns=iom
[    5.716466] i915 0000:00:04.0: Direct firmware load for i915/kbl_dmc_ver1_04.bin failed with error2
[    5.718021] i915 0000:00:04.0: [drm] Failed to load DMC firmware i915/kbl_dmc_ver1_04.bin. Disabli.
[    5.719914] i915 0000:00:04.0: [drm] DMC firmware homepage: https://git.kernel.org/pub/scm/linux/k5
[    5.733269] i915 0000:00:04.0: [drm] failed to retrieve link info, disabling eDP
[    5.735841] i915 0000:00:04.0: [drm] *ERROR* crtc 51: Can't calculate constants, dotclock = 0!
[    5.737354] ------------[ cut here ]------------
[    5.738141] i915 0000:00:04.0: drm_WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev))
[    5.738165] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/drm_vblank.c:728 drm_crtc_vblank_helper_get_0
[    5.738745] Modules linked in:
[    5.738745] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.14.0-rc2+ #22
[    5.738745] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
[    5.738745] RIP: 0010:drm_crtc_vblank_helper_get_vblank_timestamp_internal+0x335/0x350
[    5.738745] Code: 4c 8b 6f 50 4d 85 ed 75 03 4c 8b 2f e8 34 10 26 00 48 c7 c1 20 54 0d 83 4c 89 ea0
[    5.738745] RSP: 0000:ffffc90000013a90 EFLAGS: 00010086
[    5.738745] RAX: 0000000000000000 RBX: ffffffff81c3c5b0 RCX: 0000000000000000
[    5.738745] RDX: 0000000000000003 RSI: 00000000fffeffff RDI: 00000000ffffffff
[    5.738745] RBP: ffffc90000013b00 R08: ffffffff83bb3e28 R09: 0000000000000003
[    5.738745] R10: ffffffff834b3e40 R11: 3fffffffffffffff R12: 0000000000000000
[    5.738745] R13: ffff888100e982f0 R14: ffff8881053f0340 R15: ffff888105592178
[    5.738745] FS:  0000000000000000(0000) GS:ffff88813bc00000(0000) knlGS:0000000000000000
[    5.738745] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    5.738745] CR2: 0000000000000000 CR3: 0000000003462000 CR4: 00000000000006f0
[    5.738745] Call Trace:
[    5.738745]  drm_get_last_vbltimestamp+0xa5/0xb0
[    5.738745]  drm_reset_vblank_timestamp+0x56/0xc0
[    5.738745]  drm_crtc_vblank_on+0x81/0x140
[    5.738745]  intel_crtc_vblank_on+0x2b/0xe0
[    5.738745]  intel_modeset_setup_hw_state+0xa9c/0x1ab0
[    5.738745]  ? ww_mutex_lock+0x2b/0x90
[    5.738745]  intel_modeset_init_nogem+0x3c5/0x1310
[    5.738745]  ? intel_irq_postinstall+0x1aa/0x520
[    5.738745]  i915_driver_probe+0x695/0xd30
[    5.738745]  ? _raw_spin_unlock_irqrestore+0x33/0x50
[    5.738745]  pci_device_probe+0xcd/0x140
[    5.738745]  really_probe.part.0+0x99/0x270
[    5.738745]  __driver_probe_device+0x8b/0x120
[    5.738745]  driver_probe_device+0x19/0x90
[    5.738745]  __driver_attach+0x79/0x120
[    5.738745]  ? __device_attach_driver+0x90/0x90
[    5.738745]  bus_for_each_dev+0x78/0xc0
[    5.738745]  bus_add_driver+0x109/0x1b0
[    5.738745]  driver_register+0x86/0xd0
[    5.738745]  ? ttm_init+0x18/0x18
[    5.738745]  i915_init+0x58/0x72
[    5.738745]  do_one_initcall+0x56/0x2e0
[    5.738745]  ? rcu_read_lock_sched_held+0x3a/0x70
[    5.738745]  kernel_init_freeable+0x186/0x1ce
[    5.738745]  ? rest_init+0x250/0x250
[    5.738745]  kernel_init+0x11/0x110
[    5.738745]  ret_from_fork+0x22/0x30
[    5.738745] irq event stamp: 8200428
[    5.738745] hardirqs last  enabled at (8200427): [<ffffffff825d38e8>] _raw_spin_unlock_irqrestore+0
[    5.738745] hardirqs last disabled at (8200428): [<ffffffff825d3671>] _raw_spin_lock_irq+0x41/0x50
[    5.738745] softirqs last  enabled at (8199086): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
[    5.738745] softirqs last disabled at (8199079): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
[    5.738745] ---[ end trace e99e0812b8ee9c5d ]---
[    5.786472] i915 0000:00:04.0: [drm] VGT ballooning configuration:
[    5.787531] i915 0000:00:04.0: [drm] Mappable graphic memory: base 0x31c7000 size 65536KiB
[    5.788865] i915 0000:00:04.0: [drm] Unmappable graphic memory: base 0xe7ef8000 size 393216KiB
[    5.790270] i915 0000:00:04.0: [drm] balloon space: range [ 0x10000000 - 0xe7ef8000 ] 3537888 KiB.
[    5.791807] i915 0000:00:04.0: [drm] balloon space: range [ 0xffef8000 - 0x100000000 ] 1056 KiB.
[    5.793241] i915 0000:00:04.0: [drm] balloon space: range [ 0x0 - 0x31c7000 ] 50972 KiB.
[    5.794565] i915 0000:00:04.0: [drm] balloon space: range [ 0x71c7000 - 0x10000000 ] 145636 KiB.
[    5.796028] i915 0000:00:04.0: [drm] VGT balloon successfully
[    6.670284] ------------[ cut here ]------------
[    6.671155] crtc active state doesn't match with hw state (expected 0, found 1)
[    6.672376] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/i915/display/intel_display.c:8964 intel_atom0
[    6.674232] Modules linked in:
[    6.674767] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G        W         5.14.0-rc2+ #22
[    6.676039] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
[    6.677402] RIP: 0010:intel_atomic_commit_tail+0x13c9/0x1410
[    6.678335] Code: 0f 0b 0f b6 34 24 89 f1 e9 8d fc ff ff e8 7f 19 7f 00 0f 0b e9 30 fd ff ff e8 739
[    6.681400] RSP: 0000:ffffc90000013b20 EFLAGS: 00010282
[    6.682264] RAX: 0000000000000000 RBX: ffff888105593800 RCX: 0000000000000000
[    6.683453] RDX: 0000000000000001 RSI: ffffffff831a6e3f RDI: 00000000ffffffff
[    6.684623] RBP: ffff888104ab2000 R08: 0000000000000001 R09: 0000000000000001
[    6.685782] R10: 00000000ffff0000 R11: 3fffffffffffffff R12: ffff888104baa000
[    6.686972] R13: ffff888104e5a000 R14: ffff8881053f0000 R15: ffff8881053f0000
[    6.688147] FS:  0000000000000000(0000) GS:ffff88813bc00000(0000) knlGS:0000000000000000
[    6.689475] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    6.690421] CR2: 0000000000000000 CR3: 0000000003462000 CR4: 00000000000006f0
[    6.691611] Call Trace:
[    6.692038]  intel_atomic_commit+0x32d/0x3b0
[    6.692751]  intel_initial_commit+0x156/0x1e0
[    6.693488]  intel_modeset_init+0x19/0x80
[    6.694156]  i915_driver_probe+0x6bb/0xd30
[    6.694860]  ? _raw_spin_unlock_irqrestore+0x33/0x50
[    6.695690]  pci_device_probe+0xcd/0x140
[    6.696346]  really_probe.part.0+0x99/0x270
[    6.697041]  __driver_probe_device+0x8b/0x120
[    6.697767]  driver_probe_device+0x19/0x90
[    6.698459]  __driver_attach+0x79/0x120
[    6.699120]  ? __device_attach_driver+0x90/0x90
[    6.699878]  bus_for_each_dev+0x78/0xc0
[    6.700522]  bus_add_driver+0x109/0x1b0
[    6.701163]  driver_register+0x86/0xd0
[    6.701786]  ? ttm_init+0x18/0x18
[    6.702342]  i915_init+0x58/0x72
[    6.702906]  do_one_initcall+0x56/0x2e0
[    6.703553]  ? rcu_read_lock_sched_held+0x3a/0x70
[    6.704335]  kernel_init_freeable+0x186/0x1ce
[    6.705057]  ? rest_init+0x250/0x250
[    6.705660]  kernel_init+0x11/0x110
[    6.706250]  ret_from_fork+0x22/0x30
[    6.706893] irq event stamp: 8204007
[    6.707520] hardirqs last  enabled at (8204015): [<ffffffff811acba3>] console_unlock+0x323/0x560
[    6.708967] hardirqs last disabled at (8204022): [<ffffffff811acc50>] console_unlock+0x3d0/0x560
[    6.710409] softirqs last  enabled at (8203694): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
[    6.711894] softirqs last disabled at (8203689): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
[    6.713302] ---[ end trace e99e0812b8ee9c5e ]---
[    6.719970] [drm] Initialized i915 1.6.0 20201103 for 0000:00:04.0 on minor 0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-21 11:10 [Intel-gfx] 5.14-rc2 warnings with kvmgvt Christoph Hellwig
@ 2021-07-21 11:24 ` Rodrigo Vivi
  2021-07-21 15:43   ` Christoph Hellwig
  2021-07-21 21:47 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 14+ messages in thread
From: Rodrigo Vivi @ 2021-07-21 11:24 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: intel-gfx, intel-gvt-dev

On Wed, Jul 21, 2021 at 01:10:49PM +0200, Christoph Hellwig wrote:
> Hi all,
> 
> I'm trying to test some changes for the gvt code, but even with a baseline
> 5.14-rc2 host and guest the 915 driver does not seem overly happy:

Is this a regression over -rc1 or over 5.13?
Bisect possible?

Could you please file a bug to our gitlab issues tracker:
https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs

Thanks,
Rodrigo.

> 
> [    5.693099] i915 0000:00:04.0: [drm] Virtual GPU for Intel GVT-g detected.
> [    5.694841] i915 0000:00:04.0: [drm] VT-d active for gfx access
> [    5.696411] i915 0000:00:04.0: [drm] iGVT-g active, disabling use of stolen memory
> [    5.711317] i915 0000:00:04.0: BAR 6: can't assign [??? 0x00000000 flags 0x20000000] (bogus alignm)
> [    5.712847] i915 0000:00:04.0: [drm] Failed to find VBIOS tables (VBT)
> [    5.714343] i915 0000:00:04.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=none:owns=iom
> [    5.716466] i915 0000:00:04.0: Direct firmware load for i915/kbl_dmc_ver1_04.bin failed with error2
> [    5.718021] i915 0000:00:04.0: [drm] Failed to load DMC firmware i915/kbl_dmc_ver1_04.bin. Disabli.
> [    5.719914] i915 0000:00:04.0: [drm] DMC firmware homepage: https://git.kernel.org/pub/scm/linux/k5
> [    5.733269] i915 0000:00:04.0: [drm] failed to retrieve link info, disabling eDP
> [    5.735841] i915 0000:00:04.0: [drm] *ERROR* crtc 51: Can't calculate constants, dotclock = 0!
> [    5.737354] ------------[ cut here ]------------
> [    5.738141] i915 0000:00:04.0: drm_WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev))
> [    5.738165] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/drm_vblank.c:728 drm_crtc_vblank_helper_get_0
> [    5.738745] Modules linked in:
> [    5.738745] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.14.0-rc2+ #22
> [    5.738745] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
> [    5.738745] RIP: 0010:drm_crtc_vblank_helper_get_vblank_timestamp_internal+0x335/0x350
> [    5.738745] Code: 4c 8b 6f 50 4d 85 ed 75 03 4c 8b 2f e8 34 10 26 00 48 c7 c1 20 54 0d 83 4c 89 ea0
> [    5.738745] RSP: 0000:ffffc90000013a90 EFLAGS: 00010086
> [    5.738745] RAX: 0000000000000000 RBX: ffffffff81c3c5b0 RCX: 0000000000000000
> [    5.738745] RDX: 0000000000000003 RSI: 00000000fffeffff RDI: 00000000ffffffff
> [    5.738745] RBP: ffffc90000013b00 R08: ffffffff83bb3e28 R09: 0000000000000003
> [    5.738745] R10: ffffffff834b3e40 R11: 3fffffffffffffff R12: 0000000000000000
> [    5.738745] R13: ffff888100e982f0 R14: ffff8881053f0340 R15: ffff888105592178
> [    5.738745] FS:  0000000000000000(0000) GS:ffff88813bc00000(0000) knlGS:0000000000000000
> [    5.738745] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [    5.738745] CR2: 0000000000000000 CR3: 0000000003462000 CR4: 00000000000006f0
> [    5.738745] Call Trace:
> [    5.738745]  drm_get_last_vbltimestamp+0xa5/0xb0
> [    5.738745]  drm_reset_vblank_timestamp+0x56/0xc0
> [    5.738745]  drm_crtc_vblank_on+0x81/0x140
> [    5.738745]  intel_crtc_vblank_on+0x2b/0xe0
> [    5.738745]  intel_modeset_setup_hw_state+0xa9c/0x1ab0
> [    5.738745]  ? ww_mutex_lock+0x2b/0x90
> [    5.738745]  intel_modeset_init_nogem+0x3c5/0x1310
> [    5.738745]  ? intel_irq_postinstall+0x1aa/0x520
> [    5.738745]  i915_driver_probe+0x695/0xd30
> [    5.738745]  ? _raw_spin_unlock_irqrestore+0x33/0x50
> [    5.738745]  pci_device_probe+0xcd/0x140
> [    5.738745]  really_probe.part.0+0x99/0x270
> [    5.738745]  __driver_probe_device+0x8b/0x120
> [    5.738745]  driver_probe_device+0x19/0x90
> [    5.738745]  __driver_attach+0x79/0x120
> [    5.738745]  ? __device_attach_driver+0x90/0x90
> [    5.738745]  bus_for_each_dev+0x78/0xc0
> [    5.738745]  bus_add_driver+0x109/0x1b0
> [    5.738745]  driver_register+0x86/0xd0
> [    5.738745]  ? ttm_init+0x18/0x18
> [    5.738745]  i915_init+0x58/0x72
> [    5.738745]  do_one_initcall+0x56/0x2e0
> [    5.738745]  ? rcu_read_lock_sched_held+0x3a/0x70
> [    5.738745]  kernel_init_freeable+0x186/0x1ce
> [    5.738745]  ? rest_init+0x250/0x250
> [    5.738745]  kernel_init+0x11/0x110
> [    5.738745]  ret_from_fork+0x22/0x30
> [    5.738745] irq event stamp: 8200428
> [    5.738745] hardirqs last  enabled at (8200427): [<ffffffff825d38e8>] _raw_spin_unlock_irqrestore+0
> [    5.738745] hardirqs last disabled at (8200428): [<ffffffff825d3671>] _raw_spin_lock_irq+0x41/0x50
> [    5.738745] softirqs last  enabled at (8199086): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
> [    5.738745] softirqs last disabled at (8199079): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
> [    5.738745] ---[ end trace e99e0812b8ee9c5d ]---
> [    5.786472] i915 0000:00:04.0: [drm] VGT ballooning configuration:
> [    5.787531] i915 0000:00:04.0: [drm] Mappable graphic memory: base 0x31c7000 size 65536KiB
> [    5.788865] i915 0000:00:04.0: [drm] Unmappable graphic memory: base 0xe7ef8000 size 393216KiB
> [    5.790270] i915 0000:00:04.0: [drm] balloon space: range [ 0x10000000 - 0xe7ef8000 ] 3537888 KiB.
> [    5.791807] i915 0000:00:04.0: [drm] balloon space: range [ 0xffef8000 - 0x100000000 ] 1056 KiB.
> [    5.793241] i915 0000:00:04.0: [drm] balloon space: range [ 0x0 - 0x31c7000 ] 50972 KiB.
> [    5.794565] i915 0000:00:04.0: [drm] balloon space: range [ 0x71c7000 - 0x10000000 ] 145636 KiB.
> [    5.796028] i915 0000:00:04.0: [drm] VGT balloon successfully
> [    6.670284] ------------[ cut here ]------------
> [    6.671155] crtc active state doesn't match with hw state (expected 0, found 1)
> [    6.672376] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/i915/display/intel_display.c:8964 intel_atom0
> [    6.674232] Modules linked in:
> [    6.674767] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G        W         5.14.0-rc2+ #22
> [    6.676039] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
> [    6.677402] RIP: 0010:intel_atomic_commit_tail+0x13c9/0x1410
> [    6.678335] Code: 0f 0b 0f b6 34 24 89 f1 e9 8d fc ff ff e8 7f 19 7f 00 0f 0b e9 30 fd ff ff e8 739
> [    6.681400] RSP: 0000:ffffc90000013b20 EFLAGS: 00010282
> [    6.682264] RAX: 0000000000000000 RBX: ffff888105593800 RCX: 0000000000000000
> [    6.683453] RDX: 0000000000000001 RSI: ffffffff831a6e3f RDI: 00000000ffffffff
> [    6.684623] RBP: ffff888104ab2000 R08: 0000000000000001 R09: 0000000000000001
> [    6.685782] R10: 00000000ffff0000 R11: 3fffffffffffffff R12: ffff888104baa000
> [    6.686972] R13: ffff888104e5a000 R14: ffff8881053f0000 R15: ffff8881053f0000
> [    6.688147] FS:  0000000000000000(0000) GS:ffff88813bc00000(0000) knlGS:0000000000000000
> [    6.689475] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [    6.690421] CR2: 0000000000000000 CR3: 0000000003462000 CR4: 00000000000006f0
> [    6.691611] Call Trace:
> [    6.692038]  intel_atomic_commit+0x32d/0x3b0
> [    6.692751]  intel_initial_commit+0x156/0x1e0
> [    6.693488]  intel_modeset_init+0x19/0x80
> [    6.694156]  i915_driver_probe+0x6bb/0xd30
> [    6.694860]  ? _raw_spin_unlock_irqrestore+0x33/0x50
> [    6.695690]  pci_device_probe+0xcd/0x140
> [    6.696346]  really_probe.part.0+0x99/0x270
> [    6.697041]  __driver_probe_device+0x8b/0x120
> [    6.697767]  driver_probe_device+0x19/0x90
> [    6.698459]  __driver_attach+0x79/0x120
> [    6.699120]  ? __device_attach_driver+0x90/0x90
> [    6.699878]  bus_for_each_dev+0x78/0xc0
> [    6.700522]  bus_add_driver+0x109/0x1b0
> [    6.701163]  driver_register+0x86/0xd0
> [    6.701786]  ? ttm_init+0x18/0x18
> [    6.702342]  i915_init+0x58/0x72
> [    6.702906]  do_one_initcall+0x56/0x2e0
> [    6.703553]  ? rcu_read_lock_sched_held+0x3a/0x70
> [    6.704335]  kernel_init_freeable+0x186/0x1ce
> [    6.705057]  ? rest_init+0x250/0x250
> [    6.705660]  kernel_init+0x11/0x110
> [    6.706250]  ret_from_fork+0x22/0x30
> [    6.706893] irq event stamp: 8204007
> [    6.707520] hardirqs last  enabled at (8204015): [<ffffffff811acba3>] console_unlock+0x323/0x560
> [    6.708967] hardirqs last disabled at (8204022): [<ffffffff811acc50>] console_unlock+0x3d0/0x560
> [    6.710409] softirqs last  enabled at (8203694): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
> [    6.711894] softirqs last disabled at (8203689): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
> [    6.713302] ---[ end trace e99e0812b8ee9c5e ]---
> [    6.719970] [drm] Initialized i915 1.6.0 20201103 for 0000:00:04.0 on minor 0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-21 11:24 ` Rodrigo Vivi
@ 2021-07-21 15:43   ` Christoph Hellwig
  2021-07-21 20:40     ` Christoph Hellwig
  0 siblings, 1 reply; 14+ messages in thread
From: Christoph Hellwig @ 2021-07-21 15:43 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: Christoph Hellwig, intel-gfx, intel-gvt-dev

On Wed, Jul 21, 2021 at 07:24:47AM -0400, Rodrigo Vivi wrote:
> On Wed, Jul 21, 2021 at 01:10:49PM +0200, Christoph Hellwig wrote:
> > Hi all,
> > 
> > I'm trying to test some changes for the gvt code, but even with a baseline
> > 5.14-rc2 host and guest the 915 driver does not seem overly happy:
> 
> Is this a regression over -rc1 or over 5.13?
> Bisect possible?

This was introduced somewhere between 5.12 and 5.13, still bisecting.
Note that it only happens for "headless" setups.  Once a display is
added on the qemu command line it goes away.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-21 15:43   ` Christoph Hellwig
@ 2021-07-21 20:40     ` Christoph Hellwig
  2021-07-21 21:18       ` Rodrigo Vivi
  0 siblings, 1 reply; 14+ messages in thread
From: Christoph Hellwig @ 2021-07-21 20:40 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: Christoph Hellwig, intel-gfx, intel-gvt-dev

On Wed, Jul 21, 2021 at 04:43:44PM +0100, Christoph Hellwig wrote:
> > > I'm trying to test some changes for the gvt code, but even with a baseline
> > > 5.14-rc2 host and guest the 915 driver does not seem overly happy:
> > 
> > Is this a regression over -rc1 or over 5.13?
> > Bisect possible?
> 
> This was introduced somewhere between 5.12 and 5.13, still bisecting.
> Note that it only happens for "headless" setups.  Once a display is
> added on the qemu command line it goes away.

The culprit is:

commit f4eb6d4906669b4285c4f49c87814d4ce63c35bb
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Wed Mar 17 18:36:45 2021 +0200

    drm/i915/bios: limit default outputs to ports A through F
        
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-21 20:40     ` Christoph Hellwig
@ 2021-07-21 21:18       ` Rodrigo Vivi
  2021-07-22  4:24         ` Christoph Hellwig
  0 siblings, 1 reply; 14+ messages in thread
From: Rodrigo Vivi @ 2021-07-21 21:18 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: intel-gfx, intel-gvt-dev

On Wed, Jul 21, 2021 at 09:40:03PM +0100, Christoph Hellwig wrote:
> On Wed, Jul 21, 2021 at 04:43:44PM +0100, Christoph Hellwig wrote:
> > > > I'm trying to test some changes for the gvt code, but even with a baseline
> > > > 5.14-rc2 host and guest the 915 driver does not seem overly happy:
> > > 
> > > Is this a regression over -rc1 or over 5.13?
> > > Bisect possible?
> > 
> > This was introduced somewhere between 5.12 and 5.13, still bisecting.
> > Note that it only happens for "headless" setups.  Once a display is
> > added on the qemu command line it goes away.
> 
> The culprit is:
> 
> commit f4eb6d4906669b4285c4f49c87814d4ce63c35bb
> Author: Jani Nikula <jani.nikula@intel.com>
> Date:   Wed Mar 17 18:36:45 2021 +0200
> 
>     drm/i915/bios: limit default outputs to ports A through F
>         

could you please try this small patch?

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 5b6922e28ef2..8bbeb5978bf7 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2166,7 +2166,8 @@ static void
 init_vbt_missing_defaults(struct drm_i915_private *i915)
 {
        enum port port;
-       int ports = PORT_A | PORT_B | PORT_C | PORT_D | PORT_E | PORT_F;
+       int ports = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | \
+                   BIT(PORT_D) | BIT(PORT_E) | BIT(PORT_F);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Intel-gfx] ✗ Fi.CI.BUILD: failure for 5.14-rc2 warnings with kvmgvt
  2021-07-21 11:10 [Intel-gfx] 5.14-rc2 warnings with kvmgvt Christoph Hellwig
  2021-07-21 11:24 ` Rodrigo Vivi
@ 2021-07-21 21:47 ` Patchwork
  2021-07-22  5:05 ` [Intel-gfx] " Zhenyu Wang
  2021-07-22  6:34 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for 5.14-rc2 warnings with kvmgvt (rev2) Patchwork
  3 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2021-07-21 21:47 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: 5.14-rc2 warnings with kvmgvt
URL   : https://patchwork.freedesktop.org/series/92845/
State : failure

== Summary ==

Applying: 5.14-rc2 warnings with kvmgvt
error: corrupt patch at line 12
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 5.14-rc2 warnings with kvmgvt
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-21 21:18       ` Rodrigo Vivi
@ 2021-07-22  4:24         ` Christoph Hellwig
  2021-07-22  5:55           ` Lucas De Marchi
  0 siblings, 1 reply; 14+ messages in thread
From: Christoph Hellwig @ 2021-07-22  4:24 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: Christoph Hellwig, intel-gfx, intel-gvt-dev

On Wed, Jul 21, 2021 at 05:18:18PM -0400, Rodrigo Vivi wrote:
> could you please try this small patch?

I had to hand apply it as it wa corruped to due to cut off context.

It fixes one of the warnings, new output below:

[    4.182820] i915 0000:00:04.0: [drm] Virtual GPU for Intel GVT-g detected.
[    4.184076] i915 0000:00:04.0: [drm] VT-d active for gfx access
[    4.185199] i915 0000:00:04.0: [drm] iGVT-g active, disabling use of stolen memory
[    4.207889] i915 0000:00:04.0: BAR 6: can't assign [??? 0x00000000 flags 0x20000000] (bogus a)
[    4.210062] i915 0000:00:04.0: [drm] Failed to find VBIOS tables (VBT)
[    4.212256] i915 0000:00:04.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=none:owm
[    4.214447] i915 0000:00:04.0: Direct firmware load for i915/kbl_dmc_ver1_04.bin failed with 2
[    4.215447] i915 0000:00:04.0: [drm] Failed to load DMC firmware i915/kbl_dmc_ver1_04.bin. Di.
[    4.216643] i915 0000:00:04.0: [drm] DMC firmware homepage: https://git.kernel.org/pub/scm/li5
[    4.227760] i915 0000:00:04.0: [drm] failed to retrieve link info, disabling eDP
[    4.229706] ------------[ cut here ]------------
[    4.230204] Missing case (port == 5)
[    4.230652] WARNING: CPU: 3 PID: 1 at drivers/gpu/drm/i915/display/intel_hdmi.c:2740 intel_hd0
[    4.231815] Modules linked in:
[    4.232146] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 5.14.0-rc2+ #40
[    4.232826] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
[    4.233706] RIP: 0010:intel_hdmi_init_connector+0x7cf/0x880
[    4.234330] Code: b6 fb 45 89 fb e9 bd fb ff ff 49 63 d7 48 c7 c6 da 67 18 83 44 89 44 24 10 4
[    4.236289] RSP: 0000:ffffc90000013be8 EFLAGS: 00010282
[    4.236949] RAX: 0000000000000000 RBX: ffff888104cda000 RCX: 0000000000000000
[    4.237703] RDX: 0000000000000001 RSI: ffffffff831a7617 RDI: 00000000ffffffff
[    4.238499] RBP: ffff888104c01000 R08: 0000000000000001 R09: 0000000000000001
[    4.239240] R10: 00000000ffff0000 R11: 3fffffffffffffff R12: ffff8881054c0000
[    4.240112] R13: 0000000000000005 R14: ffff8881054c0000 R15: 0000000000000005
[    4.240963] FS:  0000000000000000(0000) GS:ffff88813bd80000(0000) knlGS:0000000000000000
[    4.241856] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    4.242533] CR2: 0000000000000000 CR3: 0000000003462000 CR4: 00000000000006e0
[    4.243437] Call Trace:
[    4.243754]  intel_ddi_init+0x88d/0xc30
[    4.244216]  intel_modeset_init_nogem+0xdab/0x1310
[    4.244792]  ? intel_irq_postinstall+0x1aa/0x520
[    4.245372]  i915_driver_probe+0x695/0xd30
[    4.245908]  ? _raw_spin_unlock_irqrestore+0x33/0x50
[    4.246507]  pci_device_probe+0xcd/0x140
[    4.246933]  really_probe.part.0+0x99/0x270
[    4.247421]  __driver_probe_device+0x8b/0x120
[    4.247887]  driver_probe_device+0x19/0x90
[    4.248328]  __driver_attach+0x79/0x120
[    4.248740]  ? __device_attach_driver+0x90/0x90
[    4.249225]  bus_for_each_dev+0x78/0xc0
[    4.249637]  bus_add_driver+0x109/0x1b0
[    4.250051]  driver_register+0x86/0xd0
[    4.250512]  ? ttm_init+0x18/0x18
[    4.250884]  i915_init+0x58/0x72
[    4.251234]  do_one_initcall+0x56/0x2e0
[    4.251644]  ? rcu_read_lock_sched_held+0x3a/0x70
[    4.252150]  kernel_init_freeable+0x186/0x1ce
[    4.252625]  ? rest_init+0x250/0x250
[    4.253032]  kernel_init+0x11/0x110
[    4.253464]  ret_from_fork+0x22/0x30
[    4.253864] irq event stamp: 8201065
[    4.254308] hardirqs last  enabled at (8201075): [<ffffffff811acba3>] console_unlock+0x323/0x0
[    4.255377] hardirqs last disabled at (8201082): [<ffffffff811acc50>] console_unlock+0x3d0/0x0
[    4.256325] softirqs last  enabled at (8200736): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
[    4.257234] softirqs last disabled at (8200695): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
[    4.258142] ---[ end trace 2e5275f4e68f236b ]---
[    4.259727] i915 0000:00:04.0: [drm] [ENCODER:94:DDI B/PHY B] is disabled/in DSI mode with ant
[    4.260917] i915 0000:00:04.0: [drm] [ENCODER:110:DDI C/PHY C] is disabled/in DSI mode with at
[    4.262086] i915 0000:00:04.0: [drm] [ENCODER:130:DDI F/PHY F] is disabled/in DSI mode with at
[    4.263764] i915 0000:00:04.0: [drm] VGT ballooning configuration:
[    4.264418] i915 0000:00:04.0: [drm] Mappable graphic memory: base 0x2180000 size 65536KiB
[    4.265284] i915 0000:00:04.0: [drm] Unmappable graphic memory: base 0x10000000 size 393216KiB
[    4.266188] i915 0000:00:04.0: [drm] balloon space: range [ 0x28000000 - 0x100000000 ] 353894.
[    4.267159] i915 0000:00:04.0: [drm] balloon space: range [ 0x0 - 0x2180000
] 34304 KiB.
[    4.268025] i915 0000:00:04.0: [drm] balloon space: range [ 0x6180000 - 0x10000000 ] 162304 K.
[    4.268968] i915 0000:00:04.0: [drm] VGT balloon successfully
[    4.888116] i915 0000:00:04.0: [drm] *ERROR* Failed to disable SAGV (-110)
[    4.908031] [drm] Initialized i915 1.6.0 20201103 for 0000:00:04.0 on minor
0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-21 11:10 [Intel-gfx] 5.14-rc2 warnings with kvmgvt Christoph Hellwig
  2021-07-21 11:24 ` Rodrigo Vivi
  2021-07-21 21:47 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
@ 2021-07-22  5:05 ` Zhenyu Wang
  2021-07-22  5:52   ` Christoph Hellwig
  2021-07-22  6:34 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for 5.14-rc2 warnings with kvmgvt (rev2) Patchwork
  3 siblings, 1 reply; 14+ messages in thread
From: Zhenyu Wang @ 2021-07-22  5:05 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: intel-gfx, intel-gvt-dev


[-- Attachment #1.1: Type: text/plain, Size: 8614 bytes --]

On 2021.07.21 13:10:49 +0200, Christoph Hellwig wrote:
> Hi all,
> 
> I'm trying to test some changes for the gvt code, but even with a baseline
> 5.14-rc2 host and guest the 915 driver does not seem overly happy:
>

I think we also got bug report on those display related warnings, should be
some issue with our virtual display model that doesn't work nicely with more i915
display pipe/port check or exercises have been added...But I believe you should
still get virtual framebuffer up and show, right?

> [    5.693099] i915 0000:00:04.0: [drm] Virtual GPU for Intel GVT-g detected.
> [    5.694841] i915 0000:00:04.0: [drm] VT-d active for gfx access
> [    5.696411] i915 0000:00:04.0: [drm] iGVT-g active, disabling use of stolen memory
> [    5.711317] i915 0000:00:04.0: BAR 6: can't assign [??? 0x00000000 flags 0x20000000] (bogus alignm)
> [    5.712847] i915 0000:00:04.0: [drm] Failed to find VBIOS tables (VBT)
> [    5.714343] i915 0000:00:04.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=none:owns=iom
> [    5.716466] i915 0000:00:04.0: Direct firmware load for i915/kbl_dmc_ver1_04.bin failed with error2
> [    5.718021] i915 0000:00:04.0: [drm] Failed to load DMC firmware i915/kbl_dmc_ver1_04.bin. Disabli.
> [    5.719914] i915 0000:00:04.0: [drm] DMC firmware homepage: https://git.kernel.org/pub/scm/linux/k5
> [    5.733269] i915 0000:00:04.0: [drm] failed to retrieve link info, disabling eDP
> [    5.735841] i915 0000:00:04.0: [drm] *ERROR* crtc 51: Can't calculate constants, dotclock = 0!
> [    5.737354] ------------[ cut here ]------------
> [    5.738141] i915 0000:00:04.0: drm_WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev))
> [    5.738165] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/drm_vblank.c:728 drm_crtc_vblank_helper_get_0
> [    5.738745] Modules linked in:
> [    5.738745] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.14.0-rc2+ #22
> [    5.738745] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
> [    5.738745] RIP: 0010:drm_crtc_vblank_helper_get_vblank_timestamp_internal+0x335/0x350
> [    5.738745] Code: 4c 8b 6f 50 4d 85 ed 75 03 4c 8b 2f e8 34 10 26 00 48 c7 c1 20 54 0d 83 4c 89 ea0
> [    5.738745] RSP: 0000:ffffc90000013a90 EFLAGS: 00010086
> [    5.738745] RAX: 0000000000000000 RBX: ffffffff81c3c5b0 RCX: 0000000000000000
> [    5.738745] RDX: 0000000000000003 RSI: 00000000fffeffff RDI: 00000000ffffffff
> [    5.738745] RBP: ffffc90000013b00 R08: ffffffff83bb3e28 R09: 0000000000000003
> [    5.738745] R10: ffffffff834b3e40 R11: 3fffffffffffffff R12: 0000000000000000
> [    5.738745] R13: ffff888100e982f0 R14: ffff8881053f0340 R15: ffff888105592178
> [    5.738745] FS:  0000000000000000(0000) GS:ffff88813bc00000(0000) knlGS:0000000000000000
> [    5.738745] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [    5.738745] CR2: 0000000000000000 CR3: 0000000003462000 CR4: 00000000000006f0
> [    5.738745] Call Trace:
> [    5.738745]  drm_get_last_vbltimestamp+0xa5/0xb0
> [    5.738745]  drm_reset_vblank_timestamp+0x56/0xc0
> [    5.738745]  drm_crtc_vblank_on+0x81/0x140
> [    5.738745]  intel_crtc_vblank_on+0x2b/0xe0
> [    5.738745]  intel_modeset_setup_hw_state+0xa9c/0x1ab0
> [    5.738745]  ? ww_mutex_lock+0x2b/0x90
> [    5.738745]  intel_modeset_init_nogem+0x3c5/0x1310
> [    5.738745]  ? intel_irq_postinstall+0x1aa/0x520
> [    5.738745]  i915_driver_probe+0x695/0xd30
> [    5.738745]  ? _raw_spin_unlock_irqrestore+0x33/0x50
> [    5.738745]  pci_device_probe+0xcd/0x140
> [    5.738745]  really_probe.part.0+0x99/0x270
> [    5.738745]  __driver_probe_device+0x8b/0x120
> [    5.738745]  driver_probe_device+0x19/0x90
> [    5.738745]  __driver_attach+0x79/0x120
> [    5.738745]  ? __device_attach_driver+0x90/0x90
> [    5.738745]  bus_for_each_dev+0x78/0xc0
> [    5.738745]  bus_add_driver+0x109/0x1b0
> [    5.738745]  driver_register+0x86/0xd0
> [    5.738745]  ? ttm_init+0x18/0x18
> [    5.738745]  i915_init+0x58/0x72
> [    5.738745]  do_one_initcall+0x56/0x2e0
> [    5.738745]  ? rcu_read_lock_sched_held+0x3a/0x70
> [    5.738745]  kernel_init_freeable+0x186/0x1ce
> [    5.738745]  ? rest_init+0x250/0x250
> [    5.738745]  kernel_init+0x11/0x110
> [    5.738745]  ret_from_fork+0x22/0x30
> [    5.738745] irq event stamp: 8200428
> [    5.738745] hardirqs last  enabled at (8200427): [<ffffffff825d38e8>] _raw_spin_unlock_irqrestore+0
> [    5.738745] hardirqs last disabled at (8200428): [<ffffffff825d3671>] _raw_spin_lock_irq+0x41/0x50
> [    5.738745] softirqs last  enabled at (8199086): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
> [    5.738745] softirqs last disabled at (8199079): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
> [    5.738745] ---[ end trace e99e0812b8ee9c5d ]---
> [    5.786472] i915 0000:00:04.0: [drm] VGT ballooning configuration:
> [    5.787531] i915 0000:00:04.0: [drm] Mappable graphic memory: base 0x31c7000 size 65536KiB
> [    5.788865] i915 0000:00:04.0: [drm] Unmappable graphic memory: base 0xe7ef8000 size 393216KiB
> [    5.790270] i915 0000:00:04.0: [drm] balloon space: range [ 0x10000000 - 0xe7ef8000 ] 3537888 KiB.
> [    5.791807] i915 0000:00:04.0: [drm] balloon space: range [ 0xffef8000 - 0x100000000 ] 1056 KiB.
> [    5.793241] i915 0000:00:04.0: [drm] balloon space: range [ 0x0 - 0x31c7000 ] 50972 KiB.
> [    5.794565] i915 0000:00:04.0: [drm] balloon space: range [ 0x71c7000 - 0x10000000 ] 145636 KiB.
> [    5.796028] i915 0000:00:04.0: [drm] VGT balloon successfully
> [    6.670284] ------------[ cut here ]------------
> [    6.671155] crtc active state doesn't match with hw state (expected 0, found 1)
> [    6.672376] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/i915/display/intel_display.c:8964 intel_atom0
> [    6.674232] Modules linked in:
> [    6.674767] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G        W         5.14.0-rc2+ #22
> [    6.676039] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
> [    6.677402] RIP: 0010:intel_atomic_commit_tail+0x13c9/0x1410
> [    6.678335] Code: 0f 0b 0f b6 34 24 89 f1 e9 8d fc ff ff e8 7f 19 7f 00 0f 0b e9 30 fd ff ff e8 739
> [    6.681400] RSP: 0000:ffffc90000013b20 EFLAGS: 00010282
> [    6.682264] RAX: 0000000000000000 RBX: ffff888105593800 RCX: 0000000000000000
> [    6.683453] RDX: 0000000000000001 RSI: ffffffff831a6e3f RDI: 00000000ffffffff
> [    6.684623] RBP: ffff888104ab2000 R08: 0000000000000001 R09: 0000000000000001
> [    6.685782] R10: 00000000ffff0000 R11: 3fffffffffffffff R12: ffff888104baa000
> [    6.686972] R13: ffff888104e5a000 R14: ffff8881053f0000 R15: ffff8881053f0000
> [    6.688147] FS:  0000000000000000(0000) GS:ffff88813bc00000(0000) knlGS:0000000000000000
> [    6.689475] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [    6.690421] CR2: 0000000000000000 CR3: 0000000003462000 CR4: 00000000000006f0
> [    6.691611] Call Trace:
> [    6.692038]  intel_atomic_commit+0x32d/0x3b0
> [    6.692751]  intel_initial_commit+0x156/0x1e0
> [    6.693488]  intel_modeset_init+0x19/0x80
> [    6.694156]  i915_driver_probe+0x6bb/0xd30
> [    6.694860]  ? _raw_spin_unlock_irqrestore+0x33/0x50
> [    6.695690]  pci_device_probe+0xcd/0x140
> [    6.696346]  really_probe.part.0+0x99/0x270
> [    6.697041]  __driver_probe_device+0x8b/0x120
> [    6.697767]  driver_probe_device+0x19/0x90
> [    6.698459]  __driver_attach+0x79/0x120
> [    6.699120]  ? __device_attach_driver+0x90/0x90
> [    6.699878]  bus_for_each_dev+0x78/0xc0
> [    6.700522]  bus_add_driver+0x109/0x1b0
> [    6.701163]  driver_register+0x86/0xd0
> [    6.701786]  ? ttm_init+0x18/0x18
> [    6.702342]  i915_init+0x58/0x72
> [    6.702906]  do_one_initcall+0x56/0x2e0
> [    6.703553]  ? rcu_read_lock_sched_held+0x3a/0x70
> [    6.704335]  kernel_init_freeable+0x186/0x1ce
> [    6.705057]  ? rest_init+0x250/0x250
> [    6.705660]  kernel_init+0x11/0x110
> [    6.706250]  ret_from_fork+0x22/0x30
> [    6.706893] irq event stamp: 8204007
> [    6.707520] hardirqs last  enabled at (8204015): [<ffffffff811acba3>] console_unlock+0x323/0x560
> [    6.708967] hardirqs last disabled at (8204022): [<ffffffff811acc50>] console_unlock+0x3d0/0x560
> [    6.710409] softirqs last  enabled at (8203694): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
> [    6.711894] softirqs last disabled at (8203689): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
> [    6.713302] ---[ end trace e99e0812b8ee9c5e ]---
> [    6.719970] [drm] Initialized i915 1.6.0 20201103 for 0000:00:04.0 on minor 0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-22  5:05 ` [Intel-gfx] " Zhenyu Wang
@ 2021-07-22  5:52   ` Christoph Hellwig
  0 siblings, 0 replies; 14+ messages in thread
From: Christoph Hellwig @ 2021-07-22  5:52 UTC (permalink / raw)
  To: Zhenyu Wang; +Cc: intel-gfx, Christoph Hellwig, intel-gvt-dev

On Thu, Jul 22, 2021 at 01:05:49PM +0800, Zhenyu Wang wrote:
> On 2021.07.21 13:10:49 +0200, Christoph Hellwig wrote:
> > Hi all,
> > 
> > I'm trying to test some changes for the gvt code, but even with a baseline
> > 5.14-rc2 host and guest the 915 driver does not seem overly happy:
> >
> 
> I think we also got bug report on those display related warnings, should be
> some issue with our virtual display model that doesn't work nicely with more i915
> display pipe/port check or exercises have been added...But I believe you should
> still get virtual framebuffer up and show, right?

Well, as soon as I add a display the warnings disappear anyway.  Not
sure how to test if the framebuffers gets up without the display.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-22  4:24         ` Christoph Hellwig
@ 2021-07-22  5:55           ` Lucas De Marchi
  2021-07-22  7:20             ` Christoph Hellwig
  0 siblings, 1 reply; 14+ messages in thread
From: Lucas De Marchi @ 2021-07-22  5:55 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: intel-gfx, intel-gvt-dev

On Thu, Jul 22, 2021 at 05:24:30AM +0100, Christoph Hellwig wrote:
>On Wed, Jul 21, 2021 at 05:18:18PM -0400, Rodrigo Vivi wrote:
>> could you please try this small patch?
>
>I had to hand apply it as it wa corruped to due to cut off context.
>
>It fixes one of the warnings, new output below:
>
>[    4.182820] i915 0000:00:04.0: [drm] Virtual GPU for Intel GVT-g detected.
>[    4.184076] i915 0000:00:04.0: [drm] VT-d active for gfx access
>[    4.185199] i915 0000:00:04.0: [drm] iGVT-g active, disabling use of stolen memory
>[    4.207889] i915 0000:00:04.0: BAR 6: can't assign [??? 0x00000000 flags 0x20000000] (bogus a)
>[    4.210062] i915 0000:00:04.0: [drm] Failed to find VBIOS tables (VBT)
>[    4.212256] i915 0000:00:04.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=none:owm
>[    4.214447] i915 0000:00:04.0: Direct firmware load for i915/kbl_dmc_ver1_04.bin failed with 2
>[    4.215447] i915 0000:00:04.0: [drm] Failed to load DMC firmware i915/kbl_dmc_ver1_04.bin. Di.
>[    4.216643] i915 0000:00:04.0: [drm] DMC firmware homepage: https://git.kernel.org/pub/scm/li5
>[    4.227760] i915 0000:00:04.0: [drm] failed to retrieve link info, disabling eDP
>[    4.229706] ------------[ cut here ]------------
>[    4.230204] Missing case (port == 5)

humn... PORT_F. KBL doesn't have PORT_F. We decided to keep the handling
of DISPLAY_VER == 10 and DISPLAY_VER == 9 together and trust the VBT,
but when the VBT is not present, DDI F will get added unconditio.

maybe best thing to do is to split that

-------8<-------------
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index c274bfb8e549..44cad63e20fb 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -11371,6 +11371,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
  		intel_ddi_init(dev_priv, PORT_E);
  		intel_ddi_init(dev_priv, PORT_F);
  		icl_dsi_init(dev_priv);
+	} else if (DISPLAY_VER(dev_priv) == 10) {
+		intel_ddi_init(dev_priv, PORT_A);
+		intel_ddi_init(dev_priv, PORT_B);
+		intel_ddi_init(dev_priv, PORT_C);
+		intel_ddi_init(dev_priv, PORT_D);
+		intel_ddi_init(dev_priv, PORT_E);
+		intel_ddi_init(dev_priv, PORT_F);
  	} else if (IS_GEMINILAKE(dev_priv) || IS_BROXTON(dev_priv)) {
  		intel_ddi_init(dev_priv, PORT_A);
  		intel_ddi_init(dev_priv, PORT_B);
@@ -11382,7 +11389,6 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
  		intel_ddi_init(dev_priv, PORT_C);
  		intel_ddi_init(dev_priv, PORT_D);
  		intel_ddi_init(dev_priv, PORT_E);
-		intel_ddi_init(dev_priv, PORT_F);
  	} else if (HAS_DDI(dev_priv)) {
  		u32 found;
  
-------8<-------------

thanks
Lucas De Marchi

>[    4.230652] WARNING: CPU: 3 PID: 1 at drivers/gpu/drm/i915/display/intel_hdmi.c:2740 intel_hd0
>[    4.231815] Modules linked in:
>[    4.232146] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 5.14.0-rc2+ #40
>[    4.232826] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
>[    4.233706] RIP: 0010:intel_hdmi_init_connector+0x7cf/0x880
>[    4.234330] Code: b6 fb 45 89 fb e9 bd fb ff ff 49 63 d7 48 c7 c6 da 67 18 83 44 89 44 24 10 4
>[    4.236289] RSP: 0000:ffffc90000013be8 EFLAGS: 00010282
>[    4.236949] RAX: 0000000000000000 RBX: ffff888104cda000 RCX: 0000000000000000
>[    4.237703] RDX: 0000000000000001 RSI: ffffffff831a7617 RDI: 00000000ffffffff
>[    4.238499] RBP: ffff888104c01000 R08: 0000000000000001 R09: 0000000000000001
>[    4.239240] R10: 00000000ffff0000 R11: 3fffffffffffffff R12: ffff8881054c0000
>[    4.240112] R13: 0000000000000005 R14: ffff8881054c0000 R15: 0000000000000005
>[    4.240963] FS:  0000000000000000(0000) GS:ffff88813bd80000(0000) knlGS:0000000000000000
>[    4.241856] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>[    4.242533] CR2: 0000000000000000 CR3: 0000000003462000 CR4: 00000000000006e0
>[    4.243437] Call Trace:
>[    4.243754]  intel_ddi_init+0x88d/0xc30
>[    4.244216]  intel_modeset_init_nogem+0xdab/0x1310
>[    4.244792]  ? intel_irq_postinstall+0x1aa/0x520
>[    4.245372]  i915_driver_probe+0x695/0xd30
>[    4.245908]  ? _raw_spin_unlock_irqrestore+0x33/0x50
>[    4.246507]  pci_device_probe+0xcd/0x140
>[    4.246933]  really_probe.part.0+0x99/0x270
>[    4.247421]  __driver_probe_device+0x8b/0x120
>[    4.247887]  driver_probe_device+0x19/0x90
>[    4.248328]  __driver_attach+0x79/0x120
>[    4.248740]  ? __device_attach_driver+0x90/0x90
>[    4.249225]  bus_for_each_dev+0x78/0xc0
>[    4.249637]  bus_add_driver+0x109/0x1b0
>[    4.250051]  driver_register+0x86/0xd0
>[    4.250512]  ? ttm_init+0x18/0x18
>[    4.250884]  i915_init+0x58/0x72
>[    4.251234]  do_one_initcall+0x56/0x2e0
>[    4.251644]  ? rcu_read_lock_sched_held+0x3a/0x70
>[    4.252150]  kernel_init_freeable+0x186/0x1ce
>[    4.252625]  ? rest_init+0x250/0x250
>[    4.253032]  kernel_init+0x11/0x110
>[    4.253464]  ret_from_fork+0x22/0x30
>[    4.253864] irq event stamp: 8201065
>[    4.254308] hardirqs last  enabled at (8201075): [<ffffffff811acba3>] console_unlock+0x323/0x0
>[    4.255377] hardirqs last disabled at (8201082): [<ffffffff811acc50>] console_unlock+0x3d0/0x0
>[    4.256325] softirqs last  enabled at (8200736): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
>[    4.257234] softirqs last disabled at (8200695): [<ffffffff8113f3c8>] irq_exit_rcu+0x108/0x140
>[    4.258142] ---[ end trace 2e5275f4e68f236b ]---
>[    4.259727] i915 0000:00:04.0: [drm] [ENCODER:94:DDI B/PHY B] is disabled/in DSI mode with ant
>[    4.260917] i915 0000:00:04.0: [drm] [ENCODER:110:DDI C/PHY C] is disabled/in DSI mode with at
>[    4.262086] i915 0000:00:04.0: [drm] [ENCODER:130:DDI F/PHY F] is disabled/in DSI mode with at
>[    4.263764] i915 0000:00:04.0: [drm] VGT ballooning configuration:
>[    4.264418] i915 0000:00:04.0: [drm] Mappable graphic memory: base 0x2180000 size 65536KiB
>[    4.265284] i915 0000:00:04.0: [drm] Unmappable graphic memory: base 0x10000000 size 393216KiB
>[    4.266188] i915 0000:00:04.0: [drm] balloon space: range [ 0x28000000 - 0x100000000 ] 353894.
>[    4.267159] i915 0000:00:04.0: [drm] balloon space: range [ 0x0 - 0x2180000
>] 34304 KiB.
>[    4.268025] i915 0000:00:04.0: [drm] balloon space: range [ 0x6180000 - 0x10000000 ] 162304 K.
>[    4.268968] i915 0000:00:04.0: [drm] VGT balloon successfully
>[    4.888116] i915 0000:00:04.0: [drm] *ERROR* Failed to disable SAGV (-110)
>[    4.908031] [drm] Initialized i915 1.6.0 20201103 for 0000:00:04.0 on minor
>0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Intel-gfx] ✗ Fi.CI.BUILD: failure for 5.14-rc2 warnings with kvmgvt (rev2)
  2021-07-21 11:10 [Intel-gfx] 5.14-rc2 warnings with kvmgvt Christoph Hellwig
                   ` (2 preceding siblings ...)
  2021-07-22  5:05 ` [Intel-gfx] " Zhenyu Wang
@ 2021-07-22  6:34 ` Patchwork
  3 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2021-07-22  6:34 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: 5.14-rc2 warnings with kvmgvt (rev2)
URL   : https://patchwork.freedesktop.org/series/92845/
State : failure

== Summary ==

Applying: 5.14-rc2 warnings with kvmgvt
error: patch failed: drivers/gpu/drm/i915/display/intel_display.c:11371
error: drivers/gpu/drm/i915/display/intel_display.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
Patch failed at 0001 5.14-rc2 warnings with kvmgvt
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-22  5:55           ` Lucas De Marchi
@ 2021-07-22  7:20             ` Christoph Hellwig
  2021-07-22 16:03               ` Lucas De Marchi
  0 siblings, 1 reply; 14+ messages in thread
From: Christoph Hellwig @ 2021-07-22  7:20 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: Christoph Hellwig, intel-gfx, intel-gvt-dev

On Thu, Jul 22, 2021 at 01:55:23AM -0400, Lucas De Marchi wrote:
> humn... PORT_F. KBL doesn't have PORT_F. We decided to keep the handling
> of DISPLAY_VER == 10 and DISPLAY_VER == 9 together and trust the VBT,
> but when the VBT is not present, DDI F will get added unconditio.
> 
> maybe best thing to do is to split that

With this and the previous patch the stack traces are gone.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-22  7:20             ` Christoph Hellwig
@ 2021-07-22 16:03               ` Lucas De Marchi
  2021-07-22 16:08                 ` Christoph Hellwig
  0 siblings, 1 reply; 14+ messages in thread
From: Lucas De Marchi @ 2021-07-22 16:03 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: intel-gfx, intel-gvt-dev

On Thu, Jul 22, 2021 at 08:20:34AM +0100, Christoph Hellwig wrote:
>On Thu, Jul 22, 2021 at 01:55:23AM -0400, Lucas De Marchi wrote:
>> humn... PORT_F. KBL doesn't have PORT_F. We decided to keep the handling
>> of DISPLAY_VER == 10 and DISPLAY_VER == 9 together and trust the VBT,
>> but when the VBT is not present, DDI F will get added unconditio.
>>
>> maybe best thing to do is to split that
>
>With this and the previous patch the stack traces are gone.

maybe not the perfect fix though... can you share how you're starting
qemu so I can try to reproduce it? I'd like to see a log with
drm.debug=0xe param.

In theory 5a9d38b20a5a ("drm/i915/display: hide workaround for broken vbt in intel_bios.c")
should filter out the PORT_F in KBL.


thanks
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] 5.14-rc2 warnings with kvmgvt
  2021-07-22 16:03               ` Lucas De Marchi
@ 2021-07-22 16:08                 ` Christoph Hellwig
  0 siblings, 0 replies; 14+ messages in thread
From: Christoph Hellwig @ 2021-07-22 16:08 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: Christoph Hellwig, intel-gfx, intel-gvt-dev

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

On Thu, Jul 22, 2021 at 09:03:45AM -0700, Lucas De Marchi wrote:
> On Thu, Jul 22, 2021 at 08:20:34AM +0100, Christoph Hellwig wrote:
> > On Thu, Jul 22, 2021 at 01:55:23AM -0400, Lucas De Marchi wrote:
> > > humn... PORT_F. KBL doesn't have PORT_F. We decided to keep the handling
> > > of DISPLAY_VER == 10 and DISPLAY_VER == 9 together and trust the VBT,
> > > but when the VBT is not present, DDI F will get added unconditio.
> > > 
> > > maybe best thing to do is to split that
> > 
> > With this and the previous patch the stack traces are gone.
> 
> maybe not the perfect fix though... can you share how you're starting
> qemu so I can try to reproduce it? I'd like to see a log with
> drm.debug=0xe param.
> 
> In theory 5a9d38b20a5a ("drm/i915/display: hide workaround for broken vbt in intel_bios.c")
> should filter out the PORT_F in KBL.

Here is my qemu script that reproduces the issue:


[-- Attachment #2: kvm-gvt.sh --]
[-- Type: application/x-sh, Size: 696 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-07-22 16:09 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 11:10 [Intel-gfx] 5.14-rc2 warnings with kvmgvt Christoph Hellwig
2021-07-21 11:24 ` Rodrigo Vivi
2021-07-21 15:43   ` Christoph Hellwig
2021-07-21 20:40     ` Christoph Hellwig
2021-07-21 21:18       ` Rodrigo Vivi
2021-07-22  4:24         ` Christoph Hellwig
2021-07-22  5:55           ` Lucas De Marchi
2021-07-22  7:20             ` Christoph Hellwig
2021-07-22 16:03               ` Lucas De Marchi
2021-07-22 16:08                 ` Christoph Hellwig
2021-07-21 21:47 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2021-07-22  5:05 ` [Intel-gfx] " Zhenyu Wang
2021-07-22  5:52   ` Christoph Hellwig
2021-07-22  6:34 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for 5.14-rc2 warnings with kvmgvt (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).