intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Anusha Srivatsa" <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915/step: Add macro magic for handling steps
Date: Wed, 21 Jul 2021 22:28:56 -0000	[thread overview]
Message-ID: <162690653691.768.17943926306453912309@emeril.freedesktop.org> (raw)
In-Reply-To: <20210721215238.24980-1-anusha.srivatsa@intel.com>

== Series Details ==

Series: series starting with [CI,1/4] drm/i915/step: Add macro magic for handling steps
URL   : https://patchwork.freedesktop.org/series/92849/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c0b839cec037 drm/i915/step: Add macro magic for handling steps
-:24: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#24: FILE: drivers/gpu/drm/i915/intel_step.c:186:
+#define STEP_NAME_CASE(name)	\
+	case STEP_##name:	\
+		return #name;

-:24: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#24: FILE: drivers/gpu/drm/i915/intel_step.c:186:
+#define STEP_NAME_CASE(name)	\
+	case STEP_##name:	\
+		return #name;

-:47: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#47: FILE: drivers/gpu/drm/i915/intel_step.h:20:
+#define STEP_NAME_LIST(func)		\
+	func(A0)			\
+	func(A1)			\
+	func(A2)			\
+	func(B0)			\
+	func(B1)			\
+	func(B2)			\
+	func(C0)			\
+	func(C1)			\
+	func(D0)			\
+	func(D1)			\
+	func(E0)			\
+	func(F0)			\
+	func(G0)			\
+	func(H0)			\
+	func(I0)			\
+	func(I1)			\
+	func(J0)

-:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#47: FILE: drivers/gpu/drm/i915/intel_step.h:20:
+#define STEP_NAME_LIST(func)		\
+	func(A0)			\
+	func(A1)			\
+	func(A2)			\
+	func(B0)			\
+	func(B1)			\
+	func(B2)			\
+	func(C0)			\
+	func(C1)			\
+	func(D0)			\
+	func(D1)			\
+	func(E0)			\
+	func(F0)			\
+	func(G0)			\
+	func(H0)			\
+	func(I0)			\
+	func(I1)			\
+	func(J0)

total: 2 errors, 1 warnings, 1 checks, 71 lines checked
ef7c2d172b12 drm/i915/dmc: Change intel_get_stepping_info()
4a8d375d3242 drm/i915/firmware: Update to DMC v2.12 on TGL
-:10: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Madhumitha Pradeep <'
#10: 
Reviewed-by: Madhumitha Pradeep <

total: 1 errors, 0 warnings, 0 checks, 10 lines checked
55698bd418a0 drm/i915/firmware: Update to DMC v2.03 on RKL
-:12: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Madhumitha Pradeep <'
#12: 
Reviewed-by: Madhumitha Pradeep <

total: 1 errors, 0 warnings, 0 checks, 10 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-07-21 22:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 21:52 [Intel-gfx] [CI 1/4] " Anusha Srivatsa
2021-07-21 21:52 ` [Intel-gfx] [CI 2/4] drm/i915/dmc: Change intel_get_stepping_info() Anusha Srivatsa
2021-07-21 21:52 ` [Intel-gfx] [CI 3/4] drm/i915/firmware: Update to DMC v2.12 on TGL Anusha Srivatsa
2021-07-23 23:42   ` Matt Roper
2021-07-21 21:52 ` [Intel-gfx] [CI 4/4] drm/i915/firmware: Update to DMC v2.03 on RKL Anusha Srivatsa
2021-07-21 22:28 ` Patchwork [this message]
2021-07-21 22:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] drm/i915/step: Add macro magic for handling steps Patchwork
2021-07-21 23:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-22  5:07 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162690653691.768.17943926306453912309@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=anusha.srivatsa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --subject='Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915/step: Add macro magic for handling steps' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).