From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp
Date: Thu, 29 Jul 2021 11:48:35 -0000 [thread overview]
Message-ID: <162755931563.27324.11268197814645098181@emeril.freedesktop.org> (raw)
In-Reply-To: <20210729111848.729888-1-tvrtko.ursulin@linux.intel.com>
== Series Details ==
Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp
URL : https://patchwork.freedesktop.org/series/93176/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2870e3292b14 drm/i915/selftests: fixup igt_shrink_thp
2b2db1afa93b drm/i915: Use Transparent Hugepages when IOMMU is enabled
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")'
#6:
Usage of Transparent Hugepages was disabled in 9987da4b5dcf
-:25: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b901bb89324a ("drm/i915/gemfs: enable THP")'
#25:
References: b901bb89324a ("drm/i915/gemfs: enable THP")
-:26: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#26:
References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")
-:26: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")'
#26:
References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")
-:130: WARNING:STATIC_CONST_CHAR_ARRAY: static char array declaration should probably be static const char
#130: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:17:
+ static char thp_native[] = "huge=" CONFIG_DRM_I915_THP_NATIVE;
-:131: WARNING:STATIC_CONST_CHAR_ARRAY: static char array declaration should probably be static const char
#131: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:18:
+ static char thp_iommu[] = "huge=" CONFIG_DRM_I915_THP_IOMMU;
-:146: CHECK:LINE_SPACING: Please don't use multiple blank lines
#146: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:33:
+
+
total: 3 errors, 3 warnings, 1 checks, 116 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-29 11:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 11:18 [Intel-gfx] [PATCH 1/2] drm/i915/selftests: fixup igt_shrink_thp Tvrtko Ursulin
2021-07-29 11:18 ` [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled Tvrtko Ursulin
2021-07-29 12:07 ` Daniel Vetter
2021-07-29 12:21 ` Tvrtko Ursulin
2021-07-29 12:28 ` Daniel Vetter
2021-07-29 11:48 ` Patchwork [this message]
2021-07-29 12:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp Patchwork
2021-07-29 20:53 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-29 13:34 [Intel-gfx] [PATCH 1/2] " Tvrtko Ursulin
2021-07-29 14:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162755931563.27324.11268197814645098181@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).