From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDC5C4338F for ; Thu, 29 Jul 2021 11:48:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7FAF6056C for ; Thu, 29 Jul 2021 11:48:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A7FAF6056C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 515B56E1A8; Thu, 29 Jul 2021 11:48:37 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTP id A24436E1A8; Thu, 29 Jul 2021 11:48:35 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 9BBE5AA915; Thu, 29 Jul 2021 11:48:35 +0000 (UTC) MIME-Version: 1.0 From: Patchwork To: "Tvrtko Ursulin" Date: Thu, 29 Jul 2021 11:48:35 -0000 Message-ID: <162755931563.27324.11268197814645098181@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20210729111848.729888-1-tvrtko.ursulin@linux.intel.com> In-Reply-To: <20210729111848.729888-1-tvrtko.ursulin@linux.intel.com> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_series_starting_with_=5B1/2=5D_drm/i915/selftests=3A_fixup_?= =?utf-8?q?igt=5Fshrink=5Fthp?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93176/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2870e3292b14 drm/i915/selftests: fixup igt_shrink_thp 2b2db1afa93b drm/i915: Use Transparent Hugepages when IOMMU is enabled -:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")' #6: Usage of Transparent Hugepages was disabled in 9987da4b5dcf -:25: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b901bb89324a ("drm/i915/gemfs: enable THP")' #25: References: b901bb89324a ("drm/i915/gemfs: enable THP") -:26: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #26: References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") -:26: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")' #26: References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") -:130: WARNING:STATIC_CONST_CHAR_ARRAY: static char array declaration should probably be static const char #130: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:17: + static char thp_native[] = "huge=" CONFIG_DRM_I915_THP_NATIVE; -:131: WARNING:STATIC_CONST_CHAR_ARRAY: static char array declaration should probably be static const char #131: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:18: + static char thp_iommu[] = "huge=" CONFIG_DRM_I915_THP_IOMMU; -:146: CHECK:LINE_SPACING: Please don't use multiple blank lines #146: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:33: + + total: 3 errors, 3 warnings, 1 checks, 116 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <SRS0=MAHO=MV=lists.freedesktop.org=intel-gfx-bounces@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 042D1C432BE for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 13:34:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4D7E60F23 for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 13:34:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B4D7E60F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17C5E6E203; Thu, 29 Jul 2021 13:34:33 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFC096E203; Thu, 29 Jul 2021 13:34:31 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="209769967" X-IronPort-AV: E=Sophos;i="5.84,278,1620716400"; d="scan'208";a="209769967" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2021 06:34:30 -0700 X-IronPort-AV: E=Sophos;i="5.84,278,1620716400"; d="scan'208";a="438420086" Received: from eoghanru-mobl.ger.corp.intel.com (HELO tursulin-mobl2.home) ([10.213.215.170]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2021 06:34:29 -0700 From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Intel-gfx@lists.freedesktop.org Date: Thu, 29 Jul 2021 14:34:19 +0100 Message-Id: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: fixup igt_shrink_thp X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development <intel-gfx.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/intel-gfx> List-Post: <mailto:intel-gfx@lists.freedesktop.org> List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe> Cc: Matthew Auld <matthew.auld@intel.com>, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org> From: Matthew Auld <matthew.auld@intel.com> Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the test being skipped, but if we ever re-enable THP we might start seeing the failure. Fix this by forcing I915_SHRINK_ACTIVE. Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c index a094f3ce1a90..acc435f14ac9 100644 --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c @@ -1572,12 +1572,15 @@ static int igt_shrink_thp(void *arg) goto out_put; /* - * Now that the pages are *unpinned* shrink-all should invoke + * Now that the pages are *unpinned* shrinking should invoke * shmem to truncate our pages. */ - i915_gem_shrink_all(i915); + i915_gem_shrink(NULL, i915, -1UL, NULL, + I915_SHRINK_BOUND | + I915_SHRINK_UNBOUND | + I915_SHRINK_ACTIVE); if (i915_gem_object_has_pages(obj)) { - pr_err("shrink-all didn't truncate the pages\n"); + pr_err("shrinking didn't truncate the pages\n"); err = -EINVAL; goto out_put; } -- 2.30.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <SRS0=MAHO=MV=lists.freedesktop.org=intel-gfx-bounces@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA74C4338F for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 13:34:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C268260F42 for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 13:34:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C268260F42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C35406ECAB; Thu, 29 Jul 2021 13:34:34 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 834596ECAB; Thu, 29 Jul 2021 13:34:33 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="209769972" X-IronPort-AV: E=Sophos;i="5.84,278,1620716400"; d="scan'208";a="209769972" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2021 06:34:33 -0700 X-IronPort-AV: E=Sophos;i="5.84,278,1620716400"; d="scan'208";a="438420097" Received: from eoghanru-mobl.ger.corp.intel.com (HELO tursulin-mobl2.home) ([10.213.215.170]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2021 06:34:30 -0700 From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Intel-gfx@lists.freedesktop.org Date: Thu, 29 Jul 2021 14:34:20 +0100 Message-Id: <20210729133420.770672-2-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> References: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development <intel-gfx.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/intel-gfx> List-Post: <mailto:intel-gfx@lists.freedesktop.org> List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe> Cc: Eero Tamminen <eero.t.tamminen@intel.com>, dri-devel@lists.freedesktop.org, Chris Wilson <chris@chris-wilson.co.uk>, Matthew Auld <matthew.auld@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressions reported with an enabled IOMMU can be almost eliminated by turning them on, lets just do that. To err on the side of safety we keep the current default in cases where IOMMU is not active, and only when it is default to the "huge=within_size" mode. Although there probably would be wins to enable them throughout, more extensive testing across benchmarks and platforms would need to be done. With the patch and IOMMU enabled my local testing on a small Skylake part shows OglVSTangent regression being reduced from ~14% (IOMMU on versus IOMMU off) to ~2% (same comparison but with THP on). v2: * Add Kconfig dependency to transparent hugepages and some help text. * Move to helper for easier handling of kernel build options. v3: * Drop Kconfig. (Daniel) References: b901bb89324a ("drm/i915/gemfs: enable THP") References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") References: https://gitlab.freedesktop.org/drm/intel/-/issues/430 Co-developed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Eero Tamminen <eero.t.tamminen@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> # v1 --- drivers/gpu/drm/i915/gem/i915_gemfs.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c index 5e6e8c91ab38..dbdbdc344d87 100644 --- a/drivers/gpu/drm/i915/gem/i915_gemfs.c +++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c @@ -6,7 +6,6 @@ #include <linux/fs.h> #include <linux/mount.h> -#include <linux/pagemap.h> #include "i915_drv.h" #include "i915_gemfs.h" @@ -15,6 +14,7 @@ int i915_gemfs_init(struct drm_i915_private *i915) { struct file_system_type *type; struct vfsmount *gemfs; + char *opts; type = get_fs_type("tmpfs"); if (!type) @@ -26,10 +26,26 @@ int i915_gemfs_init(struct drm_i915_private *i915) * * One example, although it is probably better with a per-file * control, is selecting huge page allocations ("huge=within_size"). - * Currently unused due to bandwidth issues (slow reads) on Broadwell+. + * However, we only do so to offset the overhead of iommu lookups + * due to bandwidth issues (slow reads) on Broadwell+. */ - gemfs = kern_mount(type); + opts = NULL; + if (intel_vtd_active()) { + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { + static char huge_opt[] = "huge=within_size"; /* r/w */ + + opts = huge_opt; + drm_info(&i915->drm, + "Transparent Hugepage mode '%s'\n", + opts); + } else { + drm_notice(&i915->drm, + "Transparent Hugepage support is recommended for optimal performance when IOMMU is enabled!\n"); + } + } + + gemfs = vfs_kern_mount(type, SB_KERNMOUNT, type->name, opts); if (IS_ERR(gemfs)) return PTR_ERR(gemfs); -- 2.30.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <SRS0=MAHO=MV=lists.freedesktop.org=intel-gfx-bounces@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26DA2C4338F for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 14:01:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E14C260238 for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 14:01:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E14C260238 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75DAF89C8D; Thu, 29 Jul 2021 14:01:46 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTP id 5513889C8D; Thu, 29 Jul 2021 14:01:45 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 4CCFBA47DB; Thu, 29 Jul 2021 14:01:45 +0000 (UTC) MIME-Version: 1.0 From: Patchwork <patchwork@emeril.freedesktop.org> To: "Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com> Date: Thu, 29 Jul 2021 14:01:45 -0000 Message-ID: <162756730529.27325.16984714667767542806@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> In-Reply-To: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_series_starting_with_=5B1/2=5D_drm/i915/selftests=3A_fixup_?= =?utf-8?q?igt=5Fshrink=5Fthp?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development <intel-gfx.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/intel-gfx> List-Post: <mailto:intel-gfx@lists.freedesktop.org> List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe> Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org> == Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93182/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1cac26e2f95f drm/i915/selftests: fixup igt_shrink_thp 054c89f72f0f drm/i915: Use Transparent Hugepages when IOMMU is enabled -:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")' #6: Usage of Transparent Hugepages was disabled in 9987da4b5dcf -:28: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b901bb89324a ("drm/i915/gemfs: enable THP")' #28: References: b901bb89324a ("drm/i915/gemfs: enable THP") -:29: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #29: References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") -:29: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")' #29: References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") -:75: WARNING:STATIC_CONST_CHAR_ARRAY: static char array declaration should probably be static const char #75: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:36: + static char huge_opt[] = "huge=within_size"; /* r/w */ total: 3 errors, 2 warnings, 0 checks, 42 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <SRS0=MAHO=MV=lists.freedesktop.org=intel-gfx-bounces@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E8DC4338F for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 14:06:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B94B60EBD for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 14:06:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5B94B60EBD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F27B66ECCC; Thu, 29 Jul 2021 14:06:43 +0000 (UTC) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D1E66ECD0 for <Intel-gfx@lists.freedesktop.org>; Thu, 29 Jul 2021 14:06:43 +0000 (UTC) Received: by mail-ot1-x32c.google.com with SMTP id c7-20020a9d27870000b02904d360fbc71bso5935577otb.10 for <Intel-gfx@lists.freedesktop.org>; Thu, 29 Jul 2021 07:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GQQzsyH/f6URg61tofzTvzb4mIeJR5g7C3j0V5QBWwQ=; b=ccbwg/bqYjVhkbLdaxvR8EM6zEzvGcGu7jr7OUsCCGSCnUW09Z3Opg1lve/8/IKAwN 8Fou8bwC9ssQMTDHd+l/VrFCF1mWwf+/KDB/03XJ3iP/eyXi47/rABfdm0EE4PW8oIJk fhKCnfC0U6DV4w+RwR/ndawzv56yVxsss6w0s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GQQzsyH/f6URg61tofzTvzb4mIeJR5g7C3j0V5QBWwQ=; b=aUvhqB1a+6p/kHUjtyq/7rjoZOlq+Lb1iOmMd2cMbwfsz8laUyhCQBhFxaS5Ew3vMB A3PkmdeCpK5v2pIyYP56zBmBdOLxBKKcfOHyYTmWZA+fgVmwfUGZWgcbvcvbetRVrDxF RxBJUr7NJdp+DsfQ7vDtfMpUzW14LjwMGU4e2WNvhi34AcpP7YyWSUSw7XsNsohqAOAy 6cyupvUIvtCMhYZ4r/htELgVFxbOgYx9KbGo6/mkk07GPHCznRpWT05QuUzZnjZFCQWV JGQJ//WND3R9ioVCGdp+WAu8mLXvbuoFj5EW/HIZkB8xeduG+YR+51TF3UKs3y2O03NH XF1A== X-Gm-Message-State: AOAM532rYTJ/ENNlMx/QHPl8BI9qE/xDJhxSUMnp4TcaMR/jOdd5OmQy WC0P6vHItlRN3QDkMYRV+/HYIK0ER/kyJGILFYgaGg== X-Google-Smtp-Source: ABdhPJxbrM2UdOJP5RHayc+aBxFznHhjSEsliI4VDpONNANw9FR5U/edlulFU7nITKOLjQcHXMH3SpVmt5O6OM8J/RI= X-Received: by 2002:a9d:27a4:: with SMTP id c33mr3642364otb.281.1627567602332; Thu, 29 Jul 2021 07:06:42 -0700 (PDT) MIME-Version: 1.0 References: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> <20210729133420.770672-2-tvrtko.ursulin@linux.intel.com> In-Reply-To: <20210729133420.770672-2-tvrtko.ursulin@linux.intel.com> From: Daniel Vetter <daniel@ffwll.ch> Date: Thu, 29 Jul 2021 16:06:31 +0200 Message-ID: <CAKMK7uE412nf5RisGBR2GrNsvgPH+omHv4K+m5McJv1t55DQMQ@mail.gmail.com> To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development <intel-gfx.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/intel-gfx> List-Post: <mailto:intel-gfx@lists.freedesktop.org> List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe> Cc: intel-gfx <Intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>, Chris Wilson <chris@chris-wilson.co.uk>, Matthew Auld <matthew.auld@intel.com>, Eero Tamminen <eero.t.tamminen@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org> On Thu, Jul 29, 2021 at 3:34 PM Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Usage of Transparent Hugepages was disabled in 9987da4b5dcf > ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it > appears majority of performance regressions reported with an enabled IOMMU > can be almost eliminated by turning them on, lets just do that. > > To err on the side of safety we keep the current default in cases where > IOMMU is not active, and only when it is default to the "huge=within_size" > mode. Although there probably would be wins to enable them throughout, > more extensive testing across benchmarks and platforms would need to be > done. > > With the patch and IOMMU enabled my local testing on a small Skylake part > shows OglVSTangent regression being reduced from ~14% (IOMMU on versus > IOMMU off) to ~2% (same comparison but with THP on). > > v2: > * Add Kconfig dependency to transparent hugepages and some help text. > * Move to helper for easier handling of kernel build options. > > v3: > * Drop Kconfig. (Daniel) > > References: b901bb89324a ("drm/i915/gemfs: enable THP") > References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") > References: https://gitlab.freedesktop.org/drm/intel/-/issues/430 > Co-developed-by: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Eero Tamminen <eero.t.tamminen@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> # v1 On both patches: Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/i915/gem/i915_gemfs.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c > index 5e6e8c91ab38..dbdbdc344d87 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gemfs.c > +++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c > @@ -6,7 +6,6 @@ > > #include <linux/fs.h> > #include <linux/mount.h> > -#include <linux/pagemap.h> > > #include "i915_drv.h" > #include "i915_gemfs.h" > @@ -15,6 +14,7 @@ int i915_gemfs_init(struct drm_i915_private *i915) > { > struct file_system_type *type; > struct vfsmount *gemfs; > + char *opts; > > type = get_fs_type("tmpfs"); > if (!type) > @@ -26,10 +26,26 @@ int i915_gemfs_init(struct drm_i915_private *i915) > * > * One example, although it is probably better with a per-file > * control, is selecting huge page allocations ("huge=within_size"). > - * Currently unused due to bandwidth issues (slow reads) on Broadwell+. > + * However, we only do so to offset the overhead of iommu lookups > + * due to bandwidth issues (slow reads) on Broadwell+. > */ > > - gemfs = kern_mount(type); > + opts = NULL; > + if (intel_vtd_active()) { > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > + static char huge_opt[] = "huge=within_size"; /* r/w */ > + > + opts = huge_opt; > + drm_info(&i915->drm, > + "Transparent Hugepage mode '%s'\n", > + opts); > + } else { > + drm_notice(&i915->drm, > + "Transparent Hugepage support is recommended for optimal performance when IOMMU is enabled!\n"); > + } > + } > + > + gemfs = vfs_kern_mount(type, SB_KERNMOUNT, type->name, opts); > if (IS_ERR(gemfs)) > return PTR_ERR(gemfs); > > -- > 2.30.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <SRS0=MAHO=MV=lists.freedesktop.org=intel-gfx-bounces@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5386C4338F for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 14:29:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 844B560F4B for <intel-gfx@archiver.kernel.org>; Thu, 29 Jul 2021 14:29:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 844B560F4B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EF636EC67; Thu, 29 Jul 2021 14:29:44 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [IPv6:2610:10:20:722:a800:ff:feee:56cf]) by gabe.freedesktop.org (Postfix) with ESMTP id C75866EC67; Thu, 29 Jul 2021 14:29:42 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id C17C1A73C9; Thu, 29 Jul 2021 14:29:42 +0000 (UTC) MIME-Version: 1.0 From: Patchwork <patchwork@emeril.freedesktop.org> To: "Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com> Date: Thu, 29 Jul 2021 14:29:42 -0000 Message-ID: <162756898276.27325.2425100379877426394@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> In-Reply-To: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> Subject: [Intel-gfx] =?utf-8?b?4pyTIEZpLkNJLkJBVDogc3VjY2VzcyBmb3Igc2Vy?= =?utf-8?q?ies_starting_with_=5B1/2=5D_drm/i915/selftests=3A_fixup_igt=5Fs?= =?utf-8?q?hrink=5Fthp?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development <intel-gfx.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/intel-gfx> List-Post: <mailto:intel-gfx@lists.freedesktop.org> List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe> Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Content-Type: multipart/mixed; boundary="===============0237833080==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org> --===============0237833080== Content-Type: multipart/alternative; boundary="===============8306744713819307641==" --===============8306744713819307641== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit == Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93182/ State : success == Summary == CI Bug Log - changes from CI_DRM_10418 -> Patchwork_20741 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/index.html Known issues ------------ Here are the changes found in Patchwork_20741 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@semaphore: - fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +29 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html * igt@core_hotunplug@unbind-rebind: - fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#3718]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html * igt@i915_pm_rpm@basic-rte: - fi-bdw-5557u: NOTRUN -> [FAIL][3] ([i915#579]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/fi-bdw-5557u/igt@i915_pm_rpm@basic-rte.html * igt@kms_chamelium@dp-crc-fast: - fi-bdw-5557u: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0: - fi-tgl-1115g4: [FAIL][5] ([i915#1888]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-7500u: [DMESG-FAIL][7] ([i915#165]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 [i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718 [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579 Participating hosts (41 -> 34) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-adlp-4 fi-ctg-p8600 fi-bdw-samus bat-jsl-1 Build changes ------------- * Linux: CI_DRM_10418 -> Patchwork_20741 CI-20190529: 20190529 CI_DRM_10418: e8b9eb4ffe9ad59eeda3c5318282fc2d7acbe7da @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6156: 354638455597ac48ac433606b24b82a4d7b65d20 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_20741: 054c89f72f0f9f04e8377c7f9f5c66a6a7d047f8 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 054c89f72f0f drm/i915: Use Transparent Hugepages when IOMMU is enabled 1cac26e2f95f drm/i915/selftests: fixup igt_shrink_thp == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/index.html --===============8306744713819307641== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <!DOCTYPE html> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> <title>Project List - Patchwork Patch Details
Series:series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp
URL:https://patchwork.freedesktop.org/series/93182/
State:success
Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/index.html

CI Bug Log - changes from CI_DRM_10418 -> Patchwork_20741

Summary

SUCCESS

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/index.html

Known issues

Here are the changes found in Patchwork_20741 that come from known issues:

IGT changes

Issues hit

  • igt@amdgpu/amd_basic@semaphore:

  • igt@core_hotunplug@unbind-rebind:

  • igt@i915_pm_rpm@basic-rte:

  • igt@kms_chamelium@dp-crc-fast:

Possible fixes

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (41 -> 34)

Missing (7): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-adlp-4 fi-ctg-p8600 fi-bdw-samus bat-jsl-1

Build changes

  • Linux: CI_DRM_10418 -> Patchwork_20741

CI-20190529: 20190529
CI_DRM_10418: e8b9eb4ffe9ad59eeda3c5318282fc2d7acbe7da @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6156: 354638455597ac48ac433606b24b82a4d7b65d20 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20741: 054c89f72f0f9f04e8377c7f9f5c66a6a7d047f8 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

054c89f72f0f drm/i915: Use Transparent Hugepages when IOMMU is enabled
1cac26e2f95f drm/i915/selftests: fixup igt_shrink_thp

--===============8306744713819307641==-- --===============0237833080== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0237833080==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, MIME_HTML_MOSTLY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C45E8C4338F for ; Thu, 29 Jul 2021 23:16:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83D9860C40 for ; Thu, 29 Jul 2021 23:16:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 83D9860C40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D60F6EE78; Thu, 29 Jul 2021 23:16:11 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [IPv6:2610:10:20:722:a800:ff:feee:56cf]) by gabe.freedesktop.org (Postfix) with ESMTP id 143036EE78; Thu, 29 Jul 2021 23:16:10 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 0C95DA7DFB; Thu, 29 Jul 2021 23:16:10 +0000 (UTC) MIME-Version: 1.0 From: Patchwork To: "Tvrtko Ursulin" Date: Thu, 29 Jul 2021 23:16:10 -0000 Message-ID: <162760057002.27326.3343675983619968883@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> In-Reply-To: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> Subject: [Intel-gfx] =?utf-8?b?4pyTIEZpLkNJLklHVDogc3VjY2VzcyBmb3Igc2Vy?= =?utf-8?q?ies_starting_with_=5B1/2=5D_drm/i915/selftests=3A_fixup_igt=5Fs?= =?utf-8?q?hrink=5Fthp?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Content-Type: multipart/mixed; boundary="===============1428430308==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --===============1428430308== Content-Type: multipart/alternative; boundary="===============3378060327146026033==" --===============3378060327146026033== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit == Series Details == Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp URL : https://patchwork.freedesktop.org/series/93182/ State : success == Summary == CI Bug Log - changes from CI_DRM_10418_full -> Patchwork_20741_full ==================================================== Summary ------- **SUCCESS** No regressions found. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20741_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gen7_exec_parse@basic-allowed: - {shard-rkl}: [SKIP][1] ([fdo#109289]) -> [TIMEOUT][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@gen7_exec_parse@basic-allowed.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-2/igt@gen7_exec_parse@basic-allowed.html * igt@kms_busy@extended-pageflip-hang-newfb: - {shard-rkl}: NOTRUN -> [SKIP][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-5/igt@kms_busy@extended-pageflip-hang-newfb.html * igt@kms_cursor_crc@pipe-a-cursor-64x21-random: - {shard-rkl}: [SKIP][4] ([fdo#112022]) -> [TIMEOUT][5] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-2/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html * igt@kms_draw_crc@draw-method-rgb565-blt-ytiled: - {shard-rkl}: [SKIP][6] ([fdo#111314]) -> [DMESG-WARN][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-5/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt: - {shard-rkl}: [SKIP][8] ([i915#1849]) -> [TIMEOUT][9] +1 similar issue [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt.html * igt@runner@aborted: - {shard-rkl}: ([FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13], [FAIL][14]) ([i915#3002] / [i915#3810] / [i915#3811] / [i915#3871]) -> ([FAIL][15], [FAIL][16], [FAIL][17], [FAIL][18], [FAIL][19]) ([i915#2029] / [i915#3002] / [i915#3811] / [i915#3871]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-2/igt@runner@aborted.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-2/igt@runner@aborted.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@runner@aborted.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@runner@aborted.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-6/igt@runner@aborted.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-1/igt@runner@aborted.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@runner@aborted.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@runner@aborted.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-5/igt@runner@aborted.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@runner@aborted.html Known issues ------------ Here are the changes found in Patchwork_20741_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@legacy-engines-hostile-preempt: - shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#1099]) +2 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-snb7/igt@gem_ctx_persistence@legacy-engines-hostile-preempt.html * igt@gem_exec_fair@basic-pace@bcs0: - shard-iclb: [PASS][21] -> [FAIL][22] ([i915#2842]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb7/igt@gem_exec_fair@basic-pace@bcs0.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb1/igt@gem_exec_fair@basic-pace@bcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][23] ([i915#2842]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][24] -> [FAIL][25] ([i915#2842]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_schedule@semaphore-codependency: - shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271]) +137 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-snb5/igt@gem_exec_schedule@semaphore-codependency.html * igt@gem_huc_copy@huc-copy: - shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#2190]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl2/igt@gem_huc_copy@huc-copy.html - shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#2190]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl3/igt@gem_huc_copy@huc-copy.html * igt@gem_pread@exhaustion: - shard-apl: NOTRUN -> [WARN][29] ([i915#2658]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl2/igt@gem_pread@exhaustion.html * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled: - shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271]) +114 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl3/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html * igt@gem_softpin@noreloc-s3: - shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#180]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-apl1/igt@gem_softpin@noreloc-s3.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl3/igt@gem_softpin@noreloc-s3.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp: - shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#1937]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl8/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html * igt@i915_pm_rpm@basic-rte: - shard-apl: NOTRUN -> [FAIL][34] ([i915#579]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl6/igt@i915_pm_rpm@basic-rte.html * igt@i915_suspend@sysfs-reader: - shard-apl: NOTRUN -> [DMESG-WARN][35] ([i915#180]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl6/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - shard-skl: NOTRUN -> [FAIL][36] ([i915#3722]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3777]) +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0: - shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271]) +251 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html * igt@kms_chamelium@hdmi-hpd-enable-disable-mode: - shard-snb: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +8 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-snb5/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html * igt@kms_chamelium@hdmi-mode-timings: - shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +4 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl4/igt@kms_chamelium@hdmi-mode-timings.html * igt@kms_chamelium@vga-hpd: - shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +22 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl2/igt@kms_chamelium@vga-hpd.html * igt@kms_color@pipe-a-ctm-red-to-blue: - shard-skl: [PASS][42] -> [DMESG-WARN][43] ([i915#1982]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl6/igt@kms_color@pipe-a-ctm-red-to-blue.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl5/igt@kms_color@pipe-a-ctm-red-to-blue.html * igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes: - shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +3 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl10/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html * igt@kms_content_protection@srm: - shard-kbl: NOTRUN -> [TIMEOUT][45] ([i915#1319]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl3/igt@kms_content_protection@srm.html * igt@kms_cursor_legacy@pipe-d-torture-bo: - shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#533]) +1 similar issue [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl2/igt@kms_cursor_legacy@pipe-d-torture-bo.html * igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a: - shard-iclb: [PASS][47] -> [SKIP][48] ([i915#3788]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb3/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb2/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible: - shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271]) +77 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl10/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][50] -> [DMESG-WARN][51] ([i915#180]) +7 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@plain-flip-ts-check@a-edp1: - shard-skl: [PASS][52] -> [FAIL][53] ([i915#2122]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl8/igt@kms_flip@plain-flip-ts-check@a-edp1.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl2/igt@kms_flip@plain-flip-ts-check@a-edp1.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#533]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d: - shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#533]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl3/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: - shard-skl: [PASS][56] -> [FAIL][57] ([i915#53]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl10/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: - shard-apl: NOTRUN -> [FAIL][58] ([fdo#108145] / [i915#265]) +2 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: - shard-skl: NOTRUN -> [FAIL][59] ([i915#265]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][60] -> [FAIL][61] ([fdo#108145] / [i915#265]) +1 similar issue [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping: - shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2733]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-skl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl7/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1: - shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658]) +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#658]) +3 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@kms_psr2_su@page_flip: - shard-iclb: [PASS][66] -> [SKIP][67] ([fdo#109642] / [fdo#111068] / [i915#658]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb2/igt@kms_psr2_su@page_flip.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb4/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [PASS][68] -> [SKIP][69] ([fdo#109441]) +1 similar issue [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_selftest@all@damage_iter_no_damage: - shard-snb: NOTRUN -> [INCOMPLETE][70] ([i915#3871]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-snb5/igt@kms_selftest@all@damage_iter_no_damage.html * igt@kms_sysfs_edid_timing: - shard-skl: NOTRUN -> [FAIL][71] ([IGT#2]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl7/igt@kms_sysfs_edid_timing.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-kbl: [PASS][72] -> [INCOMPLETE][73] ([i915#155] / [i915#2828]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-kbl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html * igt@perf@polling: - shard-skl: [PASS][74] -> [FAIL][75] ([i915#1542]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl8/igt@perf@polling.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl9/igt@perf@polling.html * igt@sysfs_clients@sema-10: - shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#2994]) +1 similar issue [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl3/igt@sysfs_clients@sema-10.html - shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2994]) +1 similar issue [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl2/igt@sysfs_clients@sema-10.html * igt@sysfs_clients@sema-25: - shard-skl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2994]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl10/igt@sysfs_clients@sema-25.html #### Possible fixes #### * igt@fbdev@eof: - {shard-rkl}: [SKIP][79] ([i915#2582]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@fbdev@eof.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@fbdev@eof.html * igt@gem_ctx_persistence@legacy-engines-hang@render: - {shard-rkl}: [FAIL][81] ([i915#2410]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@render.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-1/igt@gem_ctx_persistence@legacy-engines-hang@render.html * igt@gem_eio@hibernate: - {shard-rkl}: [INCOMPLETE][83] ([i915#3833]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@gem_eio@hibernate.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-1/igt@gem_eio@hibernate.html * igt@gem_eio@unwedge-stress: - shard-tglb: [TIMEOUT][85] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-tglb2/igt@gem_eio@unwedge-stress.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-tglb8/igt@gem_eio@unwedge-stress.html - shard-iclb: [TIMEOUT][87] ([i915#2369] / [i915#2481] / [i915#3070]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb7/igt@gem_eio@unwedge-stress.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb8/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-glk: [FAIL][89] ([i915#2842]) -> [PASS][90] +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-glk7/igt@gem_exec_fair@basic-none-rrul@rcs0.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [FAIL][91] ([i915#2842]) -> [PASS][92] +2 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_suspend@basic-s0: - {shard-rkl}: [FAIL][93] ([fdo#103375]) -> [PASS][94] +1 similar issue [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-6/igt@gem_exec_suspend@basic-s0.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-5/igt@gem_exec_suspend@basic-s0.html * igt@gem_mmap_gtt@cpuset-big-copy: - {shard-rkl}: [FAIL][95] ([i915#307]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@gem_mmap_gtt@cpuset-big-copy.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-2/igt@gem_mmap_gtt@cpuset-big-copy.html * igt@i915_pm_rpm@sysfs-read: - {shard-rkl}: [SKIP][97] ([i915#3844] / [i915#579]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-6/igt@i915_pm_rpm@sysfs-read.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-5/igt@i915_pm_rpm@sysfs-read.html * igt@i915_selftest@live@gt_pm: - {shard-rkl}: [DMESG-FAIL][99] ([i915#1021]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-6/igt@i915_selftest@live@gt_pm.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-5/igt@i915_selftest@live@gt_pm.html * igt@kms_big_fb@linear-32bpp-rotate-180: - shard-glk: [DMESG-WARN][101] ([i915#118] / [i915#95]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-glk8/igt@kms_big_fb@linear-32bpp-rotate-180.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-glk9/igt@kms_big_fb@linear-32bpp-rotate-180.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip: - {shard-rkl}: [SKIP][103] ([i915#3721]) -> [PASS][104] +3 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs: - {shard-rkl}: [FAIL][105] ([i915#3678]) -> [PASS][106] +1 similar issue [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-5/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs.html * igt@kms_color@pipe-a-ctm-0-75: - {shard-rkl}: [SKIP][107] ([i915#1149] / [i915#1849]) -> [PASS][108] +2 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@kms_color@pipe-a-ctm-0-75.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_color@pipe-a-ctm-0-75.html * igt@kms_concurrent@pipe-a: - {shard-rkl}: [SKIP][109] ([i915#1845]) -> [PASS][110] +17 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-5/igt@kms_concurrent@pipe-a.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_concurrent@pipe-a.html * igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding: - {shard-rkl}: [SKIP][111] ([fdo#112022]) -> [PASS][112] +8 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-5/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-skl: [INCOMPLETE][113] ([i915#2828] / [i915#300]) -> [PASS][114] [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [DMESG-WARN][115] ([i915#180]) -> [PASS][116] +5 similar issues [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic: - shard-skl: [FAIL][117] ([i915#2346]) -> [PASS][118] [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic: - {shard-rkl}: [SKIP][119] ([fdo#111825]) -> [PASS][120] +5 similar issues [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-5/igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-apl: [DMESG-WARN][121] ([i915#180]) -> [PASS][122] +2 similar issues [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-apl3/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack-mmap-gtt: - {shard-rkl}: [SKIP][123] ([i915#1849] / [i915#3180]) -> [PASS][124] [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack-mmap-gtt.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt: - {shard-rkl}: [SKIP][125] ([i915#1849]) -> [PASS][126] +23 similar issues [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][127] ([i915#1188]) -> [PASS][128] +1 similar issue [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_plane_multiple@atomic-pipe-c-tiling-y: - {shard-rkl}: [SKIP][129] ([i915#3558]) -> [PASS][130] +2 similar issues [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html * igt@kms_psr@cursor_plane_move: - {shard-rkl}: [SKIP][131] ([i915#1072]) -> [PASS][132] +3 similar issues [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@kms_psr@cursor_plane_move.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@kms_psr@cursor_plane_move.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][133] ([fdo#109441]) -> [PASS][134] +3 similar issues [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@perf@polling-parameterized: - shard-skl: [FAIL][135] ([i915#1542]) -> [PASS][136] [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-skl8/igt@perf@polling-parameterized.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-skl9/igt@perf@polling-parameterized.html * igt@sysfs_preempt_timeout@timeout@rcs0: - {shard-rkl}: [FAIL][137] ([i915#2821]) -> [PASS][138] +3 similar issues [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-rkl-1/igt@sysfs_preempt_timeout@timeout@rcs0.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-rkl-6/igt@sysfs_preempt_timeout@timeout@rcs0.html #### Warnings #### * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][139] ([i915#588]) -> [SKIP][140] ([i915#658]) [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][141] ([i915#2684]) -> [WARN][142] ([i915#1804] / [i915#2684]) [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-iclb: [SKIP][143] ([i915#2920]) -> [SKIP][144] ([i915#658]) +1 similar issue [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3: - shard-iclb: [SKIP][145] ([i915#658]) -> [SKIP][146] ([i915#2920]) [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html * igt@runner@aborted: - shard-kbl: ([FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2426] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602]) -> ([FAIL][159], [FAIL][160], [FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164], [FAIL][165], [FAIL][166], [FAIL][167]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2426] / [i915#2505] / [i915#3002] / [i915#3363]) [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-kbl2/igt@runner@aborted.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/shard-kbl4/igt@runner@aborted.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10418/sha == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20741/index.html --===============3378060327146026033== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Project List - Patchwork Patch Details
Series:series starting with [1/2] drm/i915/selftest= s: fixup igt_shrink_thp
URL:https://patchwork.freedesktop.org/series/93182/
State:success
Details:https://intel-gfx-ci.01.org/tree/d= rm-tip/Patchwork_20741/index.html

CI Bug Log - changes from CI_DRM_10418_full -> Patchwork_20741_f= ull

Summary

SUCCESS

No regressions found.

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_= 20741_full:

IGT changes

Suppressed

The following results come from untrusted machines, tests, or statuses.<= br /> They do not affect the overall result.

Known issues

Here are the changes found in Patchwork_20741_full that come from known = issues:

IGT changes

Issues hit

  • igt@gem_ctx_persistence@legacy-engines-hostile-preempt:

    • shard-snb: NOTRUN -> SKIP ([fdo#109271] / [i915#1099]) +2 similar= issues

  • igt@gem_exec_fair@basic-pace@bcs0:

    • shard-iclb: PASS = -> FAIL ([i915#2842])

  • igt@gem_exec_fair@basic-pace@vcs1:

    • shard-iclb: NOTRUN -> FAIL ([i915#2842])

  • igt@gem_exec_fair@basic-throttle@rcs0:

  • igt@gem_exec_schedule@semaphore-codependency:

    • shard-snb: NOTRUN -> SKIP ([fdo#109271]) +137 similar issues

  • igt@gem_huc_copy@huc-copy:

    • shard-apl: NOTRUN -> SKI= P ([fdo#109271] / [i915#2190])

    • shard-kbl: NOTRUN -> SKI= P ([fdo#109271] / [i915#2190])

  • igt@gem_pread@exhaustion:

    • shard-apl: NOTRUN -> WAR= N ([i915#2658]) +1 similar issue

  • igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:

    • shard-kbl: NOTRUN -> SKIP ([fdo#109271]) +114 similar issues

  • igt@gem_softpin@noreloc-s3:

    • shard-apl: PASS -> DMESG-WARN ([i915#180])

  • igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:

    • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#1937])

  • igt@i915_pm_rpm@basic-rte:

    • shard-apl: NOTRUN -> FA= IL ([i915#579])

  • igt@i915_suspend@sysfs-reader:

    • shard-apl: NOTRUN -> FAIL ([i915#3722])

  • igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:

    • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#3777]) +1 si= milar issue

  • igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:

    • shard-apl: NOTRUN -> SKIP ([fdo#109271]) +251 similar issues

  • igt@kms_chamelium@hdmi-hpd-enable-disable-mode:

    • shard-snb: NOTRUN -> SKIP ([fdo#109271] / [fdo#111827]) +8 similar issues=

  • igt@kms_chamelium@hdmi-mode-timings:

    • shard-kbl: NOTRUN -> SKIP ([fdo#109271] / [fdo#111827]) +4 similar issues

  • igt@kms_chamelium@vga-hpd:

    • shard-apl: NOTRUN -> SK= IP ([fdo#109271] / [fdo#111827]) +22 similar issues

  • igt@kms_color@pipe-a-ctm-red-to-blue:

  • igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:

    • shard-skl: NOTRUN -> SKIP ([fdo#109271] / [fdo#111827]) +3 simil= ar issues

  • igt@kms_content_protection@srm:

    • shard-kbl: NOTRUN -> TIMEOUT ([i915#1319])

  • igt@kms_cursor_legacy@pipe-d-torture-bo:

    • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#533]) +1 similar issue

  • igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:

    • shard-iclb: PASS -> SKIP ([i915#3788])

  • igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:

    • shard-skl: NOTRUN -> SKIP ([fdo#109271]) +77 similar issues

  • igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:

  • igt@kms_flip@plain-flip-ts-check@a-edp1:

  • igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:

    • shard-skl: NOTRUN -> SKIP ([fdo#109271] / [i915#533])

  • igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:

    • shard-kbl: NOTRUN -> SKIP ([fdo#109271] / [i915#533])

  • igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:

  • igt@kms_plane_alpha_blend@pipe-a-alpha-basic:

    • shard-apl: NOTRUN -> FAIL ([fdo#108145] / [i915#265]) +2 similar issues

  • igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:

    • shard-skl: NOTRUN -> FAIL ([i915#265])

  • igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:

    • shard-skl: PASS -> = FAIL ([fdo#108145] / [i915#265]) +1 similar issue

  • igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-c= lipping-clamping:

    • shard-apl: NOTRUN -> SKIP ([fdo= #109271] / [i915#2733])

  • igt@kms_psr2_sf@cursor-plane-update-sf:

    • shard-skl: NOTRUN -> SKIP ([fdo#109271] / [i915#658]) +1 similar issue

  • igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:

    • shard-kbl: NOTRUN -> SKIP ([fdo#109271] / [i915#658]) +1 similar issu= e

  • igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:

    • shard-apl: NOTRUN -> SKIP ([fdo#109271] / [i915#658]) +3 similar is= sues

  • igt@kms_psr2_su@page_flip:

    • shard-iclb: PASS -> SKIP ([fdo#109642] / [fdo#111068] / = [i915#658])

  • igt@kms_psr@psr2_primary_page_flip:

    • shard-iclb: PASS= -> SKIP ([fdo#109441]= ) +1 similar issue

  • igt@kms_selftest@all@damage_iter_no_damage:

  • igt@kms_sysfs_edid_timing:

    • shard-skl: NOTRUN -> FA= IL ([IGT#2])

  • igt@kms_vblank@pipe-b-ts-continuation-suspend:

  • igt@perf@polling:

  • igt@sysfs_clients@sema-10:

    • shard-kbl: NOTRUN -> SKI= P ([fdo#109271] / [i915#2994]) +1 similar issue

    • shard-apl: NOTRUN -> SKI= P ([fdo#109271] / [i915#2994]) +1 similar issue

  • igt@sysfs_clients@sema-25:

    • shard-skl: NOTRUN -> S= KIP ([fdo#109271] / [i915#2994])

Possible fixes

  • igt@fbdev@eof:

    • {shard-rkl}: SKIP ([i915#2582]) -> = PASS

  • igt@gem_ctx_persistence@legacy-engines-hang@render:

    • {shard-rkl}: FAIL ([i915#2410]) -> PASS

  • igt@gem_eio@hibernate:

  • igt@gem_eio@unwedge-stress:

    • shard-tglb: TIMEOUT ([i91= 5#2369] / [i915#3063] / [i915#3648]) -> PASS

    • shard-iclb: TIMEOUT ([i91= 5#2369] / [i915#2481] / [i915#3070]) -> PASS

  • igt@gem_exec_fair@basic-none-rrul@rcs0:

  • igt@gem_exec_fair@basic-pace-share@rcs0:

    • shard-tglb: FAI= L ([i915#2842]) -> FAIL ([fd= o#103375]) -> PASS +1 simil= ar issue

  • igt@gem_mmap_gtt@cpuset-big-copy:

    • {shard-rkl}: FAIL (= [i915#307]) -> PASS

  • igt@i915_pm_rpm@sysfs-read:

    • {shard-rkl}: SKIP ([i915#= 3844] / [i915#579]) -> PASS

  • igt@i915_selftest@live@gt_pm:

  • igt@kms_big_fb@linear-32bpp-rotate-180:

  • igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:<= /p>

    • {shard-rkl}: SKIP ([i915#3721]) -> PASS +3= similar issues

  • igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs:

    • {shard-rkl}: FAIL ([i915#3678]) -> PASS +1 similar iss= ue

  • igt@kms_color@pipe-a-ctm-0-75:

    • {shard-rkl}: SKIP ([i9= 15#1149] / [i915#1849]) -> PASS= +2 similar issues

  • igt@kms_concurrent@pipe-a:

    • {shard-rkl}: SKIP ([i915#1= 845]) -> PASS +17 similar issue= s

  • igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding:

    • {shard-rkl}: SKIP ([fdo#112022]) -> PASS +8 similar issues

  • igt@kms_cursor_crc@pipe-a-cursor-suspend:

  • igt@kms_cursor_crc@pipe-c-cursor-suspend:

  • igt@kms_cursor_legacy@flip-vs-cursor-atomic:

  • igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic:

    • {shard-rkl}: SKIP ([fdo#111825]) -> PASS +5 similar issues

  • igt@kms_flip@flip-vs-suspend@a-dp1:

  • igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack-mmap-gtt:

  • igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt:

    • {shard-rkl}: SKIP ([i915#1849]) -> PASS +23 si= milar issues

  • igt@kms_hdr@bpc-switch-dpms:

    • shard-skl: FAIL ([i915#= 1188]) -> PASS +1 similar issu= e

  • igt@kms_plane_multiple@atomic-pipe-c-tiling-y:

    • {shard-rkl}: SKIP ([i915#3558]) -> PASS +2 similar issues

  • igt@kms_psr@cursor_plane_move:

    • {shard-rkl}: SKIP ([i9= 15#1072]) -> PASS +3 simila= r issues

  • igt@kms_psr@psr2_cursor_blt:

    • shard-iclb: SKIP ([fdo#= 109441]) -> PASS +3 similar i= ssues

  • igt@perf@polling-parameterized:

    • shard-skl: FAIL ([i9= 15#1542]) -> PASS

  • igt@sysfs_preempt_timeout@timeout@rcs0:

    • {shard-rkl}: FAIL= ([i915#2821]) -> = PASS +3 similar issues

Warnings

--===============3378060327146026033==-- --===============1428430308== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1428430308==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB6EC433EF for ; Fri, 3 Sep 2021 12:48:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75A4F61057 for ; Fri, 3 Sep 2021 12:48:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 75A4F61057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D00C6E88B; Fri, 3 Sep 2021 12:48:00 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id A59426E88A; Fri, 3 Sep 2021 12:47:58 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10095"; a="206532541" X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="206532541" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2021 05:47:58 -0700 X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="500348132" Received: from ojcasey-mobl.ger.corp.intel.com (HELO [10.213.195.251]) ([10.213.195.251]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2021 05:47:54 -0700 To: Daniel Vetter Cc: intel-gfx , dri-devel , Tvrtko Ursulin , Chris Wilson , Joonas Lahtinen , Matthew Auld , Eero Tamminen , Rodrigo Vivi References: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> <20210729133420.770672-2-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Fri, 3 Sep 2021 13:47:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 29/07/2021 15:06, Daniel Vetter wrote: > On Thu, Jul 29, 2021 at 3:34 PM Tvrtko Ursulin > wrote: >> >> From: Tvrtko Ursulin >> >> Usage of Transparent Hugepages was disabled in 9987da4b5dcf >> ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it >> appears majority of performance regressions reported with an enabled IOMMU >> can be almost eliminated by turning them on, lets just do that. >> >> To err on the side of safety we keep the current default in cases where >> IOMMU is not active, and only when it is default to the "huge=within_size" >> mode. Although there probably would be wins to enable them throughout, >> more extensive testing across benchmarks and platforms would need to be >> done. >> >> With the patch and IOMMU enabled my local testing on a small Skylake part >> shows OglVSTangent regression being reduced from ~14% (IOMMU on versus >> IOMMU off) to ~2% (same comparison but with THP on). >> >> v2: >> * Add Kconfig dependency to transparent hugepages and some help text. >> * Move to helper for easier handling of kernel build options. >> >> v3: >> * Drop Kconfig. (Daniel) >> >> References: b901bb89324a ("drm/i915/gemfs: enable THP") >> References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") >> References: https://gitlab.freedesktop.org/drm/intel/-/issues/430 >> Co-developed-by: Chris Wilson >> Signed-off-by: Chris Wilson >> Cc: Joonas Lahtinen >> Cc: Matthew Auld >> Cc: Eero Tamminen >> Cc: Tvrtko Ursulin >> Cc: Rodrigo Vivi >> Cc: Daniel Vetter >> Signed-off-by: Tvrtko Ursulin >> Reviewed-by: Rodrigo Vivi # v1 > > On both patches: Acked-by: Daniel Vetter Eero's testing results at https://gitlab.freedesktop.org/drm/intel/-/issues/430 are looking good - seem to show this to be a net win for at least Gen9 and Gen12 platforms. Is the ack enough to merge in this case or I should look for an r-b as well? Regards, Tvrtko >> --- >> drivers/gpu/drm/i915/gem/i915_gemfs.c | 22 +++++++++++++++++++--- >> 1 file changed, 19 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c >> index 5e6e8c91ab38..dbdbdc344d87 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gemfs.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c >> @@ -6,7 +6,6 @@ >> >> #include >> #include >> -#include >> >> #include "i915_drv.h" >> #include "i915_gemfs.h" >> @@ -15,6 +14,7 @@ int i915_gemfs_init(struct drm_i915_private *i915) >> { >> struct file_system_type *type; >> struct vfsmount *gemfs; >> + char *opts; >> >> type = get_fs_type("tmpfs"); >> if (!type) >> @@ -26,10 +26,26 @@ int i915_gemfs_init(struct drm_i915_private *i915) >> * >> * One example, although it is probably better with a per-file >> * control, is selecting huge page allocations ("huge=within_size"). >> - * Currently unused due to bandwidth issues (slow reads) on Broadwell+. >> + * However, we only do so to offset the overhead of iommu lookups >> + * due to bandwidth issues (slow reads) on Broadwell+. >> */ >> >> - gemfs = kern_mount(type); >> + opts = NULL; >> + if (intel_vtd_active()) { >> + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { >> + static char huge_opt[] = "huge=within_size"; /* r/w */ >> + >> + opts = huge_opt; >> + drm_info(&i915->drm, >> + "Transparent Hugepage mode '%s'\n", >> + opts); >> + } else { >> + drm_notice(&i915->drm, >> + "Transparent Hugepage support is recommended for optimal performance when IOMMU is enabled!\n"); >> + } >> + } >> + >> + gemfs = vfs_kern_mount(type, SB_KERNMOUNT, type->name, opts); >> if (IS_ERR(gemfs)) >> return PTR_ERR(gemfs); >> >> -- >> 2.30.2 >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DCDDC433F5 for ; Tue, 7 Sep 2021 08:42:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 100176103E for ; Tue, 7 Sep 2021 08:42:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 100176103E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F49E89D60; Tue, 7 Sep 2021 08:42:53 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id C7AD789DA8 for ; Tue, 7 Sep 2021 08:42:52 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id n5so13213646wro.12 for ; Tue, 07 Sep 2021 01:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1AjW4Kc6ZGOu180e/pv9qa4D2oUwYVALvaaYfq7mkpU=; b=ZXOfQiRF7AoffAtrkihEs3ZF2QqQsHfVGeOqtVJMGJci4ev78qJ/OomWcZHqwwwuCQ cdYl/4wVu4jGx8eIMTzDc3LiGSgNw3etgm04wUF7hrcxI8voYj/nUvZcgzpJjBB7511n iuYtuhdMyMvLhOn2KOqJGv+gKX6tpDbZp1as4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1AjW4Kc6ZGOu180e/pv9qa4D2oUwYVALvaaYfq7mkpU=; b=fGrJBjp8Pu+in+MFI+1m5GaST/VIKCdXxe8elG0BQX4X9c7RNLvUl8o6Nl2Tw0CFqA O6W9VeeW9PeJmTU8aRS9H/f8lshZIAjGPyslFEe85jZ5p4+76Bd1E0JyWBvmQJ5WyjvD AGL5bp0Mo91jdLkPXMVLyqGN+hh0err2eK7pSGv6SMgS+sCVIQkutNxM7GrQ+ywv5hXt uNeW/FRHApnvq6D3FUIQLvAwhDTHqjx6ZrOIxGf87O6QuE0X2BuXvUhEKF/iWryTLdOp kOb+8nnRPbtN/bc7AvasYH1nXFrisbOMbnkOi67jYCEK1bwT6CtFDJuSBaFwd9Q+eDLq gNsA== X-Gm-Message-State: AOAM532eUN8TWA2oBpVtqhIauLsJUetbdwafANcveMqE/p5Mni9knvza 1XCLM8Gax0RZz2AcSccfad2e9g== X-Google-Smtp-Source: ABdhPJx9yu5rT9NBxVQtAwN/o9g7BfgrQCFHeuntsG69nuWrDkH5b7HdWIETSHoX+KDV9jZV3TswLg== X-Received: by 2002:adf:ff86:: with SMTP id j6mr17501660wrr.299.1631004171366; Tue, 07 Sep 2021 01:42:51 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id d7sm9197126wrf.3.2021.09.07.01.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 01:42:50 -0700 (PDT) Date: Tue, 7 Sep 2021 10:42:49 +0200 From: Daniel Vetter To: Tvrtko Ursulin Cc: Daniel Vetter , intel-gfx , dri-devel , Tvrtko Ursulin , Chris Wilson , Joonas Lahtinen , Matthew Auld , Eero Tamminen , Rodrigo Vivi Message-ID: References: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> <20210729133420.770672-2-tvrtko.ursulin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Sep 03, 2021 at 01:47:52PM +0100, Tvrtko Ursulin wrote: > > On 29/07/2021 15:06, Daniel Vetter wrote: > > On Thu, Jul 29, 2021 at 3:34 PM Tvrtko Ursulin > > wrote: > > > > > > From: Tvrtko Ursulin > > > > > > Usage of Transparent Hugepages was disabled in 9987da4b5dcf > > > ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it > > > appears majority of performance regressions reported with an enabled IOMMU > > > can be almost eliminated by turning them on, lets just do that. > > > > > > To err on the side of safety we keep the current default in cases where > > > IOMMU is not active, and only when it is default to the "huge=within_size" > > > mode. Although there probably would be wins to enable them throughout, > > > more extensive testing across benchmarks and platforms would need to be > > > done. > > > > > > With the patch and IOMMU enabled my local testing on a small Skylake part > > > shows OglVSTangent regression being reduced from ~14% (IOMMU on versus > > > IOMMU off) to ~2% (same comparison but with THP on). > > > > > > v2: > > > * Add Kconfig dependency to transparent hugepages and some help text. > > > * Move to helper for easier handling of kernel build options. > > > > > > v3: > > > * Drop Kconfig. (Daniel) > > > > > > References: b901bb89324a ("drm/i915/gemfs: enable THP") > > > References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") > > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/430 > > > Co-developed-by: Chris Wilson > > > Signed-off-by: Chris Wilson > > > Cc: Joonas Lahtinen > > > Cc: Matthew Auld > > > Cc: Eero Tamminen > > > Cc: Tvrtko Ursulin > > > Cc: Rodrigo Vivi > > > Cc: Daniel Vetter > > > Signed-off-by: Tvrtko Ursulin > > > Reviewed-by: Rodrigo Vivi # v1 > > > > On both patches: Acked-by: Daniel Vetter > > Eero's testing results at > https://gitlab.freedesktop.org/drm/intel/-/issues/430 are looking good - > seem to show this to be a net win for at least Gen9 and Gen12 platforms. > > Is the ack enough to merge in this case or I should look for an r-b as well? Since your back to defacto v1 with the 2nd patch I think you have full r-b already. So more than enough I think. Please do record the relative perf numbers from Eero in that issue in the commit message so that we have that on the git log record too. It's easier to find there than following the link and finding the right comment in the issue. Thanks, Daniel > > Regards, > > Tvrtko > > > > --- > > > drivers/gpu/drm/i915/gem/i915_gemfs.c | 22 +++++++++++++++++++--- > > > 1 file changed, 19 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c > > > index 5e6e8c91ab38..dbdbdc344d87 100644 > > > --- a/drivers/gpu/drm/i915/gem/i915_gemfs.c > > > +++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c > > > @@ -6,7 +6,6 @@ > > > > > > #include > > > #include > > > -#include > > > > > > #include "i915_drv.h" > > > #include "i915_gemfs.h" > > > @@ -15,6 +14,7 @@ int i915_gemfs_init(struct drm_i915_private *i915) > > > { > > > struct file_system_type *type; > > > struct vfsmount *gemfs; > > > + char *opts; > > > > > > type = get_fs_type("tmpfs"); > > > if (!type) > > > @@ -26,10 +26,26 @@ int i915_gemfs_init(struct drm_i915_private *i915) > > > * > > > * One example, although it is probably better with a per-file > > > * control, is selecting huge page allocations ("huge=within_size"). > > > - * Currently unused due to bandwidth issues (slow reads) on Broadwell+. > > > + * However, we only do so to offset the overhead of iommu lookups > > > + * due to bandwidth issues (slow reads) on Broadwell+. > > > */ > > > > > > - gemfs = kern_mount(type); > > > + opts = NULL; > > > + if (intel_vtd_active()) { > > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > > > + static char huge_opt[] = "huge=within_size"; /* r/w */ > > > + > > > + opts = huge_opt; > > > + drm_info(&i915->drm, > > > + "Transparent Hugepage mode '%s'\n", > > > + opts); > > > + } else { > > > + drm_notice(&i915->drm, > > > + "Transparent Hugepage support is recommended for optimal performance when IOMMU is enabled!\n"); > > > + } > > > + } > > > + > > > + gemfs = vfs_kern_mount(type, SB_KERNMOUNT, type->name, opts); > > > if (IS_ERR(gemfs)) > > > return PTR_ERR(gemfs); > > > > > > -- > > > 2.30.2 > > > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A643FC433EF for ; Tue, 7 Sep 2021 09:34:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64FB1610F8 for ; Tue, 7 Sep 2021 09:34:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 64FB1610F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC61489F03; Tue, 7 Sep 2021 09:34:22 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8E0889ED6; Tue, 7 Sep 2021 09:34:21 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10099"; a="199679004" X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="199679004" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 02:34:21 -0700 X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="502905529" Received: from ikcrook-mobl.amr.corp.intel.com (HELO [10.213.197.103]) ([10.213.197.103]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 02:34:19 -0700 To: Daniel Vetter Cc: intel-gfx , dri-devel , Tvrtko Ursulin , Chris Wilson , Joonas Lahtinen , Matthew Auld , Eero Tamminen , Rodrigo Vivi References: <20210729133420.770672-1-tvrtko.ursulin@linux.intel.com> <20210729133420.770672-2-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Tue, 7 Sep 2021 10:34:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 07/09/2021 09:42, Daniel Vetter wrote: > On Fri, Sep 03, 2021 at 01:47:52PM +0100, Tvrtko Ursulin wrote: >> >> On 29/07/2021 15:06, Daniel Vetter wrote: >>> On Thu, Jul 29, 2021 at 3:34 PM Tvrtko Ursulin >>> wrote: >>>> >>>> From: Tvrtko Ursulin >>>> >>>> Usage of Transparent Hugepages was disabled in 9987da4b5dcf >>>> ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it >>>> appears majority of performance regressions reported with an enabled IOMMU >>>> can be almost eliminated by turning them on, lets just do that. >>>> >>>> To err on the side of safety we keep the current default in cases where >>>> IOMMU is not active, and only when it is default to the "huge=within_size" >>>> mode. Although there probably would be wins to enable them throughout, >>>> more extensive testing across benchmarks and platforms would need to be >>>> done. >>>> >>>> With the patch and IOMMU enabled my local testing on a small Skylake part >>>> shows OglVSTangent regression being reduced from ~14% (IOMMU on versus >>>> IOMMU off) to ~2% (same comparison but with THP on). >>>> >>>> v2: >>>> * Add Kconfig dependency to transparent hugepages and some help text. >>>> * Move to helper for easier handling of kernel build options. >>>> >>>> v3: >>>> * Drop Kconfig. (Daniel) >>>> >>>> References: b901bb89324a ("drm/i915/gemfs: enable THP") >>>> References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") >>>> References: https://gitlab.freedesktop.org/drm/intel/-/issues/430 >>>> Co-developed-by: Chris Wilson >>>> Signed-off-by: Chris Wilson >>>> Cc: Joonas Lahtinen >>>> Cc: Matthew Auld >>>> Cc: Eero Tamminen >>>> Cc: Tvrtko Ursulin >>>> Cc: Rodrigo Vivi >>>> Cc: Daniel Vetter >>>> Signed-off-by: Tvrtko Ursulin >>>> Reviewed-by: Rodrigo Vivi # v1 >>> >>> On both patches: Acked-by: Daniel Vetter >> >> Eero's testing results at >> https://gitlab.freedesktop.org/drm/intel/-/issues/430 are looking good - >> seem to show this to be a net win for at least Gen9 and Gen12 platforms. >> >> Is the ack enough to merge in this case or I should look for an r-b as well? > > Since your back to defacto v1 with the 2nd patch I think you have full r-b > already. So more than enough I think. Just in case you missed it, v1 had Kconfig. But it's the same spirit so probably indeed fine as you say. > Please do record the relative perf numbers from Eero in that issue in the > commit message so that we have that on the git log record too. It's easier > to find there than following the link and finding the right comment in the > issue. Will do. Regards, Tvrtko