intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Jani Nikula" <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: better backlight & panel abstractions
Date: Wed, 25 Aug 2021 12:13:49 -0000	[thread overview]
Message-ID: <162989362980.17672.2263139169552738551@emeril.freedesktop.org> (raw)
In-Reply-To: <cover.1629888677.git.jani.nikula@intel.com>

== Series Details ==

Series: drm/i915: better backlight & panel abstractions
URL   : https://patchwork.freedesktop.org/series/94004/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
46e4b18ff71c drm/i915/backlight: extract backlight code to a separate file
-:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

-:263: WARNING:LINE_SPACING: Missing a blank line after declarations
#263: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:201:
+	u32 val = intel_de_read(dev_priv, BLC_PWM_PCH_CTL2) & ~BACKLIGHT_DUTY_CYCLE_MASK;
+	intel_de_write(dev_priv, BLC_PWM_PCH_CTL2, val | level);

-:1823: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1823: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:1761:
+		if (connector->base.connector_type == DRM_MODE_CONNECTOR_DSI) {
[...]
+		} else {
[...]

-:1892: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#1892: FILE: drivers/gpu/drm/i915/display/intel_backlight.h:46:
+}
+static inline void intel_backlight_device_unregister(struct intel_connector *connector)

total: 0 errors, 3 warnings, 1 checks, 3769 lines checked
46ca4e1f64e6 drm/i915/backlight: mass rename functions to have intel_backlight_ prefix
-:558: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#558: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:241:
+	panel->backlight.pwm_funcs->disable(conn_state, intel_backlight_invert_pwm_level(connector, 0));

total: 0 errors, 1 warnings, 0 checks, 568 lines checked
65bd1bc02fc9 drm/i915/panel: mass rename functions to have intel_panel_ prefix



  parent reply	other threads:[~2021-08-25 12:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 11:06 [Intel-gfx] [PATCH 0/3] drm/i915: better backlight & panel abstractions Jani Nikula
2021-08-25 11:06 ` [Intel-gfx] [PATCH 1/3] drm/i915/backlight: extract backlight code to a separate file Jani Nikula
2021-08-25 11:06 ` [Intel-gfx] [PATCH 2/3] drm/i915/backlight: mass rename functions to have intel_backlight_ prefix Jani Nikula
2021-08-25 11:06 ` [Intel-gfx] [PATCH 3/3] drm/i915/panel: mass rename functions to have intel_panel_ prefix Jani Nikula
2021-08-25 12:13 ` Patchwork [this message]
2021-08-25 12:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: better backlight & panel abstractions Patchwork
2021-08-25 16:50 ` [Intel-gfx] [PATCH 0/3] " Lyude Paul
2021-08-25 17:36   ` Jani Nikula
2021-08-26  7:48     ` Jani Nikula
2021-08-25 18:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162989362980.17672.2263139169552738551@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).