* [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL
@ 2023-03-31 22:52 John.C.Harrison
2023-03-31 23:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Define GuC firmware version for MTL (rev2) Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: John.C.Harrison @ 2023-03-31 22:52 UTC (permalink / raw)
To: Intel-GFX; +Cc: DRI-Devel
From: John Harrison <John.C.Harrison@Intel.com>
First release of GuC for Meteorlake.
NB: As this is still pre-release and likely to change, use explicit
versioning for now. The official, full release will use reduced
version naming.
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index 264c952f777bb..1ac6f9f340e31 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -79,6 +79,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
* security fixes, etc. to be enabled.
*/
#define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_maj, guc_mmp) \
+ fw_def(METEORLAKE, 0, guc_mmp(mtl, 70, 6, 5)) \
fw_def(DG2, 0, guc_maj(dg2, 70, 5)) \
fw_def(ALDERLAKE_P, 0, guc_maj(adlp, 70, 5)) \
fw_def(ALDERLAKE_P, 0, guc_mmp(adlp, 70, 1, 1)) \
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Define GuC firmware version for MTL (rev2)
2023-03-31 22:52 [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL John.C.Harrison
@ 2023-03-31 23:24 ` Patchwork
2023-04-01 23:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-04-07 0:37 ` [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL Lucas De Marchi
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-03-31 23:24 UTC (permalink / raw)
To: john.c.harrison; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4116 bytes --]
== Series Details ==
Series: drm/i915/mtl: Define GuC firmware version for MTL (rev2)
URL : https://patchwork.freedesktop.org/series/115967/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12952 -> Patchwork_115967v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/index.html
Participating hosts (38 -> 36)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_115967v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][1] -> [DMESG-WARN][2] ([i915#7699])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/bat-dg2-11/igt@i915_selftest@live@migrate.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@slpc:
- bat-adln-1: NOTRUN -> [DMESG-FAIL][3] ([i915#6997])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/bat-adln-1/igt@i915_selftest@live@slpc.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-adln-1: NOTRUN -> [SKIP][4] ([i915#7828])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/bat-adln-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_pm_rps@basic-api:
- bat-dg2-11: [FAIL][5] ([i915#8308]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/bat-dg2-11/igt@i915_pm_rps@basic-api.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/bat-dg2-11/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][7] ([i915#5334]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_lrc:
- bat-adln-1: [INCOMPLETE][9] ([i915#4983] / [i915#7609]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][11] ([i915#6367]) -> [DMESG-FAIL][12] ([i915#6367] / [i915#7996])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/bat-rpls-1/igt@i915_selftest@live@slpc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/bat-rpls-1/igt@i915_selftest@live@slpc.html
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
Build changes
-------------
* Linux: CI_DRM_12952 -> Patchwork_115967v2
CI-20190529: 20190529
CI_DRM_12952: 51cf6fb5e846c1adbe92debb7282d0dcc3934ecb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7231: 94188a1dc91b6ef1cf3e9df1440ff00b6ff25935 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115967v2: 51cf6fb5e846c1adbe92debb7282d0dcc3934ecb @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
3ce988a81b69 drm/i915/mtl: Define GuC firmware version for MTL
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/index.html
[-- Attachment #2: Type: text/html, Size: 4948 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Define GuC firmware version for MTL (rev2)
2023-03-31 22:52 [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL John.C.Harrison
2023-03-31 23:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Define GuC firmware version for MTL (rev2) Patchwork
@ 2023-04-01 23:06 ` Patchwork
2023-04-07 0:37 ` [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL Lucas De Marchi
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-04-01 23:06 UTC (permalink / raw)
To: john.c.harrison; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8914 bytes --]
== Series Details ==
Series: drm/i915/mtl: Define GuC firmware version for MTL (rev2)
URL : https://patchwork.freedesktop.org/series/115967/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12952_full -> Patchwork_115967v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_115967v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][1] -> [ABORT][2] ([i915#5566]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk5/igt@gen9_exec_parse@allowed-all.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/shard-glk5/igt@gen9_exec_parse@allowed-all.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][3] -> [FAIL][4] ([i915#2346])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
#### Possible fixes ####
* igt@gem_eio@in-flight-contexts-1us:
- {shard-tglu}: [TIMEOUT][5] ([i915#3063]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-tglu-9/igt@gem_eio@in-flight-contexts-1us.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/shard-tglu-6/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][7] ([i915#2842]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-apl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [DMESG-FAIL][9] ([i915#5334]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk9/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/shard-glk8/igt@i915_selftest@live@gt_heartbeat.html
- shard-apl: [DMESG-FAIL][11] ([i915#5334]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][13] ([i915#79]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12952/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
Build changes
-------------
* Linux: CI_DRM_12952 -> Patchwork_115967v2
CI-20190529: 20190529
CI_DRM_12952: 51cf6fb5e846c1adbe92debb7282d0dcc3934ecb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7231: 94188a1dc91b6ef1cf3e9df1440ff00b6ff25935 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115967v2: 51cf6fb5e846c1adbe92debb7282d0dcc3934ecb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115967v2/index.html
[-- Attachment #2: Type: text/html, Size: 5201 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL
2023-03-31 22:52 [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL John.C.Harrison
2023-03-31 23:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Define GuC firmware version for MTL (rev2) Patchwork
2023-04-01 23:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-04-07 0:37 ` Lucas De Marchi
2023-04-07 9:45 ` Rodrigo Vivi
2 siblings, 1 reply; 6+ messages in thread
From: Lucas De Marchi @ 2023-04-07 0:37 UTC (permalink / raw)
To: John.C.Harrison; +Cc: Intel-GFX, DRI-Devel, Rodrigo Vivi
On Fri, Mar 31, 2023 at 03:52:16PM -0700, John.C.Harrison@Intel.com wrote:
>From: John Harrison <John.C.Harrison@Intel.com>
>
>First release of GuC for Meteorlake.
>
>NB: As this is still pre-release and likely to change, use explicit
>versioning for now. The official, full release will use reduced
>version naming.
>
>Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Applied to topic/core-for-CI with acks by Rodrigo and Tvrtko.
Reference issue: https://gitlab.freedesktop.org/drm/intel/-/issues/8343
Going forward we should plan to have these kind of patches in
drm-intel-gt-next itself rather than using the CI branch. The CI branch
is not the proper place.
To be clear, since MTL is under force probe and not normally enabled,
it's ok to bump the major version without retaining compabibility with
the previous version, as per
https://docs.kernel.org/driver-api/firmware/firmware-usage-guidelines.html
I think the main blocker right now to use drm-intel-gt-next would be
because MODULE_FIRMWARE() is unaware of force_probe. Then distros
would start getting a warning when creating their initrd that they may
have missed a firmware. But that firmware itself is not present in the
upstream linux-firmware repo. We can think about a way to hide the fw
def for *new* firmware (not the legacy ones) that are using the mmp
version.
For now, let's keep this as is and use the CI branch to assess the
driver health with GuC.
thanks
Lucas De Marchi
>---
> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>index 264c952f777bb..1ac6f9f340e31 100644
>--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>@@ -79,6 +79,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
> * security fixes, etc. to be enabled.
> */
> #define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_maj, guc_mmp) \
>+ fw_def(METEORLAKE, 0, guc_mmp(mtl, 70, 6, 5)) \
> fw_def(DG2, 0, guc_maj(dg2, 70, 5)) \
> fw_def(ALDERLAKE_P, 0, guc_maj(adlp, 70, 5)) \
> fw_def(ALDERLAKE_P, 0, guc_mmp(adlp, 70, 1, 1)) \
>--
>2.39.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL
2023-04-07 0:37 ` [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL Lucas De Marchi
@ 2023-04-07 9:45 ` Rodrigo Vivi
2023-04-07 13:47 ` Lucas De Marchi
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2023-04-07 9:45 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: Intel-GFX, DRI-Devel
On Thu, Apr 06, 2023 at 05:37:58PM -0700, Lucas De Marchi wrote:
> On Fri, Mar 31, 2023 at 03:52:16PM -0700, John.C.Harrison@Intel.com wrote:
> > From: John Harrison <John.C.Harrison@Intel.com>
> >
> > First release of GuC for Meteorlake.
> >
> > NB: As this is still pre-release and likely to change, use explicit
> > versioning for now. The official, full release will use reduced
> > version naming.
> >
> > Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>
> Applied to topic/core-for-CI with acks by Rodrigo and Tvrtko.
> Reference issue: https://gitlab.freedesktop.org/drm/intel/-/issues/8343
>
> Going forward we should plan to have these kind of patches in
> drm-intel-gt-next itself rather than using the CI branch. The CI branch
> is not the proper place.
>
> To be clear, since MTL is under force probe and not normally enabled,
> it's ok to bump the major version without retaining compabibility with
> the previous version, as per
> https://docs.kernel.org/driver-api/firmware/firmware-usage-guidelines.html
>
>
> I think the main blocker right now to use drm-intel-gt-next would be
> because MODULE_FIRMWARE() is unaware of force_probe. Then distros
> would start getting a warning when creating their initrd that they may
> have missed a firmware. But that firmware itself is not present in the
> upstream linux-firmware repo. We can think about a way to hide the fw
> def for *new* firmware (not the legacy ones) that are using the mmp
> version.
Maybe we should simply move to the final version path sooner than later?
Even if that means more updates in the blobs at linux-firmware.git, that
would allow the OSVs to have this final patch sooner in their trees.
>
> For now, let's keep this as is and use the CI branch to assess the
> driver health with GuC.
>
>
> thanks
> Lucas De Marchi
>
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> > index 264c952f777bb..1ac6f9f340e31 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> > @@ -79,6 +79,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
> > * security fixes, etc. to be enabled.
> > */
> > #define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_maj, guc_mmp) \
> > + fw_def(METEORLAKE, 0, guc_mmp(mtl, 70, 6, 5)) \
> > fw_def(DG2, 0, guc_maj(dg2, 70, 5)) \
> > fw_def(ALDERLAKE_P, 0, guc_maj(adlp, 70, 5)) \
> > fw_def(ALDERLAKE_P, 0, guc_mmp(adlp, 70, 1, 1)) \
> > --
> > 2.39.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL
2023-04-07 9:45 ` Rodrigo Vivi
@ 2023-04-07 13:47 ` Lucas De Marchi
0 siblings, 0 replies; 6+ messages in thread
From: Lucas De Marchi @ 2023-04-07 13:47 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Intel-GFX, DRI-Devel
On Fri, Apr 07, 2023 at 05:45:52AM -0400, Rodrigo Vivi wrote:
>On Thu, Apr 06, 2023 at 05:37:58PM -0700, Lucas De Marchi wrote:
>> On Fri, Mar 31, 2023 at 03:52:16PM -0700, John.C.Harrison@Intel.com wrote:
>> > From: John Harrison <John.C.Harrison@Intel.com>
>> >
>> > First release of GuC for Meteorlake.
>> >
>> > NB: As this is still pre-release and likely to change, use explicit
>> > versioning for now. The official, full release will use reduced
>> > version naming.
>> >
>> > Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>>
>> Applied to topic/core-for-CI with acks by Rodrigo and Tvrtko.
>> Reference issue: https://gitlab.freedesktop.org/drm/intel/-/issues/8343
>>
>> Going forward we should plan to have these kind of patches in
>> drm-intel-gt-next itself rather than using the CI branch. The CI branch
>> is not the proper place.
>>
>> To be clear, since MTL is under force probe and not normally enabled,
>> it's ok to bump the major version without retaining compabibility with
>> the previous version, as per
>> https://docs.kernel.org/driver-api/firmware/firmware-usage-guidelines.html
>>
>>
>> I think the main blocker right now to use drm-intel-gt-next would be
>> because MODULE_FIRMWARE() is unaware of force_probe. Then distros
>> would start getting a warning when creating their initrd that they may
>> have missed a firmware. But that firmware itself is not present in the
>> upstream linux-firmware repo. We can think about a way to hide the fw
>> def for *new* firmware (not the legacy ones) that are using the mmp
>> version.
>
>Maybe we should simply move to the final version path sooner than later?
>
>Even if that means more updates in the blobs at linux-firmware.git, that
>would allow the OSVs to have this final patch sooner in their trees.
it doesn't help much OSVs: the firmware being used here is the full
version, not the major-only version. And if we commit this firmware
with the major-only version, there is a chance the distro will update
the kernel without updating the firmware and we will have the wrong
firmware there, one that is not supposed to be used.
Also, if we commit all the "temporary" versions in the linux-firmware.git
repo, we may start to blow up its size. I'm not sure this is a best
practice for HW that is not available to the general public.
Options I see for future:
1)
a) keep these temporary fw in our drm-firmware repo;
b) hide the fw def under a kconfig
2)
a) accept this kind o changes in the CI branch
3)
a) commit to linux-firmware.git, knowing this is not a version
that will be generally used
b) commit to kernel in the usual way
Any other?
Note that this also impacts xe. Right now xe is not merged upstream,
so this is just ignored: there we have already the firmware version
for MTL and for PVC in the kernel. Eventually we will need a similar
mechanism though, so better we agree upfront what that is.
Lucas De Marchi
>
>>
>> For now, let's keep this as is and use the CI branch to assess the
>> driver health with GuC.
>>
>>
>> thanks
>> Lucas De Marchi
>>
>> > ---
>> > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>> > index 264c952f777bb..1ac6f9f340e31 100644
>> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>> > @@ -79,6 +79,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
>> > * security fixes, etc. to be enabled.
>> > */
>> > #define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_maj, guc_mmp) \
>> > + fw_def(METEORLAKE, 0, guc_mmp(mtl, 70, 6, 5)) \
>> > fw_def(DG2, 0, guc_maj(dg2, 70, 5)) \
>> > fw_def(ALDERLAKE_P, 0, guc_maj(adlp, 70, 5)) \
>> > fw_def(ALDERLAKE_P, 0, guc_mmp(adlp, 70, 1, 1)) \
>> > --
>> > 2.39.1
>> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-07 13:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-31 22:52 [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL John.C.Harrison
2023-03-31 23:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Define GuC firmware version for MTL (rev2) Patchwork
2023-04-01 23:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-04-07 0:37 ` [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL Lucas De Marchi
2023-04-07 9:45 ` Rodrigo Vivi
2023-04-07 13:47 ` Lucas De Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).