From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_ctx_persistence: Race context closure with replace-engines
Date: Thu, 13 Feb 2020 11:02:09 +0000 [thread overview]
Message-ID: <17dd2eef-40c1-0bfc-299f-ced610de0681@linux.intel.com> (raw)
In-Reply-To: <158158749815.11180.3098367349420655936@skylake-alporthouse-com>
On 13/02/2020 09:51, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-02-13 09:07:59)
>>
>> On 11/02/2020 19:22, Chris Wilson wrote:
>>> + igt_until_timeout(5) {
>>> + igt_spin_t *spin;
>>> + uint32_t ctx;
>>> +
>>> + ctx = gem_context_clone_with_engines(i915, 0);
>>> + gem_context_set_persistence(i915, ctx, true);
>>> +
>>> + spin = igt_spin_new(i915, ctx, .flags = IGT_SPIN_FENCE_OUT);
>>> + for (int i = 0; i < ncpus; i++)
>>> + write(t[i].pipe[1], &ctx, sizeof(ctx));
>>
>> It's early so I hope I am not too confused, but drm client in the forked
>> process is a different one. So I think it needs to use threads to be
>> able to share.
>
> It using the same fd, so the children have control over the parents ctx
> (and shares the ctx id space via the fd)
It was too early then.
Then with a more neutral comment:
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-13 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 19:22 [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_persistence: Race context closure with replace-engines Chris Wilson
2020-02-11 20:13 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson
2020-02-12 11:11 ` [Intel-gfx] ✗ GitLab.Pipeline: failure for " Patchwork
2020-02-12 11:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-13 9:07 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2020-02-13 9:51 ` Chris Wilson
2020-02-13 11:02 ` Tvrtko Ursulin [this message]
2020-02-14 3:27 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17dd2eef-40c1-0bfc-299f-ced610de0681@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).