From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: split irq handling into per-chipset functions
Date: Thu, 07 Apr 2011 23:13:44 +0100 [thread overview]
Message-ID: <1bdc18$k56odl@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20110407150414.4dc8a951@jbarnes-desktop>
On Thu, 7 Apr 2011 15:04:14 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Thu, 07 Apr 2011 22:50:42 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > One thing we need to be careful is to move the common code into small
> > helper routines to avoid unnecessarily duplicating it.
>
> But not before we're sure about the duplication! Obviously things like
> the workqueue init at IRQ install time could be shared,
Actually that workqueue init is in the wrong place entirely, but that
was the sort of generic code I was looking at. ;-)
> but I don't
> like the idea of sharing hardware code unless it's absolutely
> identical, given our history.
Agreed, I think the model you've proposed of doing bring-up on a separate
copy of the code and then gradually merge back the duplicate portions
carries the least risk. Also looking at our history, we carry a lot of
bugs that we only notice when looking at the next chipset iteration...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-07 22:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 21:32 (no subject) Jesse Barnes
2011-04-07 21:32 ` [PATCH 1/3] drm/i915: make FDI training a display function Jesse Barnes
2011-04-20 14:45 ` Ben Widawsky
2011-04-20 15:16 ` Jesse Barnes
2011-04-07 21:32 ` [PATCH 2/3] drm/i915: split irq handling into per-chipset functions Jesse Barnes
2011-04-07 21:50 ` Chris Wilson
2011-04-07 22:04 ` Jesse Barnes
2011-04-07 22:13 ` Chris Wilson [this message]
2011-04-07 21:33 ` [PATCH 3/3] drm/i915: split enable/disable vblank code into chipset specific functions Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1bdc18$k56odl@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).