From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 0/3] implement multiple ring buffer V1 Date: Wed, 19 May 2010 19:26:01 +0200 Message-ID: <20100519172600.GC3537@viiv.ffwll.ch> References: <1274261608-21026-1-git-send-email-nanhai.zou@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.ffwll.ch (cable-static-49-187.intergga.ch [157.161.49.187]) by gabe.freedesktop.org (Postfix) with ESMTP id 92F799E740 for ; Wed, 19 May 2010 10:25:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1274261608-21026-1-git-send-email-nanhai.zou@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zou Nan hai Cc: intel-gfx , Anholt Eric List-Id: intel-gfx@lists.freedesktop.org On Wed, May 19, 2010 at 05:33:28PM +0800, Zou Nan hai wrote: > The patch series try to abstruct ring buffer > structure, implement BSD (bit stream decoder) ring > buffer for H.264/VC1 VLD decoding. > > I mark this as V1 for review. Woot, we're (slowly) getting there. I'll do an in-depth review some when later this week (running short on free time, atm). On a quick look, the series has definitely improved. One nitpick up-front: You haven't sent the individual patches as follow-ups to the introduction email. Just use git format-patch and git send-email, they'll take care of all the boring details for you. Quick primer, if you're totally lazy: $ git format-patch --cover-letter -o output_directory revision_range creates a bunch of .patch files including introduction letter with the commits int the given range. You only have to change the subject & text of the cover letter. Then $ git send-email --to 'bla@bla.com' --cc 'foo@bar.com' *.patch [--dry-run] sends them away. Use --dry-run to check first that git does the right thing with your patches. Yours, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48