Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Alexey Fisher <bug-track@fisher-privat.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [regression] drm/i915: cleanup per-pipe reg usage
Date: Thu, 17 Feb 2011 10:32:59 -0800
Message-ID: <20110217103259.4dd6caf6@jbarnes-desktop> (raw)
In-Reply-To: <1297927580.3349.2.camel@mini>

On Thu, 17 Feb 2011 08:26:20 +0100
Alexey Fisher <bug-track@fisher-privat.net> wrote:

> Am Mittwoch, den 16.02.2011, 10:57 -0800 schrieb Jesse Barnes:
> > On Sat, 12 Feb 2011 22:02:36 +0100
> > Alexey Fisher <bug-track@fisher-privat.net> wrote:
> > 
> > > In attachment are reg_dumps.
> > > 
> > > intel_1 - is gdm login screen, every thing is ok
> > > intel_2 - is after login, noise
> > > intel_3 - is after mouse pointer was placed to the upper left corner,
> > > image is ok again.
> > > 
> > > Am Samstag, den 12.02.2011, 18:09 +0000 schrieb Chris Wilson:
> > > > 
> > > > On Sat, 12 Feb 2011 15:16:16 +0100, Alexey Fisher
> > > > <bug-track@fisher-privat.net> wrote:
> > > > > Video is in attachment.
> > > > > 
> > > > > If mouse pointer is on the left top corner i get still image .. if
> > > > not -
> > > > > noise.
> > > > 
> > > > I think intel_reg_dumper before/after will be the best guide as to
> > > > where
> > > > the mistake crept in.
> > > > -Chris
> > 
> > Also, seeing the kernel messages from a clean boot after setting
> > drm.debug=4 would help; they'll tell us what FIFO watermarks we used
> > and might help me track down the flicker.
> 
> the bad files are from version 2.6.38-rc2-00090-g9db4a9c
> the good are 2.6.38-rc2-00079-g4a1dc3f

Hm watermarks actually look good, but the cursor b control reg is
different for some reason.

Oops, I see a problem.  Does this patch help?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_d
index 0dc5c6f..7bab2ef 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5291,7 +5291,7 @@ static void i9xx_update_cursor(struct drm_crtc *crtc, u32 
        bool visible = base != 0;
 
        if (intel_crtc->cursor_visible != visible) {
-               uint32_t cntl = CURCNTR(pipe);
+               uint32_t cntl = I915_READ(CURCNTR(pipe));
                if (base) {
                        cntl &= ~(CURSOR_MODE | MCURSOR_PIPE_SELECT);
                        cntl |= CURSOR_MODE_64_ARGB_AX | MCURSOR_GAMMA_ENABLE;

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 20:59 Alexey Fisher
     [not found] ` <1297520176.10989.1.camel@zwerg>
     [not found]   ` <b9dded$hu5fo8@orsmga002.jf.intel.com>
2011-02-12 21:02     ` Alexey Fisher
2011-02-16 18:42       ` Jesse Barnes
2011-02-16 18:57       ` Jesse Barnes
2011-02-17  7:26         ` Alexey Fisher
2011-02-17 18:32           ` Jesse Barnes [this message]
2011-02-17 20:54             ` Alexey Fisher
2011-02-17 21:09               ` Jesse Barnes
2011-02-17 21:24                 ` Alexey Fisher
2011-02-17 21:26                   ` Alexey Fisher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110217103259.4dd6caf6@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=bug-track@fisher-privat.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git