From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Disable all outputs early, before KMS takeover Date: Fri, 1 Apr 2011 13:44:30 +0200 Message-ID: <20110401114429.GA3526@viiv.ffwll.ch> References: <1301395589-8121-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.ffwll.ch (cable-static-216-94.intergga.ch [87.102.216.94]) by gabe.freedesktop.org (Postfix) with ESMTP id CE2099E773 for ; Fri, 1 Apr 2011 04:44:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1301395589-8121-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Pekka Enberg , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 29, 2011 at 11:46:29AM +0100, Chris Wilson wrote: > If the outputs are active and continuing to access the GATT when we > teardown the PTEs, then there is a potential for us to hang the GPU. > The hang tends to be a PGTBL_ER with either an invalid host access or > an invalid display plane fetch. This patch seems to fix resume flakiness (that recently developed complete reliability in hanging the gpu) on my i855gm. Captured error_states look as described here. Latest -staging merged into latest -linus is now again fully reliable at s/r. Tested-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48