From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 15/30] drm/i915: Rename agp_type to cache_level Date: Wed, 13 Apr 2011 17:57:19 +0200 Message-ID: <20110413155717.GA3660@viiv.ffwll.ch> References: <1302640318-23165-1-git-send-email-chris@chris-wilson.co.uk> <1302640318-23165-16-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 005FE9F105 for ; Wed, 13 Apr 2011 08:57:29 -0700 (PDT) Received: by wwb17 with SMTP id 17so729589wwb.12 for ; Wed, 13 Apr 2011 08:57:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302640318-23165-16-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 12, 2011 at 09:31:43PM +0100, Chris Wilson wrote: > ... to clarify just how we use it inside the driver. We still need to > translate through agp_type for interface into the fake AGP driver. I've been slightly uneasy with mixing gen6+ llc with pre-snb snooped mem. But Chris convinced me on irc that the cache handling should be identical, so no difference for the kernel. hw hates us and we'll probably regret this, but who cares. So Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48