From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 17/30] drm/i915: Do not clflush snooped objects Date: Wed, 13 Apr 2011 18:04:38 +0200 Message-ID: <20110413160437.GC3660@viiv.ffwll.ch> References: <1302640318-23165-1-git-send-email-chris@chris-wilson.co.uk> <1302640318-23165-18-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A7A89F029 for ; Wed, 13 Apr 2011 09:04:43 -0700 (PDT) Received: by wwb17 with SMTP id 17so737443wwb.12 for ; Wed, 13 Apr 2011 09:04:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302640318-23165-18-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 12, 2011 at 09:31:45PM +0100, Chris Wilson wrote: > + /* If the GPU is snooping the contents of the CPU cache, > + * we do not need to clear the CPU cache lines. Instead we need > + * to be sure to flush/invalidate the RENDER cache when the contents > + * must be refreshed. > + */ The "Instead we need to be sure to flush the RENDER cache ..." is a bit confusing to me: There's no instead, we have to do this always when writing with the cpu. Besides this minor comment-nitpick it makes sense. Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48