From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 24/30] drm/i915: Refactor pwrite/pread to use single copy of get_user_pages Date: Wed, 13 Apr 2011 21:26:24 +0200 Message-ID: <20110413192623.GG3660@viiv.ffwll.ch> References: <1302640318-23165-1-git-send-email-chris@chris-wilson.co.uk> <1302640318-23165-25-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id B5B749E93D for ; Wed, 13 Apr 2011 12:26:29 -0700 (PDT) Received: by wwb17 with SMTP id 17so936674wwb.12 for ; Wed, 13 Apr 2011 12:26:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302640318-23165-25-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 12, 2011 at 09:31:52PM +0100, Chris Wilson wrote: > Replace the three nearly identical copies of the code with a single > function. And take advantage of the opportunity to do some > micro-optimisation: avoid the vmalloc if at all possible and also avoid > dropping the lock unless we are forced to acquire the mm semaphore. One tiny nitpick: Perhaps put an api comment at the top of gem_get_user_pages that this function drops the struct_mutex. That's not something we normally do and could cause endless amounts of fun if neglected. Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48