From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 27/30] drm/i915: Invalidate fenced read domains upon flush Date: Wed, 13 Apr 2011 21:43:59 +0200 Message-ID: <20110413194357.GI3660@viiv.ffwll.ch> References: <1302640318-23165-1-git-send-email-chris@chris-wilson.co.uk> <1302640318-23165-28-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 677729E93D for ; Wed, 13 Apr 2011 12:44:04 -0700 (PDT) Received: by wyb28 with SMTP id 28so1011728wyb.36 for ; Wed, 13 Apr 2011 12:44:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302640318-23165-28-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 12, 2011 at 09:31:55PM +0100, Chris Wilson wrote: > Whenever we finish reading an object through a fence, for safety we > clear any GPU read domain and so invalidate any TLBs associated with > the fenced region upon its next use. Now that flush_fence ensures that we are paranoid and flush/invalidate caches the if (fenced_gpu_access && !pending_fenced_gpu_access) flush_some_more(); code is indeed superfluous. But please explain that in the changelog, it has taken me a while to (re-)figure out while the second hunk is correct. Otherwise > Reviewed-by: Daniel Vetter still stands. -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48