From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Prevent mmap access through the GTT of snooped pages Date: Wed, 13 Apr 2011 22:51:55 +0200 Message-ID: <20110413205154.GN3660@viiv.ffwll.ch> References: <20110413191323.GE3660@viiv.ffwll.ch> <1302726410-14906-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id D2FF39E9F1 for ; Wed, 13 Apr 2011 13:52:00 -0700 (PDT) Received: by wyb28 with SMTP id 28so1075498wyb.36 for ; Wed, 13 Apr 2011 13:51:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302726410-14906-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 13, 2011 at 09:26:50PM +0100, Chris Wilson wrote: > The docs have a dire warning not to attempt to access snooped pages > through the GTT. Prevent userspace from doing so by sending them a > SIGBUS if they try. > > [Now it is possible with a bit of extra complexity to map the snooped > CPU page into the vma and return that through i915_gem_fault() instead. > The question is: is it simpler to do that workaround in the kernel than > it is to do it in userspace?] Woohoo! Evasive scary-patch-review-in-sight maneuver successfully accomplished! Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48