From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 16/21] drm/i915: Retire requests before disabling pagefaults Date: Sat, 16 Apr 2011 15:44:57 +0200 Message-ID: <20110416134456.GE3498@viiv.ffwll.ch> References: <1302945465-32115-1-git-send-email-chris@chris-wilson.co.uk> <1302945465-32115-17-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id B3CDB9E7A4 for ; Sat, 16 Apr 2011 06:45:02 -0700 (PDT) Received: by wwb17 with SMTP id 17so3482883wwb.12 for ; Sat, 16 Apr 2011 06:45:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302945465-32115-17-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Apr 16, 2011 at 10:17:40AM +0100, Chris Wilson wrote: > As we cannot wait upon an object to be released by the GPU once we have > disabled pagefaults, process any pending retirements first in the hope > that we move any potential relocations off the active list. I have a hard time believing how one could emit relocs to active objects ... I suspect it is partially a cache thing: Retire stuff while the gem_objects are sitting in L1 cache anyway can't hurt. So Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48