From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/8] drm/i915/dp: retry link status read 3 times on failure
Date: Wed, 6 Jul 2011 09:09:23 -0700 [thread overview]
Message-ID: <20110706090923.75116463@jbarnes-desktop> (raw)
In-Reply-To: <87wrfwdoeg.fsf@eliezer.anholt.net>
On Tue, 05 Jul 2011 21:27:35 -0700
Eric Anholt <eric@anholt.net> wrote:
> On Fri, 1 Jul 2011 15:22:51 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Especially after a hotplug or power status change, the sink may not
> > reply immediately to a link status query. So retry 3 times per the spec
> > to really make sure nothing is there.
>
> One thing we've been trying to do increasingly on the 3D side is cite
> chapter and verse in comments when we're doing something "per the spec"
> (which spec here?). Clarifies whether it was some crazy workaround
> copying what the BIOS did at one point vs. something that we really are
> supposed to do.
Yeah good point, I'll point at the DP spec section stuff here when I
re-post.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-07-06 16:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 22:22 [RFC] misc DP fixes/changes Jesse Barnes
2011-07-01 22:22 ` [PATCH 1/8] drm/i915/dp: retry link status read 3 times on failure Jesse Barnes
2011-07-01 23:41 ` Keith Packard
2011-07-01 23:47 ` Jesse Barnes
2011-07-06 4:27 ` Eric Anholt
2011-07-06 16:09 ` Jesse Barnes [this message]
2011-07-01 22:22 ` [PATCH 2/8] drm/i915/dp: use DP DPCD defines when looking at DPCD values Jesse Barnes
2011-07-01 23:43 ` Keith Packard
2011-07-01 22:22 ` [PATCH 3/8] drm/i915/dp: read more receiver capability bits on hotplug Jesse Barnes
2011-07-01 23:45 ` Keith Packard
2011-07-01 22:22 ` [PATCH 4/8] drm/i915/dp: try to read receiver capabilities 3 times when detecting Jesse Barnes
2011-07-01 23:45 ` Keith Packard
2011-07-01 22:22 ` [PATCH 5/8] drm/i915/dp: set DP DPMS mode to "on" in ->commit Jesse Barnes
2011-07-01 23:46 ` Keith Packard
2011-07-01 22:22 ` [PATCH 6/8] drm/i915/dp: clear DP encoder CRTC if the receiver disappears Jesse Barnes
2011-07-01 23:48 ` Keith Packard
2011-07-01 23:59 ` Jesse Barnes
2011-07-02 0:31 ` Keith Packard
2011-07-01 22:22 ` [PATCH 7/8] drm/i915/dp: rename dpms_mode to receiver_configured Jesse Barnes
2011-07-01 23:50 ` Keith Packard
2011-07-01 22:22 ` [PATCH 8/8] drm/i915/dp: clear receiver_configured when link training fails Jesse Barnes
2011-07-01 23:51 ` Keith Packard
2011-07-01 23:39 ` [RFC] misc DP fixes/changes Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706090923.75116463@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).