Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Konstantin Belousov <kostikbel@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel-gfx <Intel-gfx@lists.freedesktop.org>
Subject: Re: i915_chipset_val()
Date: Fri, 8 Jul 2011 15:24:34 +0300
Message-ID: <20110708122434.GW48734@deviant.kiev.zoral.com.ua> (raw)
In-Reply-To: <d08817$n6lv6@azsmga001.ch.intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 2424 bytes --]

On Fri, Jul 08, 2011 at 10:42:02AM +0100, Chris Wilson wrote:
> On Fri, 8 Jul 2011 12:26:51 +0300, Konstantin Belousov <kostikbel@gmail.com> wrote:
> > i915_chipset_val saves the jiffies count of the invocation in last_time1.
> > Then, on the next call, the diff between current jiffies value and
> > last_time1 is used as divisor.
> > 
> > I have a suspicious that two rapid calls to i915_chipset_val() may result
> > in division by zero. This looks as user-controllable action, since
> > debugfs, if configured, would export i915_chipset_val() as emon status.
> > 
> > I did not tested the Linux, but in the (ported) code I am able to get
> > into the described situation. As a workaround, I cached the previous
> > return value from i915_chipset_val() and return it instead of doing
> > the calculation if consequtive calls are close enough.
> > 
> > What do you think ? (patch is not directly applicable to Linux).
> 
> You're right. But I would go even further and say that if the difference
> is less than say 10ms then we have not accumulated enough samples for the
> calculation to be stable.
> 
> >  unsigned long i915_mch_val(struct drm_i915_private *dev_priv)
> > diff --git a/sys/dev/drm/i915_drv.h b/sys/dev/drm/i915_drv.h
> > index 5e6340b..36d066a 100644
> > --- a/sys/dev/drm/i915_drv.h
> > +++ b/sys/dev/drm/i915_drv.h
> > @@ -579,6 +579,7 @@ typedef struct drm_i915_private {
> >  
> >  	u64 last_count1;
> >  	unsigned long last_time1;
> > +	unsigned long last_chipset_val;
> >  	u64 last_count2;
> >  	struct timespec last_time2;
> >  	unsigned long gfx_power;
> 
> We need to thank Jesse for such informative variable names. Not even a
> comment to mention that they are part of IPS.

I agree, I did the following, relative to the previous patch

diff --git a/sys/dev/drm/i915_dma.c b/sys/dev/drm/i915_dma.c
index 773a171..07100f4 100644
--- a/sys/dev/drm/i915_dma.c
+++ b/sys/dev/drm/i915_dma.c
@@ -1592,9 +1592,9 @@ unsigned long i915_chipset_val(struct drm_i915_private *dev_priv)
 	 * sysctl(8) reads the value of sysctl twice in rapid
 	 * succession.  There is high chance that it happens in the
 	 * same timer tick.  Use the cached value to not divide by
-	 * zero.
+	 * zero and give the hw a chance to gather more samples.
 	 */
-	if (diff1 == 0)
+	if (diff1 <= 10)
 		return (dev_priv->last_chipset_val);
 
 	count1 = I915_READ(DMIEC);

[-- Attachment #1.2: Type: application/pgp-signature, Size: 196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08  9:26 i915_chipset_val() Konstantin Belousov
2011-07-08  9:42 ` i915_chipset_val() Chris Wilson
2011-07-08 12:24   ` Konstantin Belousov [this message]
2011-07-08 14:21     ` i915_chipset_val() Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110708122434.GW48734@deviant.kiev.zoral.com.ua \
    --to=kostikbel@gmail.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git