From: Ben Widawsky <ben@bwidawsk.net>
To: Eric Anholt <eric@anholt.net>
Cc: mesa-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 04/10] i965: setup system routine
Date: Tue, 19 Jul 2011 04:48:50 +0000 [thread overview]
Message-ID: <20110719044850.GA29993@cloud01> (raw)
In-Reply-To: <874o2jjvtm.fsf@eliezer.anholt.net>
[-- Attachment #1.1: Type: text/plain, Size: 930 bytes --]
On Mon, Jul 18, 2011 at 11:19:17AM -0700, Eric Anholt wrote:
> On Sun, 17 Jul 2011 16:25:42 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > Upload the system routine as part of the invariant state if debugging.
> >
> > Remove SIP setting if not debugging to make it more friendly for others
> > that may be debugging shaders or media kernels.
> >
> > v2: removed comment per Chris
>
> This patch doesn't really make sense to me. Nothing good will come of
> my driver's buffer execution landing inside someone else's debug kernel,
> right? So why should my driver's batchbuffer be leaving their SIP in
> place?
Yeah you're right. Furthermore, the default value should be 0, which should be
all good all around. Initially I was trying to do something fancier here,
detecting when the SIP has been changed external to mesa, but I gave up on
that.
I will remove the condition and always set sip.
Ben
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-07-19 4:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 23:25 [PATCH 00/10] fs debugging: incorporated Chris' feedback Ben Widawsky
2011-07-17 23:25 ` [PATCH 01/10] intel: shared header for shader debugging Ben Widawsky
2011-07-17 23:25 ` [PATCH 02/10] i965: copy in system routine, reserve extra scratch Ben Widawsky
2011-07-17 23:25 ` [PATCH 03/10] i965: Reserve scratch space for debugger communication Ben Widawsky
2011-07-17 23:25 ` [PATCH 04/10] i965: setup system routine Ben Widawsky
2011-07-18 18:19 ` [Intel-gfx] " Eric Anholt
2011-07-19 4:48 ` Ben Widawsky [this message]
2011-07-17 23:25 ` [PATCH 05/10] i965: emit breakpoints Ben Widawsky
2011-07-17 23:25 ` [PATCH 06/10] i965: attach to a listening debugger Ben Widawsky
2011-07-17 23:25 ` [PATCH 07/10] intel-gpu-tools: register range handling for forcewake hooks Ben Widawsky
2011-07-17 23:25 ` [PATCH 08/10] intel-gpu-tools/forcewaked: sample forcewake app Ben Widawsky
2011-07-17 23:25 ` [PATCH 09/10] debugging: add important debug regs Ben Widawsky
2011-07-17 23:25 ` [PATCH 10/10] debugging: shader debugging Ben Widawsky
-- strict thread matches above, loose matches on Subject: below --
2011-07-13 20:51 [PATCH 0/10] fs " Ben Widawsky
2011-07-13 20:51 ` [PATCH 04/10] i965: setup system routine Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719044850.GA29993@cloud01 \
--to=ben@bwidawsk.net \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mesa-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).