intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: don't set unpin_work if vblank_get fails
Date: Mon, 29 Aug 2011 09:44:52 -0700	[thread overview]
Message-ID: <20110829094452.7a5adf03@jbarnes-desktop> (raw)
In-Reply-To: <20110822110531.57d85c32@jbarnes-desktop>

On Mon, 22 Aug 2011 11:05:31 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> This fixes a race where we may try to finish a page flip and decrement
> the refcount even if our vblank_get failed and we ended up with a
> spurious flip pending interrupt.
> 
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=34211.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Updated patch.  Though now I've lost track of the outstanding
issues...  IIRC we still have another race here, but it's unrelated to
the one in the bug report.

Jesse

  parent reply	other threads:[~2011-08-29 16:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 18:05 [PATCH] drm/i915: don't set unpin_work if vblank_get fails Jesse Barnes
2011-08-22 18:45 ` Keith Packard
2011-08-29 16:44 ` Jesse Barnes [this message]
2011-08-29 16:45   ` Jesse Barnes
2011-09-20  4:04     ` Keith Packard
2011-11-11 20:36       ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829094452.7a5adf03@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).