From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/7] drm: Fill in more of the DisplayPort
 DPCD registers
Date: Tue, 17 Jan 2012 17:07:20 +0100
Message-ID: <20120117160720.GO4093@phenom.ffwll.local>
References: <1310506685-855-1-git-send-email-ajax@redhat.com>
	<1310506685-855-2-git-send-email-ajax@redhat.com>
	<yund3hfjf3w.fsf@aiko.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 69770A0220
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Jan 2012 08:07:25 -0800 (PST)
Received: by wibhq15 with SMTP id hq15so3746545wib.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Jan 2012 08:07:24 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <yund3hfjf3w.fsf@aiko.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>, Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jul 12, 2011 at 03:42:11PM -0700, Keith Packard wrote:
> On Tue, 12 Jul 2011 17:37:59 -0400, Adam Jackson <ajax@redhat.com> wrote:
> > Signed-off-by: Adam Jackson <ajax@redhat.com>
> 
> > +# define DP_DWN_STRM_PORT_TYPE_TMDS	    (2 << 1)
> 
> This could be labeled TYPE_DVI_OR_HDMI according to the DP 1.1a spec.
> 
> > -
> 
> I find the blank lines useful in this file; they separate lists of
> values for different fields.
> 
> 
> > -#define DP_INTERLANE_ALIGN_DONE		    (1 << 0)
> > -#define DP_DOWNSTREAM_PORT_STATUS_CHANGED   (1 << 6)
> > -#define DP_LINK_STATUS_UPDATED		    (1 << 7)
> > +# define DP_INTERLANE_ALIGN_DONE	    (1 << 0)
> > +# define DP_DOWNSTREAM_PORT_STATUS_CHANGED  (1 << 6)
> > +# define DP_LINK_STATUS_UPDATED		    (1 << 7)
> >  
> >  #define DP_SINK_STATUS			    0x205
> > -
> > -#define DP_RECEIVE_PORT_0_STATUS	    (1 << 0)
> > -#define DP_RECEIVE_PORT_1_STATUS	    (1 << 1)
> > +# define DP_RECEIVE_PORT_0_STATUS	    (1 << 0)
> > +# define DP_RECEIVE_PORT_1_STATUS	    (1 << 1)
> >  
> >  #define DP_ADJUST_REQUEST_LANE0_1	    0x206
> >  #define DP_ADJUST_REQUEST_LANE2_3	    0x207
> 
> Please make a separate patch for whitespace cleanups...
> 
> Otherwise, these changes all match the DP 1.1a spec that I compared them
> with.
> 
> Reviewed-by: Keith Packard <keithp@keithp.com>

Noticed this one here while going through list archives. Doesn't apply
properly anymore though. Adam, Dave?
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48