From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: clear up backlight inversion
 confusion on gen4
Date: Mon, 23 Apr 2012 14:21:20 +0200
Message-ID: <20120423122120.GD4935@phenom.ffwll.local>
References: <1335173535-14811-1-git-send-email-daniel.vetter@ffwll.ch>
	<1335174842_26585@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 755989E796
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 23 Apr 2012 05:20:23 -0700 (PDT)
Received: by eaak13 with SMTP id k13so3071892eaa.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 23 Apr 2012 05:20:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1335174842_26585@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Carsten Emde <C.Emde@osadl.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Apr 23, 2012 at 10:53:31AM +0100, Chris Wilson wrote:
> On Mon, 23 Apr 2012 11:32:14 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > There's a bit in the docs for gen4 only that says whether the
> > backlight control is inverted. And both the quirk we have and
> > all bugs only concern i965gm and gm45 (and mostly Acer) afaics.
> > 
> > So lets drop the quirk and use the bit instead.
> > 
> > Also clean up the BLC register definitions a bit by correctly
> > grouping the CTL and CTL2 definitions together.
> > 
> > This quirk was originally added in
> > 
> > commit 5a15ab5b93e4a3ebcd4fa6c76cf646a45e9cf806
> > Author: Carsten Emde <C.Emde@osadl.org>
> > Date:   Thu Mar 15 15:56:27 2012 +0100
> > 
> >     drm/i915: panel: invert brightness acer aspire 5734z
> > 
> > Cc: Carsten Emde <C.Emde@osadl.org>
> > References: https://bugzilla.kernel.org/show_bug.cgi?id=31522
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=37986
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=40455
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Oh, light dawns. That explains the polarity bit.
> 
> Hmm, on PCH this bit is moved to 29 (expect for early IBX silicon)
> according to my specs.

On my specs bit29 is pipe assignement, we should set it if the panel is on
pipe B (well, it just takes the pll to do the modulation from that pipe
then).
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48