From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 05/13] drm/i915: Insert a flush between batches if the breadcrumb was dropped Date: Sat, 14 Jul 2012 15:39:50 +0200 Message-ID: <20120714133950.GC5498@phenom.ffwll.local> References: <1342185256-16024-1-git-send-email-chris@chris-wilson.co.uk> <1342185256-16024-6-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id C6CA69E732 for ; Sat, 14 Jul 2012 06:40:04 -0700 (PDT) Received: by wgbds1 with SMTP id ds1so1188508wgb.0 for ; Sat, 14 Jul 2012 06:40:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1342185256-16024-6-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 13, 2012 at 02:14:08PM +0100, Chris Wilson wrote: > If we drop the breadcrumb request after a batch due to a signal for > example we aim to fix it up at the next opportunity. In this case we > emit a second batchbuffer with no waits upon the first and so no > opportunity to insert the missing request, so we need to emit the > missing flush for coherency. (Note that that invalidating the render > cache is the same as flushing it, so there should have been no > observable corruption.) > > Signed-off-by: Chris Wilson Ok, now that I've got some more clue about how this all blows up, I've merged this patch here (with a rather decently pimped commit message). Thanks for digging into this & feeding me the lacking clue. Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48