From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Workaround hang with BSD and forcewake on SandyBridge
Date: Sun, 15 Jul 2012 17:05:44 +0200 [thread overview]
Message-ID: <20120715150544.GC5184@phenom.ffwll.local> (raw)
In-Reply-To: <1342341758-1261-1-git-send-email-chris@chris-wilson.co.uk>
On Sun, Jul 15, 2012 at 09:42:38AM +0100, Chris Wilson wrote:
> For reasons that are not apparent to anybody, 990bbdadaba (drm/i915:
> Group the GT routines together in both code and vtable) breaks the use
> of the BitStream Decoder ring on SandyBridge. The active ingredient of
> that patch is the conversion from a udelay(10) to a udelay(1) in the
> busy-wait loop of waiting for the forcewake acknowledge. If we restore
> that udelay(10) or insert another udelay(1) afterwards (or any wait
> longer than 250ns) everything works again. An alternative is also to
> remove any delay from the busy-wait loop.
>
> Given that in the atomic sections we want to complete the wait as quick
> as possible to avoid blocking the CPU for too long, it makes sense to
> remove the delay altogether and simply spin on the exit condition until
> it completes. So we replace the udelay(1) with cpu_relax().
>
> Papers over regression from
>
> commit 990bbdadabaa51828e475eda86ee5720a4910cc3
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Mon Jul 2 11:51:02 2012 -0300
>
> drm/i915: Group the GT routines together in both code and vtable
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51738
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Dragon, iceberg or elephant, that's the question ...
Patch merged to dinq, thanks a lot for wrestling the strange things in
this dungeon.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-07-15 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 8:42 [PATCH] drm/i915: Workaround hang with BSD and forcewake on SandyBridge Chris Wilson
2012-07-15 15:05 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120715150544.GC5184@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).