From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/9] drm/i915: move all rps state into dev_priv->rps
Date: Wed, 25 Jul 2012 23:26:03 +0200 [thread overview]
Message-ID: <20120725212603.GG5396@phenom.ffwll.local> (raw)
In-Reply-To: <20120725122500.6723f67f@bwidawsk.net>
On Wed, Jul 25, 2012 at 12:25:00PM -0700, Ben Widawsky wrote:
> On Tue, 24 Jul 2012 23:33:45 +0200
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> > This way it's easier so see what belongs together, and what is used
> > by the ilk ips code. Also add some comments that explain the locking.
> >
> > v2: Missed one place that the dev_priv->ips change caught ...
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> With a few comments below
>
> > + /* gen6+ rps state */
> > + struct {
> > + struct work_struct work;
> > + u32 pm_iir;
> > + /* lock - irqsave spinlock that protectects the work_struct and
> > + * pm_iir. */
> > + spinlock_t lock;
> > +
> > + /* The below variables an all the rps hw state are protected by
> > + * dev->struct mutext. */
> > + u8 cur_delay;
> > + u8 min_delay;
> > + u8 max_delay;
> > + } rps;
> > +
> >
> > u8 cur_delay;
> > u8 min_delay;
>
> Could you add the reason for adding new cur/min/max delays to the commit
> message? From just this hunk it would seem we'd want to remove the old
> cur/min/max.
I'll add a comment that (cur|min|max)_delay need to be duplicated, because
they're also used by the ips code when applying the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-07-25 21:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 21:33 [PATCH 0/9] rps locking fixes Daniel Vetter
2012-07-24 21:33 ` [PATCH 1/9] drm/i915: ensure rps state is properly lock-protected Daniel Vetter
2012-07-24 21:33 ` [PATCH 2/9] drm/i915: properly guard ilk ips state Daniel Vetter
2012-07-25 18:09 ` Ben Widawsky
2012-07-25 18:57 ` [PATCH] " Daniel Vetter
2012-07-24 21:33 ` [PATCH 3/9] drm/i915: fixup up debugfs rps state handling Daniel Vetter
2012-07-25 18:15 ` Ben Widawsky
2012-07-24 21:33 ` [PATCH 4/9] drm/i915: move all rps state into dev_priv->rps Daniel Vetter
2012-07-25 19:25 ` Ben Widawsky
2012-07-25 21:26 ` Daniel Vetter [this message]
2012-07-24 21:33 ` [PATCH 5/9] drm/i915: kill dev_priv->mchdev_lock Daniel Vetter
2012-07-24 21:33 ` [PATCH 6/9] drm/i915: DE_PCU_EVENT irq is ilk-only Daniel Vetter
2012-07-25 21:09 ` Ben Widawsky
2012-07-24 21:33 ` [PATCH 7/9] drm/i915: fix up ilk drps/ips locking Daniel Vetter
2012-07-24 21:33 ` [PATCH 8/9] drm/ips: move drps/ips/ilk related variables into dev_priv->ips Daniel Vetter
2012-07-25 21:25 ` Ben Widawsky
2012-07-25 21:32 ` Daniel Vetter
2012-07-25 23:52 ` Ben Widawsky
2012-07-24 21:33 ` [PATCH 9/9] drm/i915: enable rc6 on ilk again Daniel Vetter
2012-07-25 21:26 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120725212603.GG5396@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).