From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 05/76] drm/i915: prepare load-detect pipe
 code for dpms changes
Date: Wed, 29 Aug 2012 10:07:31 -0700
Message-ID: <20120829100731.3115d770@jbarnes-x220>
References: <1343328581-2324-1-git-send-email-daniel.vetter@ffwll.ch>
	<1343328581-2324-6-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy7-pub.bluehost.com (oproxy7-pub.bluehost.com
	[67.222.55.9])
	by gabe.freedesktop.org (Postfix) with SMTP id 1F6B99F36F
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 29 Aug 2012 10:07:33 -0700 (PDT)
In-Reply-To: <1343328581-2324-6-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 26 Jul 2012 20:48:30 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> A few things need adjustement:
> - Change the dpms state by calling the dpms connector function and
>   not some crtc helper internal callbacks. Otherwise this will break
>   once we switch to our own dpms handling.
> - Instead of tracking and restoring intel_crtc->dpms_mode use the
>   connector's dpms variable - the former relies on the dpms compuation
>   rules used by the crtc helper. And it would break when the encoder
>   is cloned and the other output has a different dpms state. But
> luckily no one is crazy enough for that.
> - Properly clear the connector -> encoder -> crtc linking, even when
>   failing (note that the crtc helper removes the encoder -> crtc link
>   in disabled_unused_functions for us).

Can this be split into 2 patches?  One for the switch to using the
connector helper, and the other to clean up the fail logic and change
to using the connector dpms state?

Jesse