Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: optimize the shmem_pwrite slowpath handling
Date: Thu, 29 Nov 2012 13:49:41 +0100
Message-ID: <20121129124941.GL3202@phenom.ffwll.local> (raw)
In-Reply-To: <eeac1e$50v04d@AZSMGA002.ch.intel.com>

On Thu, Nov 15, 2012 at 04:07:45PM +0000, Chris Wilson wrote:
> On Thu, 15 Nov 2012 16:53:58 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Since we drop dev->struct_mutex when going through the slowpath, the
> > object might have been moved out of the cpu domain. Hence we need to
> > clflush the entire object to ensure that after the ioctl returns,
> > everything is coherent again (interwoven writes are ill-defined
> > anyway).
> > 
> > But we only need to do this if we start in the cpu domain and the
> > object requires flushing for coherency. So don't do the flushing if
> > the object is coherent anyway or if we've done in-line clfushing
> > already.
> > 
> > v2: i915_gem_clflush_object already checks whether the object is
> > coherent and if so, drops the flushing. Hence we don't need to check
> > that ourselves, simplifying the condition.
> > 
> > v3: Reorder the checks for better clarify (and adjust the comment
> > accordingly), suggested by Chris Wilson.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Yup, the comment makes much more sense now.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Both patches merged to dinq, thanks a lot for the review comments.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 14:40 [PATCH 1/2] drm/i915: simplify shmem pwrite/pread " Daniel Vetter
2012-11-15 14:40 ` [PATCH 2/2] drm/i915: optimize the shmem_pwrite " Daniel Vetter
2012-11-15 15:00   ` Chris Wilson
2012-11-15 15:02   ` Chris Wilson
2012-11-15 15:20     ` [PATCH] " Daniel Vetter
2012-11-15 15:37       ` Chris Wilson
2012-11-15 15:53         ` Daniel Vetter
2012-11-15 16:07           ` Chris Wilson
2012-11-29 12:49             ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121129124941.GL3202@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git