From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Close race between processing unpin task and queueing the flip
Date: Thu, 6 Dec 2012 14:10:28 +0100 [thread overview]
Message-ID: <20121206131028.GQ11556@phenom.ffwll.local> (raw)
In-Reply-To: <1354534590-3377-1-git-send-email-chris@chris-wilson.co.uk>
On Mon, Dec 03, 2012 at 11:36:30AM +0000, Chris Wilson wrote:
> Before queuing the flip but crucially after attaching the unpin-work to
> the crtc, we continue to setup the unpin-work. However, should the
> hardware fire early, we see the connected unpin-work and queue the task.
> The task then promptly runs and unpins the fb before we finish taking
> the required references or even pinning it... Havoc.
>
> To close the race, we use the flip-pending atomic to indicate when the
> flip is finally setup and enqueued. So during the flip-done processing,
> we can check more accurately whether the flip was expected.
>
> v2: Add the appropriate mb() to ensure that the writes to the page-flip
> worker are complete prior to marking it active and emitting the MI_FLIP.
> On the read side, the mb should be enforced by the spinlocks.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org
Merged to -fixes, with the barrier changes we've discussed on irc applied
(and the reasoning for why we need 2 on each sided added to my commit
message note).
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-12-06 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 11:36 [PATCH] drm/i915: Close race between processing unpin task and queueing the flip Chris Wilson
2012-12-06 13:10 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-03 11:25 Chris Wilson
2012-12-01 17:48 Chris Wilson
2012-12-01 20:35 ` Daniel Vetter
2012-12-01 22:32 ` Chris Wilson
2012-12-02 1:15 ` Daniel Vetter
2012-12-02 9:26 ` Chris Wilson
2012-12-02 11:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206131028.GQ11556@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).