From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Fixup hpd irq register setup ordering
Date: Mon, 10 Dec 2012 13:01:43 -0800 [thread overview]
Message-ID: <20121210130143.5e8abcd0@jbarnes-desktop> (raw)
In-Reply-To: <1355082121-15869-1-git-send-email-daniel.vetter@ffwll.ch>
On Sun, 9 Dec 2012 20:42:01 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> For GMCH platforms we set up the hpd irq registers in the irq
> postinstall hook. But since we only enable the irq sources we actually
> need in PORT_HOTPLUG_EN/STATUS, taking dev_priv->hotplug_supported_mask
> into account, no hpd interrupt sources is enabled since
>
> commit 52d7ecedac3f96fb562cb482c139015372728638
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Sat Dec 1 21:03:22 2012 +0100
>
> drm/i915: reorder setup sequence to have irqs for output setup
>
> Wrongly set-up interrupts also lead broken hw-based load-detection on
> at least GM45, resulting in ghost VGA/TV-out outputs.
..."can lead to broken"... or "also leads to" ?
> +
> +void intel_hpd_init(struct drm_device *dev)
> +{
> + struct drm_i915_private *dev_priv = dev->dev_private;
> +
> + if (dev_priv->display.hpd_irq_setup)
> + dev_priv->display.hpd_irq_setup(dev);
> +
> + /*
> + * Some ports require correctly set-up hpd registers for detection to
> + * work properly, e.g. VGA on gm45. Hence we can only set up the initial
> + * fbdev config after hpd irqs are fully enabled. Now we should scan for
> + * the initial config only once hotplug handling is enabled, but due to
> + * screwed-up locking around kms/fbdev init we can't protect the fdbev
> + * initial config scanning against hotplug events. Hence do this first
> + * and ignore the tiny window where we will loose hotplug notifactions.
> + */
> + intel_fbdev_initial_config(dev);
> +
> + /* Only enable hotplug handling once the fbdev is fully set up. */
> + dev_priv->enable_hotplug_processing = true;
> +
> + drm_kms_helper_poll_init(dev);
> +}
I'd rather see these calls in load_modeset_init(). Having
fbdev_initial_config here at least is confusing, and since poll_init
depends on it...
With those two nits:
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-12-10 21:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 19:14 [PATCH] drm/i915: Fixup hpd irq register setup ordering Daniel Vetter
2012-12-09 19:17 ` Daniel Vetter
2012-12-09 19:42 ` Daniel Vetter
2012-12-10 13:40 ` Chris Wilson
2012-12-10 21:01 ` Jesse Barnes [this message]
2012-12-10 21:55 ` Daniel Vetter
2012-12-11 13:05 ` Daniel Vetter
2012-12-11 15:58 ` Imre Deak
2012-12-11 16:24 ` Daniel Vetter
2012-12-11 12:06 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210130143.5e8abcd0@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).