From: Damien Lespiau <damien.lespiau@intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
GFX <intel-gfx@lists.freedesktop.org>,
Intel@shiva.chad-versace.us
Subject: Re: [PATCH 5/6] drm/i915: Add probe and remove to the gtt ops
Date: Tue, 29 Jan 2013 08:30:42 +0000 [thread overview]
Message-ID: <20130129083042.GE6187@dyon.amr.corp.intel.com> (raw)
In-Reply-To: <1359064198-998-5-git-send-email-ben@bwidawsk.net>
On Thu, Jan 24, 2013 at 01:49:57PM -0800, Ben Widawsky wrote:
> The idea, and much of the code came originally from:
>
> commit 0712f0249c3148d8cf42a3703403c278590d4de5
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date: Fri Jan 18 17:23:16 2013 -0800
>
> drm/i915: Create a vtable for i915 gtt
>
> Daniel didn't like the color of that patch series, and so I asked him to
> start something which appealed to his sense of color. The preceding
> patches are those, and now this is going on top of that.
>
> [extracted from the original commit message]
>
> One immediately obvious thing to implement is our gmch probing. The init
> function was getting massively bloated. Fundamentally, all that's needed
> from GMCH probing is the GTT size, and the stolen size. It makes design
> sense to put the mappable calculation in there as well, but the code
> turns out a bit nicer without it (IMO)
>
> The intel_gtt bridge thing is still here, but the subsequent patches
> will finish ripping that out.
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
next prev parent reply other threads:[~2013-01-29 8:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 15:50 [PATCH 0/4] gtt abstractions Daniel Vetter
2013-01-24 15:50 ` [PATCH 1/4] drm/i915: vfuncs for gtt_clear_range/insert_entries Daniel Vetter
2013-01-24 15:50 ` [PATCH 2/4] drm/i915: vfuncs for ppgtt Daniel Vetter
2013-01-24 15:50 ` [PATCH 3/4] drm/i915: pte_encode is gen6+ Daniel Vetter
2013-01-24 15:50 ` [PATCH 4/4] drm/i915: extract hw ppgtt setup/cleanup code Daniel Vetter
2013-01-24 19:41 ` [PATCH 0/4] gtt abstractions Ben Widawsky
2013-01-24 21:49 ` [PATCH 1/6] drm/i915: vfuncs for gtt_clear_range/insert_entries Ben Widawsky
2013-01-24 21:49 ` [PATCH 2/6] drm/i915: vfuncs for ppgtt Ben Widawsky
2013-01-24 21:49 ` [PATCH 3/6] drm/i915: pte_encode is gen6+ Ben Widawsky
2013-01-24 21:49 ` [PATCH 4/6] drm/i915: extract hw ppgtt setup/cleanup code Ben Widawsky
2013-01-29 7:58 ` Damien Lespiau
2013-01-24 21:49 ` [PATCH 5/6] drm/i915: Add probe and remove to the gtt ops Ben Widawsky
2013-01-29 8:30 ` Damien Lespiau [this message]
2013-01-24 21:49 ` [PATCH 6/6] drm/i915: Resume dissecting intel_gtt Ben Widawsky
2013-01-24 22:44 ` [PATCH 1/6] drm/i915: vfuncs for gtt_clear_range/insert_entries Ben Widawsky
2013-01-24 22:44 ` [PATCH 2/6] drm/i915: vfuncs for ppgtt Ben Widawsky
2013-01-29 7:44 ` Damien Lespiau
2013-01-24 22:44 ` [PATCH 3/6] drm/i915: pte_encode is gen6+ Ben Widawsky
2013-01-29 7:46 ` Damien Lespiau
2013-01-24 22:44 ` [PATCH 4/6] drm/i915: extract hw ppgtt setup/cleanup code Ben Widawsky
2013-01-24 22:44 ` [PATCH 5/6] drm/i915: Add probe and remove to the gtt ops Ben Widawsky
2013-01-24 22:45 ` [PATCH 6/6] drm/i915: Resume dissecting intel_gtt Ben Widawsky
2013-01-29 8:40 ` Damien Lespiau
2013-01-29 19:02 ` Ben Widawsky
2013-01-29 7:42 ` [PATCH 1/6] drm/i915: vfuncs for gtt_clear_range/insert_entries Damien Lespiau
2013-01-29 9:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129083042.GE6187@dyon.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=Intel@shiva.chad-versace.us \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).