From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Ben Widawsky <ben@bwidawsk.net>,
vincent.beng.keat.cheah@intel.com,
intel-gfx@lists.freedesktop.org,
alan.previn.teres.alexis@intel.com
Subject: Re: [PATCH 00/10] [RFC v2] quick dump
Date: Sun, 3 Feb 2013 12:22:25 +0000 [thread overview]
Message-ID: <20130203122225.GC9892@cantiga.alporthouse.com> (raw)
In-Reply-To: <20130203102915.44288d05@jbarnes-t420>
On Sun, Feb 03, 2013 at 10:29:15AM +0100, Jesse Barnes wrote:
> On Sat, 2 Feb 2013 16:07:52 -0800
> Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > This is my second attempt at winning approval for the series. First one
> > was: https://patchwork.kernel.org/patch/1493131/
> >
> > In spending the time to rework this tool, I've begun to lose my belief
> > in some of the original motivations I had. Even if you don't want to
> > review, but just like (or dislike) what you see, I'd appreciate such
> > comments.
>
> I'd like to see it land in i-g-t. Having the regs defined in a text or
> xml file is an improvement over what we have today, and is easier to
> extend. At first the advantage of reg_dumper was that it parsed out
> the bitfields of the various regs. But we didn't keep up with that,
> and also haven't kept up with the regs on new platforms as well as we
> could. Text files would make that easier, and xml files might bring
> back the bit field parsing, which would be extra nice.
Completely agree. For me the big improvement would be being able to use
the bspec register names or our internal approximation thereof rather
than having to loop up the actual addresses every time.
Having the name database available in python should make building
integrated little snippets to parse traces which are also python
accessible.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-02-03 12:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 0:07 [PATCH 00/10] [RFC v2] quick dump Ben Widawsky
2013-02-03 0:07 ` [PATCH 01/10] configure.ac: Fix spacing Ben Widawsky
2013-02-03 0:07 ` [PATCH 02/10] configure.ac: Add vim magic modeline Ben Widawsky
2013-02-03 0:07 ` [PATCH 03/10] quick_dump: A dump utility different than reg_dumper Ben Widawsky
2013-02-03 0:07 ` [PATCH 04/10] quick_dump: gen6 support Ben Widawsky
2013-02-03 0:07 ` [PATCH 05/10] quick_dump: gen7 support Ben Widawsky
2013-02-03 0:07 ` [PATCH 06/10] quick_dump: vlv support Ben Widawsky
2013-02-03 0:07 ` [PATCH 07/10] configure.ac: Add swig dependency Ben Widawsky
2013-02-03 0:08 ` [PATCH 08/10] quick_dump: SWIG chipset interface Ben Widawsky
2013-02-04 18:21 ` Matt Turner
2013-02-03 0:08 ` [PATCH 09/10] quick_dump: Connect libpciaccess and other utils Ben Widawsky
2013-02-03 18:15 ` Ben Widawsky
2013-02-03 0:08 ` [PATCH 10/10] quick_dump: Use the register access library Ben Widawsky
2013-02-03 9:29 ` [PATCH 00/10] [RFC v2] quick dump Jesse Barnes
2013-02-03 12:22 ` Chris Wilson [this message]
2013-02-03 18:13 ` Ben Widawsky
2013-02-04 15:10 ` Daniel Vetter
2013-02-04 18:19 ` Ben Widawsky
2013-02-05 11:59 ` Damien Lespiau
2013-02-05 16:48 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203122225.GC9892@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=alan.previn.teres.alexis@intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=vincent.beng.keat.cheah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).