From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Scale ring, rather than ia,
 frequency on Haswell
Date: Wed, 10 Apr 2013 22:08:20 +0200
Message-ID: <20130410200820.GL27612@phenom.ffwll.local>
References: <1365621743-2761-1-git-send-email-chris@chris-wilson.co.uk>
	<1365623111-3133-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f174.google.com (mail-ea0-f174.google.com
	[209.85.215.174])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7CF2EE5CE2
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 10 Apr 2013 13:05:21 -0700 (PDT)
Received: by mail-ea0-f174.google.com with SMTP id m14so422515eaj.33
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 10 Apr 2013 13:05:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1365623111-3133-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Apr 10, 2013 at 08:45:11PM +0100, Chris Wilson wrote:
> Haswell introduces a separate frequency domain for the ring (uncore). So
> where we used to increase the CPU (IA) clock with GPU busyness, we now
> need to scale the ring frequency directly instead. As the ring limits
> our memory bandwidth, it is vital for performance that when the GPU is
> busy, we increase the frequency of the ring to increase the available
> memory bandwidth.
> 
> v2: Fix the algorithm to actually use the scaled gpu frequency for the ring.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>

I think this is another reason to split hsw rps code from snb/ivb. I think
I'll wait until Rodrigo's patch is in, and then apply this.

Call me a scared chicken, but I kinda am wrt rps stuff ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch