From: Zhiyuan Lv <zhiyuan.lv@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org, igvt-g@lists.01.org, "Wang,
Zhi A" <zhi.a.wang@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCH 4/7] drm/i915: always pin lrc context for vgpu with Intel GVT-g
Date: Fri, 21 Aug 2015 14:13:12 +0800 [thread overview]
Message-ID: <20150821061312.GB22270@zlv-hp-dev> (raw)
In-Reply-To: <20150820091654.GD3226@zlv-hp-dev>
Hi Chris,
If we cannot always pin lr context into GGTT, the LRCA cannot be used
as a context identifier for us. Then we have to consider a proper
interface for i915 in VM to notify GVT-g device model.
The context creation might be OK. We can pin context first, then
notify the context creation, after that, unpin the context. In GVT-g,
we can get the context's guest physical addresses from GTT table, and
use that to identify a guest context.
But the destroy can be a problem. It does not make sense to pin
context and unpin that time right?
Do you have any suggestions/comments? Thanks in advance!
Regards,
-Zhiyuan
On Thu, Aug 20, 2015 at 05:16:54PM +0800, Zhiyuan Lv wrote:
> Hi Chris,
>
> On Thu, Aug 20, 2015 at 09:36:00AM +0100, Chris Wilson wrote:
> > On Thu, Aug 20, 2015 at 03:45:21PM +0800, Zhiyuan Lv wrote:
> > > Intel GVT-g will perform EXECLIST context shadowing and ring buffer
> > > shadowing. The shadow copy is created when guest creates a context.
> > > If a context changes its LRCA address, the hypervisor is hard to know
> > > whether it is a new context or not. We always pin context objects to
> > > global GTT to make life easier.
> >
> > Nak. Please explain why we need to workaround a bug in the host. We
> > cannot pin the context as that breaks userspace (e.g. synmark) who can
> > and will try to use more contexts than we have room.
>
> This change is only for i915 running inside a VM. Host i915 driver's
> behavior will not be impacted.
>
> The reason we want to pin context is that our hypervisor identifies
> guest contexts with their LRCA, and need LRCA unchanged during
> contexts' life cycle so that shadow copy of contexts can easily find
> their counterparts. If we cannot pin them, we have to consider more
> complicated shadow implementation ...
>
> BTW Chris, are there many apps like synmark that may used up GGTT with
> contexts if they are all pinned? Thanks!
>
> Regards,
> -Zhiyuan
>
> > -Chris
> >
> > --
> > Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-21 6:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 7:45 [PATCH 0/7] drm/intel: guest i915 changes for Broadwell to run inside VM with Intel GVT-g Zhiyuan Lv
2015-08-20 7:45 ` [PATCH 1/7] drm/i915: preallocate pdps for 32 bit vgpu Zhiyuan Lv
2015-08-20 10:56 ` Joonas Lahtinen
2015-08-26 13:21 ` Mika Kuoppala
2015-08-20 7:45 ` [PATCH 2/7] drm/i915: Enable full ppgtt for vgpu Zhiyuan Lv
2015-08-20 10:57 ` Joonas Lahtinen
2015-08-26 8:47 ` Daniel Vetter
2015-08-27 2:28 ` Zhiyuan Lv
2015-09-02 8:06 ` Daniel Vetter
2015-08-20 7:45 ` [PATCH 3/7] drm/i915: Always enable execlists on BDW " Zhiyuan Lv
2015-08-20 8:34 ` Chris Wilson
2015-08-20 8:55 ` Zhiyuan Lv
2015-08-20 9:22 ` Chris Wilson
2015-08-20 9:40 ` Zhiyuan Lv
2015-08-20 11:23 ` Joonas Lahtinen
2015-08-21 2:24 ` Zhiyuan Lv
2015-08-24 12:36 ` Joonas Lahtinen
2015-08-26 8:50 ` Daniel Vetter
2015-08-27 2:49 ` Zhiyuan Lv
2015-09-02 8:06 ` Daniel Vetter
2015-08-21 5:37 ` [iGVT-g] " Tian, Kevin
2015-08-20 7:45 ` [PATCH 4/7] drm/i915: always pin lrc context for vgpu with Intel GVT-g Zhiyuan Lv
2015-08-20 8:36 ` Chris Wilson
2015-08-20 9:16 ` Zhiyuan Lv
2015-08-21 6:13 ` Zhiyuan Lv [this message]
2015-08-24 10:04 ` About the iGVT-g's requirement to pin guest contexts in VM Zhiyuan Lv
2015-08-24 10:23 ` Chris Wilson
2015-08-24 17:18 ` Wang, Zhi A
2015-08-26 16:42 ` Wang, Zhi A
2015-08-25 0:17 ` Zhiyuan Lv
2015-08-26 8:56 ` Daniel Vetter
2015-08-27 1:50 ` Zhiyuan Lv
2015-09-02 8:19 ` Daniel Vetter
2015-09-02 9:20 ` Zhiyuan Lv
2015-09-02 9:40 ` Daniel Vetter
2015-08-20 7:45 ` [PATCH 5/7] drm/i915: Update PV INFO page definition for Intel GVT-g Zhiyuan Lv
2015-08-20 12:58 ` Joonas Lahtinen
2015-08-21 2:27 ` Zhiyuan Lv
2015-08-20 7:45 ` [PATCH 6/7] drm/i915: guest i915 notification for Intel-GVTg Zhiyuan Lv
2015-08-20 13:11 ` Joonas Lahtinen
2015-08-21 2:39 ` Zhiyuan Lv
2015-08-20 7:45 ` [PATCH 7/7] drm/i915: Allow Broadwell guest with Intel GVT-g Zhiyuan Lv
2015-08-20 13:15 ` Joonas Lahtinen
-- strict thread matches above, loose matches on Subject: below --
2015-08-20 3:18 [PATCH 4/7] drm/i915: always pin lrc context for vgpu " Zhiyuan Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821061312.GB22270@zlv-hp-dev \
--to=zhiyuan.lv@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igvt-g@lists.01.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kevin.tian@intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).