On 2020.01.17 17:15:36 +0200, Jani Nikula wrote: > On Mon, 21 Oct 2019, Chris Wilson wrote: > > Quoting Zhenyu Wang (2019-10-21 06:37:24) > >> On 2019.10.16 19:39:02 +0100, Chris Wilson wrote: > >> > Stop trying to escape out of the gvt layer to find the engine that we > >> > initially setup for use with gvt. Record the engines during initialisation > >> > and use them henceforth. > >> > > >> > add/remove: 1/4 grow/shrink: 22/28 up/down: 341/-1410 (-1069) > >> > > >> > Signed-off-by: Chris Wilson > >> > --- > >> > >> Thanks for this cleanup! Quick review seems good to me, although it > >> looks pretty fine for me on ring_id replacement, this big one also > >> includes other changes like indent fix, debugfs item change, etc. > >> Could we split them for easier merge? Can have a gvt developer to > >> help on that. > > > > Just make gvt/ checkpatch clean so that CI doesn't reject patches > > because the surrounding code does not conform to coding style. > > Sadly this has fallen between the cracks. Could someone pick this up > again please, maybe from the gvt team? > yes, I've had one person to help on this one, will refresh this later. Thanks -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827