intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Gupta <anshuman.gupta@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH rebased 1/3] drm/i915/dc3co: Do the full calculation of DC3CO exit only once
Date: Mon, 20 Jan 2020 09:51:49 +0530	[thread overview]
Message-ID: <20200120042149.GB20564@intel.com> (raw)
In-Reply-To: <20200116185421.66585-1-jose.souza@intel.com>

Looks good to me.
On 2020-01-16 at 10:54:19 -0800, José Roberto de Souza wrote:
> This will calculaet the DC3CO exit delay only once per full modeset.
> 
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 1d2fd1a8925a..e64e0c4c80dc 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -802,7 +802,9 @@ static void intel_psr_enable_locked(struct drm_i915_private *dev_priv,
>  	dev_priv->psr.busy_frontbuffer_bits = 0;
>  	dev_priv->psr.pipe = to_intel_crtc(crtc_state->uapi.crtc)->pipe;
>  	dev_priv->psr.dc3co_enabled = !!crtc_state->dc3co_exitline;
> -	dev_priv->psr.dc3co_exit_delay = intel_get_frame_time_us(crtc_state);
> +	/* DC5/DC6 required idle frames = 6 */
> +	val = usecs_to_jiffies(intel_get_frame_time_us(crtc_state) * 6);
> +	dev_priv->psr.dc3co_exit_delay = val;
>  	dev_priv->psr.transcoder = crtc_state->cpu_transcoder;
>  
>  	/*
> @@ -1277,8 +1279,6 @@ static void
>  tgl_dc3co_flush(struct drm_i915_private *dev_priv,
>  		unsigned int frontbuffer_bits, enum fb_op_origin origin)
>  {
> -	u32 delay;
> -
>  	mutex_lock(&dev_priv->psr.lock);
>  
>  	if (!dev_priv->psr.dc3co_enabled)
> @@ -1296,10 +1296,8 @@ tgl_dc3co_flush(struct drm_i915_private *dev_priv,
>  		goto unlock;
>  
>  	tgl_psr2_enable_dc3co(dev_priv);
> -	/* DC5/DC6 required idle frames = 6 */
> -	delay = 6 * dev_priv->psr.dc3co_exit_delay;
>  	mod_delayed_work(system_wq, &dev_priv->psr.idle_work,
> -			 usecs_to_jiffies(delay));
> +			 dev_priv->psr.dc3co_exit_delay);
>  
>  unlock:
>  	mutex_unlock(&dev_priv->psr.lock);
> -- 
> 2.25.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2020-01-20  4:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 18:54 [Intel-gfx] [PATCH rebased 1/3] drm/i915/dc3co: Do the full calculation of DC3CO exit only once José Roberto de Souza
2020-01-16 18:54 ` [Intel-gfx] [PATCH rebased 2/3] drm/i915/dc3co: Check for DC3C0 exit state instead of sleep José Roberto de Souza
2020-01-20  4:12   ` Anshuman Gupta
2020-01-16 18:54 ` [Intel-gfx] [PATCH rebased 3/3] drm/i915/dc3co: Avoid full modeset when EXITLINE needs to be changed José Roberto de Souza
2020-01-20  4:38   ` Anshuman Gupta
2020-01-16 20:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [rebased,1/3] drm/i915/dc3co: Do the full calculation of DC3CO exit only once Patchwork
2020-01-16 20:41 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-19 22:14 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2020-01-20  4:21 ` Anshuman Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200120042149.GB20564@intel.com \
    --to=anshuman.gupta@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).