From: Anshuman Gupta <anshuman.gupta@intel.com>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2 2/5] drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS
Date: Thu, 13 Feb 2020 17:07:49 +0530 [thread overview]
Message-ID: <20200213113748.GC11041@intel.com> (raw)
In-Reply-To: <20200212102942.26568-3-ramalingam.c@intel.com>
On 2020-02-12 at 15:59:39 +0530, Ramalingam C wrote:
> Need to extract the 2 most significant bits from a byte for constructing
> the revoked KSV count of the SRM.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> include/drm/drm_hdcp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> index d512089b873f..c6bab4986a65 100644
> --- a/include/drm/drm_hdcp.h
> +++ b/include/drm/drm_hdcp.h
> @@ -276,7 +276,7 @@ void drm_hdcp_cpu_to_be24(u8 seq_num[HDCP_2_2_SEQ_NUM_LEN], u32 val)
> #define DRM_HDCP_2_VRL_LENGTH_SIZE 3
> #define DRM_HDCP_2_DCP_SIG_SIZE 384
> #define DRM_HDCP_2_NO_OF_DEV_PLUS_RESERVED_SZ 4
> -#define DRM_HDCP_2_KSV_COUNT_2_LSBITS(byte) (((byte) & 0xC) >> 6)
> +#define DRM_HDCP_2_KSV_COUNT_2_LSBITS(byte) (((byte) & 0xC0) >> 6)
LGTM, verified wrt Table 5.1 HDCP HDMI specs page 64.
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
>
> struct hdcp_srm_header {
> u8 srm_id;
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-13 11:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 10:29 [Intel-gfx] [PATCH v2 0/5] HDCP misc Ramalingam C
2020-02-12 10:29 ` [Intel-gfx] [PATCH v2 1/5] drm/hdcp: optimizing the srm handling Ramalingam C
2020-02-18 15:43 ` Sean Paul
2020-02-12 10:29 ` [Intel-gfx] [PATCH v2 2/5] drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS Ramalingam C
2020-02-13 11:37 ` Anshuman Gupta [this message]
2020-02-12 10:29 ` [Intel-gfx] [PATCH v2 3/5] drm/i915: terminate reauth at stream management failure Ramalingam C
2020-02-13 8:51 ` Anshuman Gupta
2020-02-18 15:34 ` Sean Paul
2020-02-12 10:29 ` [Intel-gfx] [PATCH v2 4/5] drm/i915: dont retry stream management at seq_num_m roll over Ramalingam C
2020-02-13 10:37 ` Anshuman Gupta
2020-02-18 15:40 ` Sean Paul
2020-02-12 10:29 ` [Intel-gfx] [PATCH v2 5/5] drm/i915/hdcp: conversion to struct drm_device based logging macros Ramalingam C
2020-02-12 11:31 ` Jani Nikula
2020-02-12 11:39 ` Ramalingam C
2020-02-13 0:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP misc (rev2) Patchwork
2020-02-13 0:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-15 23:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-04 1:58 ` [Intel-gfx] [PATCH v2 0/5] HDCP misc Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213113748.GC11041@intel.com \
--to=anshuman.gupta@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).